DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

clang -Wextra (more all that -Wall) (flutter/engine#2766)

Browse Source 
I noticed this while doing the libjpeg_turbo roll.
This commit is contained in:
Ian Hickson 2016-06-17 12:38:10 -07:00 committed by GitHub
parent 6acced5b6d
commit 3a88860803
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/build/config/compiler/BUILD.gn
View File

@ -932,12 +932,7 @@ config("chromium_code") {
} else {
cflags = [
"-Wall",
# GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
# so we specify it explicitly.
# TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
# http://code.google.com/p/chromium/issues/detail?id=90453
"-Wsign-compare",
"-Wextra",
]
# In Chromium code, we define __STDC_foo_MACROS in order to get the

2
engine/src/flutter/flow/layers/layer.h
View File

@ -64,7 +64,7 @@ class Layer {
void set_parent(ContainerLayer* parent) { parent_ = parent; }
// subclasses should assume this will be true by the time Paint() is called
const bool has_paint_bounds() const { return has_paint_bounds_; }
bool has_paint_bounds() const { return has_paint_bounds_; }
const SkRect& paint_bounds() const {
DCHECK(has_paint_bounds_);