diff --git a/engine/src/flutter/build/config/compiler/BUILD.gn b/engine/src/flutter/build/config/compiler/BUILD.gn index 90528ac5a1f..04d4bd9c5f5 100644 --- a/engine/src/flutter/build/config/compiler/BUILD.gn +++ b/engine/src/flutter/build/config/compiler/BUILD.gn @@ -932,12 +932,7 @@ config("chromium_code") { } else { cflags = [ "-Wall", - - # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't, - # so we specify it explicitly. - # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it. - # http://code.google.com/p/chromium/issues/detail?id=90453 - "-Wsign-compare", + "-Wextra", ] # In Chromium code, we define __STDC_foo_MACROS in order to get the diff --git a/engine/src/flutter/flow/layers/layer.h b/engine/src/flutter/flow/layers/layer.h index 910893791bd..d322208617e 100644 --- a/engine/src/flutter/flow/layers/layer.h +++ b/engine/src/flutter/flow/layers/layer.h @@ -64,7 +64,7 @@ class Layer { void set_parent(ContainerLayer* parent) { parent_ = parent; } // subclasses should assume this will be true by the time Paint() is called - const bool has_paint_bounds() const { return has_paint_bounds_; } + bool has_paint_bounds() const { return has_paint_bounds_; } const SkRect& paint_bounds() const { DCHECK(has_paint_bounds_);