DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Delete RenderBlockFlow.

Browse Source 
We only ever create RenderParagraphs now. The only non-trivial change here
is making RenderView a RenderFlexibleBox. This required changing custom.sky.
That test was written in a fragile way that behaved differently if we
did multiple layouts. Instead, having it be less racy and only change
values during the test itself.

This also throws a wrench in moving all the layout code to dart
because we can't set the layout manager on the RenderView. Maybe
we need to explicitly let you do so.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1068683002
This commit is contained in:
Ojan Vafai 2015-04-07 16:59:36 -07:00
parent 7352d571d5
commit 3948df5970
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/tests/layout/custom.sky
View File

@ -23,7 +23,6 @@ void main() {
parent.setLayoutManager(() {
if (first) {
first = false;
parent.width = 200.0;
} else {
parent.width = 150.0;
@ -69,6 +68,7 @@ void main() {
expect(secondChild.offsetWidth, equals(200));
assertNonChangingValues();
first = false;
parent.setNeedsLayout();
window.requestAnimationFrame((_) {