From 3948df5970879bcd21b906d168bd683d55332a43 Mon Sep 17 00:00:00 2001 From: Ojan Vafai Date: Tue, 7 Apr 2015 16:59:36 -0700 Subject: [PATCH] Delete RenderBlockFlow. We only ever create RenderParagraphs now. The only non-trivial change here is making RenderView a RenderFlexibleBox. This required changing custom.sky. That test was written in a fragile way that behaved differently if we did multiple layouts. Instead, having it be less racy and only change values during the test itself. This also throws a wrench in moving all the layout code to dart because we can't set the layout manager on the RenderView. Maybe we need to explicitly let you do so. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1068683002 --- engine/src/flutter/tests/layout/custom.sky | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/flutter/tests/layout/custom.sky b/engine/src/flutter/tests/layout/custom.sky index fc7399930e3..b3892a873c1 100644 --- a/engine/src/flutter/tests/layout/custom.sky +++ b/engine/src/flutter/tests/layout/custom.sky @@ -23,7 +23,6 @@ void main() { parent.setLayoutManager(() { if (first) { - first = false; parent.width = 200.0; } else { parent.width = 150.0; @@ -69,6 +68,7 @@ void main() { expect(secondChild.offsetWidth, equals(200)); assertNonChangingValues(); + first = false; parent.setNeedsLayout(); window.requestAnimationFrame((_) {