DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't log success events as errors. (#3921)

Browse Source 
Clean up log messages a bit.
This commit is contained in:
mikejurka 2017-07-27 16:19:18 -07:00 committed by Chinmay Garde
parent 59e44617cf
commit 32f22880c5
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
content_handler/vulkan_surface_producer.cc
View File

@ -16,8 +16,13 @@ VulkanSurfaceProducer::VulkanSurfaceProducer(
mozart::client::Session* mozart_session) {
valid_ = Initialize(mozart_session);
FTL_LOG(ERROR) << "Vulkan surface producer initialization: "
<< (valid_ ? "Successful" : "Failed");
if (valid_) {
FTL_LOG(INFO)
<< "Flutter engine: Vulkan surface producer initialization: Successful";
} else {
FTL_LOG(ERROR)
<< "Flutter engine: Vulkan surface producer initialization: Failed";
}
}
VulkanSurfaceProducer::~VulkanSurfaceProducer() = default;
@ -50,7 +55,7 @@ bool VulkanSurfaceProducer::Initialize(
}
if (!vk_->HasAcquiredMandatoryProcAddresses()) {
FTL_LOG(ERROR) << "Failed to acquire mandatory proc addresses";
FTL_LOG(ERROR) << "Failed to acquire mandatory proc addresses.";
return false;
}
@ -62,13 +67,13 @@ bool VulkanSurfaceProducer::Initialize(
auto interface = vk_->CreateSkiaInterface();
if (interface == nullptr || !interface->validate(0)) {
FTL_LOG(ERROR) << "interface invalid";
FTL_LOG(ERROR) << "Skia interface invalid.";
return false;
}
uint32_t skia_features = 0;
if (!logical_device_->GetPhysicalDeviceFeaturesSkia(&skia_features)) {
FTL_LOG(ERROR) << "Failed to get physical device features";
FTL_LOG(ERROR) << "Failed to get physical device features.";
return false;
}