From 32f22880c5a92bef3e72c2ccaee73871abc18214 Mon Sep 17 00:00:00 2001 From: mikejurka Date: Thu, 27 Jul 2017 16:19:18 -0700 Subject: [PATCH] Don't log success events as errors. (#3921) Clean up log messages a bit. --- content_handler/vulkan_surface_producer.cc | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/content_handler/vulkan_surface_producer.cc b/content_handler/vulkan_surface_producer.cc index a632959c77f..9a29b18e058 100644 --- a/content_handler/vulkan_surface_producer.cc +++ b/content_handler/vulkan_surface_producer.cc @@ -16,8 +16,13 @@ VulkanSurfaceProducer::VulkanSurfaceProducer( mozart::client::Session* mozart_session) { valid_ = Initialize(mozart_session); - FTL_LOG(ERROR) << "Vulkan surface producer initialization: " - << (valid_ ? "Successful" : "Failed"); + if (valid_) { + FTL_LOG(INFO) + << "Flutter engine: Vulkan surface producer initialization: Successful"; + } else { + FTL_LOG(ERROR) + << "Flutter engine: Vulkan surface producer initialization: Failed"; + } } VulkanSurfaceProducer::~VulkanSurfaceProducer() = default; @@ -50,7 +55,7 @@ bool VulkanSurfaceProducer::Initialize( } if (!vk_->HasAcquiredMandatoryProcAddresses()) { - FTL_LOG(ERROR) << "Failed to acquire mandatory proc addresses"; + FTL_LOG(ERROR) << "Failed to acquire mandatory proc addresses."; return false; } @@ -62,13 +67,13 @@ bool VulkanSurfaceProducer::Initialize( auto interface = vk_->CreateSkiaInterface(); if (interface == nullptr || !interface->validate(0)) { - FTL_LOG(ERROR) << "interface invalid"; + FTL_LOG(ERROR) << "Skia interface invalid."; return false; } uint32_t skia_features = 0; if (!logical_device_->GetPhysicalDeviceFeaturesSkia(&skia_features)) { - FTL_LOG(ERROR) << "Failed to get physical device features"; + FTL_LOG(ERROR) << "Failed to get physical device features."; return false; }