Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859)

This reverts commit 72cacb40401c96dad9905cf2b180893ddfd0105d.
This commit is contained in:
Ian Hickson 2019-09-04 17:47:39 -07:00 committed by GitHub
parent b9d9156fa6
commit 2efbc11b7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions

View File

@ -532,6 +532,7 @@ task:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts dev/bots/test.dart
- name: add2app-macos
skip: true # https://github.com/flutter/flutter/issues/39507
env:
SHARD: add2app_test
setup_xcpretty_script:

View File

@ -142,13 +142,11 @@ BuildApp() {
mkdir "${derived_dir}/engine"
RunCommand cp -r -- "${flutter_podspec}" "${derived_dir}/engine"
RunCommand cp -r -- "${flutter_framework}" "${derived_dir}/engine"
# Make non-binary files read-only to discourage editing headers, but allow binary code-signing.
RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w
RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec chmod a-w "{}" \;
else
RunCommand rm -rf -- "${derived_dir}/Flutter.framework"
RunCommand cp -r -- "${flutter_framework}" "${derived_dir}"
# Make non-binary files read-only to discourage editing headers, but allow binary code-signing.
RunCommand find "${derived_dir}/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w
RunCommand find "${derived_dir}/Flutter.framework" -type f -exec chmod a-w "{}" \;
fi
RunCommand pushd "${project_path}" > /dev/null