From 2efbc11b7a3d251326ff1e4da23da63de0058eb8 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Wed, 4 Sep 2019 17:47:39 -0700 Subject: [PATCH] Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859) This reverts commit 72cacb40401c96dad9905cf2b180893ddfd0105d. --- .cirrus.yml | 1 + packages/flutter_tools/bin/xcode_backend.sh | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 958113b3571..d0f37281cf1 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -532,6 +532,7 @@ task: - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - dart --enable-asserts dev/bots/test.dart - name: add2app-macos + skip: true # https://github.com/flutter/flutter/issues/39507 env: SHARD: add2app_test setup_xcpretty_script: diff --git a/packages/flutter_tools/bin/xcode_backend.sh b/packages/flutter_tools/bin/xcode_backend.sh index 143085e6db8..ba4a86cc853 100755 --- a/packages/flutter_tools/bin/xcode_backend.sh +++ b/packages/flutter_tools/bin/xcode_backend.sh @@ -142,13 +142,11 @@ BuildApp() { mkdir "${derived_dir}/engine" RunCommand cp -r -- "${flutter_podspec}" "${derived_dir}/engine" RunCommand cp -r -- "${flutter_framework}" "${derived_dir}/engine" - # Make non-binary files read-only to discourage editing headers, but allow binary code-signing. - RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w + RunCommand find "${derived_dir}/engine/Flutter.framework" -type f -exec chmod a-w "{}" \; else RunCommand rm -rf -- "${derived_dir}/Flutter.framework" RunCommand cp -r -- "${flutter_framework}" "${derived_dir}" - # Make non-binary files read-only to discourage editing headers, but allow binary code-signing. - RunCommand find "${derived_dir}/Flutter.framework" -type f -exec grep -Il '.' {} \; | xargs chmod a-w + RunCommand find "${derived_dir}/Flutter.framework" -type f -exec chmod a-w "{}" \; fi RunCommand pushd "${project_path}" > /dev/null