DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove maxdiff for backdrop_filter_clip_moved (flutter/engine#27634)

Browse Source
This commit is contained in:
Ferhat 2021-07-23 10:30:56 -07:00 committed by GitHub
parent e6a0373940
commit 270665edf7
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/lib/web_ui/test/html/canvas_context_golden_test.dart
View File

@ -36,7 +36,7 @@ void testMain() async {
sceneElement.append(engineCanvas.rootElement);
html.document.body!.append(sceneElement);
// TODO(yjbanov): 10% diff rate is excessive. Update goldens.
await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 10);
await matchGoldenFile('$fileName.png', region: region);
} finally {
// The page is reused across tests, so remove the element after taking the
// Scuba screenshot.

10
engine/src/flutter/lib/web_ui/test/html/compositing/backdrop_filter_golden_test.dart
View File

@ -59,8 +59,7 @@ void testMain() async {
.build()
.webOnlyRootElement!);
await matchGoldenFile('backdrop_filter_clip.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_clip.png', region: region);
});
test('Background should only blur at ancestor clip boundary after move', () async {
@ -110,8 +109,7 @@ void testMain() async {
.build()
.webOnlyRootElement!);
await matchGoldenFile('backdrop_filter_clip_moved.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_clip_moved.png', region: region);
});
// The blur filter should be applied to the background inside the clip even
@ -142,8 +140,8 @@ void testMain() async {
.build()
.webOnlyRootElement!);
await matchGoldenFile('backdrop_filter_no_child_rendering.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_no_child_rendering.png',
region: region);
});
}