From 270665edf7a96db6e117ee6fe41206e8d3ed34ca Mon Sep 17 00:00:00 2001 From: Ferhat Date: Fri, 23 Jul 2021 10:30:56 -0700 Subject: [PATCH] remove maxdiff for backdrop_filter_clip_moved (flutter/engine#27634) --- .../web_ui/test/html/canvas_context_golden_test.dart | 2 +- .../html/compositing/backdrop_filter_golden_test.dart | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/engine/src/flutter/lib/web_ui/test/html/canvas_context_golden_test.dart b/engine/src/flutter/lib/web_ui/test/html/canvas_context_golden_test.dart index 395d546eed1..eb877572b67 100644 --- a/engine/src/flutter/lib/web_ui/test/html/canvas_context_golden_test.dart +++ b/engine/src/flutter/lib/web_ui/test/html/canvas_context_golden_test.dart @@ -36,7 +36,7 @@ void testMain() async { sceneElement.append(engineCanvas.rootElement); html.document.body!.append(sceneElement); // TODO(yjbanov): 10% diff rate is excessive. Update goldens. - await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 10); + await matchGoldenFile('$fileName.png', region: region); } finally { // The page is reused across tests, so remove the element after taking the // Scuba screenshot. diff --git a/engine/src/flutter/lib/web_ui/test/html/compositing/backdrop_filter_golden_test.dart b/engine/src/flutter/lib/web_ui/test/html/compositing/backdrop_filter_golden_test.dart index 9b6278f6c86..54d58bfea77 100644 --- a/engine/src/flutter/lib/web_ui/test/html/compositing/backdrop_filter_golden_test.dart +++ b/engine/src/flutter/lib/web_ui/test/html/compositing/backdrop_filter_golden_test.dart @@ -59,8 +59,7 @@ void testMain() async { .build() .webOnlyRootElement!); - await matchGoldenFile('backdrop_filter_clip.png', region: region, - maxDiffRatePercent: 0.8); + await matchGoldenFile('backdrop_filter_clip.png', region: region); }); test('Background should only blur at ancestor clip boundary after move', () async { @@ -110,8 +109,7 @@ void testMain() async { .build() .webOnlyRootElement!); - await matchGoldenFile('backdrop_filter_clip_moved.png', region: region, - maxDiffRatePercent: 0.8); + await matchGoldenFile('backdrop_filter_clip_moved.png', region: region); }); // The blur filter should be applied to the background inside the clip even @@ -142,8 +140,8 @@ void testMain() async { .build() .webOnlyRootElement!); - await matchGoldenFile('backdrop_filter_no_child_rendering.png', region: region, - maxDiffRatePercent: 0.8); + await matchGoldenFile('backdrop_filter_no_child_rendering.png', + region: region); }); }