Georges-Antoine Assi
4928041593
manual cleanu
2026-04-12 11:04:12 -04:00
Georges-Antoine Assi
f107dc2752
changes from bot rview
2026-03-22 17:17:14 -04:00
Georges-Antoine Assi
4c97eddfc3
fix trunk check
2026-03-22 16:30:14 -04:00
nendo
4edb1710a5
fix: address review feedback on session handler and counter
...
- Restore NoResultFound behavior on update_session, complete_session,
fail_session when row is missing (scalar returns None, old .one()
raised -- silent None is a semantic regression)
- Remove redundant get_session call from _increment_session_counter;
the atomic SQL increment is already a no-op on missing rows
- Log warning when passed session_id is not found in _sync_device
instead of silently creating an orphan session
2026-03-16 10:59:49 +09:00
nendo
55638d15dc
fix: address bugs, security issues, and convention violations in save-sync
...
- Fix broken path construction in FSSyncHandler: build_* methods now
return relative paths; sync_watcher uses paths relative to sync base
instead of CWD (was completely non-functional in production)
- Fix SSH connection leak in push-pull task: conn.close() now in finally
- Add log.warning for disabled SSH host key verification
- Fix race condition in session operation counter: use atomic SQL
increment instead of read-then-write
- Extract _increment_session_counter helper, add exc_info to warnings
- Replace legacy session.query() with select() in sync_sessions_handler
- Fix orphaned session: trigger_push_pull now passes session_id to job
- Fix wasteful SSH download when no matched_save exists
- Fix BaseModel import collision in sync.py (pydantic -> project base)
- Fix ORM mutation in UserSchema.from_orm_with_request: set field on
schema instance instead of mutating live ORM object
- Mask ssh_password and ssh_key_path in DeviceSchema API response
- Fix migration PostgreSQL compatibility: condition ON UPDATE clause
on MySQL, drop enum in downgrade
- Rename copy-paste artifact rom_user_status_enum
2026-03-16 10:56:43 +09:00
Georges-Antoine Assi
f13f929d7d
tweaks based on self review
2026-03-14 22:26:53 -04:00
Georges-Antoine Assi
e6ddc5da11
bot attempt at save sync
2026-03-14 22:13:38 -04:00
Georges-Antoine Assi
7146081d75
dont update user set statutuses
2026-03-12 20:26:30 -04:00
Georges-Antoine Assi
72e884a83c
run fmt
2026-03-12 19:02:24 -04:00
copilot-swe-agent[bot]
4234ca3953
fix: always update rom_user status from RA award on each sync run
...
Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
2026-03-12 22:59:47 +00:00
copilot-swe-agent[bot]
da30e4daf1
feat: auto-update game status from RetroAchievements award kind
...
Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
2026-03-11 02:27:38 +00:00
Georges-Antoine Assi
8f8ef1f700
some changes from review
2026-03-10 16:13:21 -04:00
copilot-swe-agent[bot]
f938e627b4
Move cleanup-all missing ROMs to background task to prevent browser hang
...
Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
2026-03-10 02:25:58 +00:00
Georges-Antoine Assi
0c1ea31856
retrun still
2026-03-09 22:06:29 -04:00
copilot-swe-agent[bot]
5e1a4bf35e
Fix: automatic library scan blocked when no metadata sources configured
...
Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
2026-03-10 01:56:47 +00:00
Georges-Antoine Assi
eda88b70d1
get claude to refactor launchbox_handler
2026-03-07 16:02:39 -05:00
Georges-Antoine Assi
395b857592
changes from self review
2026-03-07 14:44:02 -05:00
Georges-Antoine Assi
6de46eb067
Merge branch 'master' into launchbox-handler
2026-03-07 11:31:03 -05:00
Georges-Antoine Assi
ee8b55e6ef
last set of changes
2026-03-07 09:56:17 -05:00
Georges-Antoine Assi
7c2c964c32
fix check issues
2026-01-28 16:05:19 -05:00
Georges-Antoine Assi
2a1583e504
Merge branch 'master' into launchbox-handler
2026-01-28 15:01:01 -05:00
Gravel Freeman
732cc2a530
add support for importing metadata from a local launchbox installation
2026-01-19 13:12:27 -05:00
Georges-Antoine Assi
3d7a9c2d1d
Merge pull request #2885 from rommapp/hotfix-multi-task-schedule
...
[HOTFIX] Dont schedule tasks if already queued
2026-01-10 09:40:35 -05:00
Georges-Antoine Assi
743bddcb23
add valkey to pytest ci
2026-01-10 09:22:46 -05:00
Georges-Antoine Assi
a1fafdc081
only run netplay cleanup every 30 minutes
2026-01-09 18:10:04 -05:00
Georges-Antoine Assi
38ce9897d4
[HOTFIX] Dont schedule tasks if already queued
2026-01-09 17:55:16 -05:00
zurdi
ab637203ac
Merge branch 'master' into feat/rom-filter-multivalue
2025-12-24 12:39:45 +00:00
Victor R. Santos
e131df3c74
Allow Launchbox case-insensitive rom search
2025-12-22 15:42:23 -03:00
zurdi
33b2f643ee
Change scan type to QUICK for scheduled library scans
2025-12-17 15:01:04 +00:00
Georges-Antoine Assi
1812b1a3f9
changes from bot reivew
2025-12-07 12:19:13 -05:00
Georges-Antoine Assi
09dbb2e244
use redis to store netplay data
2025-12-07 12:02:35 -05:00
zurdi
c1d43f67f8
Refactor ROM retrieval to support multi-value platform filtering across various handlers and endpoints
2025-11-27 22:52:33 +00:00
Georges-Antoine Assi
b2dea510c4
[ROMM-2628] Fix desirialize job func_name
2025-11-10 17:57:28 -05:00
Georges-Antoine Assi
525bffe9d0
clarify orphan cleanup task
2025-10-30 10:51:42 -04:00
Georges-Antoine Assi
f30f0bfd75
Smarter detection of whether to scan roms
2025-10-26 13:21:56 -04:00
Georges-Antoine Assi
9fa15d20f0
totally refactor scan types
2025-10-23 16:57:40 -04:00
Georges-Antoine Assi
9a8899f678
use explicit kwargs on scan
2025-10-19 12:43:03 -04:00
Georges-Antoine Assi
b689e3bde1
[ROMM-2531] Allow scanning without metadata providers
2025-10-19 12:37:18 -04:00
Georges-Antoine Assi
2763db5d30
add region and lang validation
2025-10-17 09:03:33 -04:00
Georges-Antoine Assi
945c1a6572
last bit of cleanup
2025-10-16 17:40:44 -04:00
Georges-Antoine Assi
05c5d79e5f
commit backen code
2025-10-16 15:41:42 -04:00
Georges-Antoine Assi
170b3d04b7
self cleanup from review
2025-10-16 15:17:14 -04:00
Georges-Antoine Assi
0f6cf7649f
final tweaks to styles
2025-10-16 12:25:05 -04:00
Georges-Antoine Assi
cdd856f865
use date-fns for dates
2025-10-16 09:11:11 -04:00
Georges-Antoine Assi
6785be06a9
cleanup code massively
2025-10-15 16:21:17 -04:00
Georges-Antoine Assi
e336fc3c5e
restyle by bo
2025-10-15 10:59:02 -04:00
Georges-Antoine Assi
ff15cfcee6
support states for more types of tasks
2025-10-09 19:20:19 -04:00
Georges-Antoine Assi
6f3be07707
Revert "[HOTFIX] Limit memory usage of launchbox metadata update"
2025-09-16 20:55:06 -04:00
Georges-Antoine Assi
f4cf637969
Merge pull request #2437 from rommapp/how-long-to-beat
...
HowLongToBeat Integration
2025-09-16 18:28:48 -04:00
Georges-Antoine Assi
123b3f6b8b
create makeshift howlongtobeet handler
2025-09-14 19:39:38 -04:00
