LAB/kyantech_Palmr
1
0
Fork 0
mirror of https://github.com/kyantech/Palmr.git synced 2026-01-09 06:02:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address code review comments: improve type safety and maintainability

Browse Source 
Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-10 17:33:16 +00:00
parent 1aeeba768f
commit f05d82b192
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
apps/server/src/config/storage.config.ts
View File

@ -1,10 +1,22 @@
import * as fs from "fs";
import process from "node:process";
import { S3Client } from "@aws-sdk/client-s3";
import { S3Client, S3ClientConfig } from "@aws-sdk/client-s3";
import { env } from "../env";
import { StorageConfig } from "../types/storage";
/**
* Standard S3-compatible service domains that support virtual-hosted-style URLs.
* When using these services with forcePathStyle=false, the AWS SDK should
* construct the proper URL from the region, so we should NOT set an explicit endpoint.
*/
const STANDARD_S3_SERVICE_DOMAINS = [
".amazonaws.com",
".wasabisys.com",
".backblazeb2.com",
".digitaloceanspaces.com",
] as const;
/**
* Load internal storage credentials if they exist
* This provides S3-compatible storage automatically when ENABLE_S3=false
@ -151,12 +163,9 @@ export function createPublicS3Client(): S3Client | null {
// Only set endpoint for custom/self-hosted S3 services or when using path-style URLs.
const isStandardS3Service =
!storageConfig.forcePathStyle &&
(storageConfig.endpoint.includes(".amazonaws.com") ||
storageConfig.endpoint.includes(".wasabisys.com") ||
storageConfig.endpoint.includes(".backblazeb2.com") ||
storageConfig.endpoint.includes(".digitaloceanspaces.com"));
STANDARD_S3_SERVICE_DOMAINS.some((domain) => storageConfig.endpoint.includes(domain));
const clientConfig: any = {
const clientConfig: S3ClientConfig = {
region: storageConfig.region,
credentials: {
accessKeyId: storageConfig.accessKey,