From ce045afeecdb9e4103358253bd2dc05d0c3e54fc Mon Sep 17 00:00:00 2001 From: aptalca Date: Sun, 25 Oct 2020 20:46:10 -0400 Subject: [PATCH] minor edits --- README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 27b2e68..71f6ef0 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Again, when pulling in logic from external sources practice caution and trust th We host and publish official Mods at the [linuxserver/mods](https://hub.docker.com/r/linuxserver/mods/tags) endpoint as separate tags. Each tag is in the format of `-` for the latest versions, and `--` for the specific versions. -Here's a list of the official Mods we host: +Here's a list of the official Mods we host: ## Using a Docker Mod @@ -84,7 +84,7 @@ In this repository you will find the `Dockerfile.complex` containing: ```Dockerfile ## Buildstage ## -FROM lsiobase/alpine:3.9 as buildstage +FROM lsiobase/alpine:3.12 as buildstage RUN \ echo "**** install packages ****" && \ @@ -133,12 +133,12 @@ GitHub Actions will trigger a build off of your repo when you commit. The image ## Submitting a PR for a Mod to be added to the official LinuxServer.io repo -* Ask the team to create a new branch named `-` in this repo. Baseimage should be the name of the image the mod will be applied to. The new branch will be based on the [template branch](https://github.com/linuxserver/docker-mods/tree/template). -* Fork the repo, checkout the template branch. +* Fork this repo, checkout the `template` branch. * Edit the `Dockerfile` for the mod. `Dockerfile.complex` is only an example and included for reference; it should be deleted when done. * Inspect the `root` folder contents. Edit, add and remove as necessary. -* Edit this readme with pertinent info, delete these instructions. -* Finally edit the `travis.yml`. Customize the build branch, and the vars for `BASEIMAGE` and `MODNAME`. +* Edit the readme with pertinent info. +* Finally edit the `.github/workflows/BuildImage.yml`. Customize the vars for `BASEIMAGE` and `MODNAME`. +* Ask the team to create a new branch named `-` in this repo. Baseimage should be the name of the image the mod will be applied to. The new branch will be based on the [template branch](https://github.com/linuxserver/docker-mods/tree/template). * Submit PR against the branch created by the team. * Make sure that the commits in the PR are squashed. * Also make sure that the commit and PR titles are in the format of `: `. Detailed description and further info should be provided in the body (ie. `code-server: python2 add python-pip`).