Merge pull request +8808 from c9/fix-sdk

Fix missing node_module error in sdk and add test

configs/standalone.js

@@ -178,7 +178,7 @@ module.exports = function(config, optimist) {
             readonly: readonly
         },
         "./c9.vfs.server/vfs.server",
-        "./c9.error/logger.raygun_mock",
+        "./c9.error/logger.raygun_noop",
         "./c9.preview/preview.handler",
         "./c9.vfs.server/cache",
         "./c9.vfs.server/download",

node_modules/c9/setup_paths.js

@@ -5,13 +5,17 @@
  */
 var modules = require("module");
 var oldResolve = modules._resolveFilename;
-var extraPaths = [
-    __dirname + "/../../"
-];
+var path = require("path")
+var root = path.join(__dirname, "/../..");
+var extraPaths = [ root ];
 modules._resolveFilename = function(request, parent) {
     if (!parent) parent = { paths: [], filename: "" };
     // Ensure client extensions can be loaded
     request = request.replace(/^lib\//, "node_modules/");
+    // ensure we never use node_modules outside of root dir
+    parent.paths = parent.paths.filter(function(p) {
+        return p.indexOf(root) == 0
+    });
     // Add the extra paths
     extraPaths.forEach(function(p) {
         if (parent.paths.indexOf(p) === -1)

plugins/c9.error/logger.raygun_noop.js

@@ -0,0 +1,18 @@
+"use strict";
+
+plugin.consumes = [];
+plugin.provides = ["error.logger"];
+
+module.exports = plugin;
+
+function plugin(options, imports, register) {
+    var noop = function() {};
+    
+    register(null, {
+        "error.logger": {
+            log: noop,
+            error: noop,
+            warn: noop
+        }
+    });
+}