From 087e337202002a6496b08a0f277cf4a426c58c11 Mon Sep 17 00:00:00 2001 From: Lennart Kats Date: Thu, 16 Apr 2015 10:28:30 +0200 Subject: [PATCH 1/2] Improve getServers() logging --- plugins/c9.vfs.client/endpoint.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/c9.vfs.client/endpoint.js b/plugins/c9.vfs.client/endpoint.js index 3bd55ca3..6da0c793 100644 --- a/plugins/c9.vfs.client/endpoint.js +++ b/plugins/c9.vfs.client/endpoint.js @@ -97,7 +97,9 @@ define(function(require, exports, module) { function getVfsEndpoint(version, callback) { getServers(function(err, _servers) { if (err) { - errorHandler.reportError(err); + if (err.code !== "EDISCONNECT") + errorHandler.reportError(new Error("Could not get list of VFS servers"), { cause: err }); + metrics.increment("vfs.failed.connect_getservers", 1, true); initDefaultServers(); _servers = servers; } From 383bd952310f4fdd2b64660bca26c82ea7b47826 Mon Sep 17 00:00:00 2001 From: Lennart Kats Date: Thu, 16 Apr 2015 10:32:22 +0200 Subject: [PATCH 2/2] Add preview failed metric --- plugins/c9.preview/preview.handler.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/c9.preview/preview.handler.js b/plugins/c9.preview/preview.handler.js index c307b04b..2a852a64 100644 --- a/plugins/c9.preview/preview.handler.js +++ b/plugins/c9.preview/preview.handler.js @@ -5,7 +5,8 @@ define(function(require, exports, module) { "connect.render", "connect.render.ejs", "connect.redirect", - "connect.static" + "connect.static", + "metrics" ]; main.provides = ["preview.handler"]; return main; @@ -15,6 +16,7 @@ define(function(require, exports, module) { var https = require("https"); var http = require("http"); var mime = require("mime"); + var metrics = imports.metrics; var parseUrl = require("url").parse; var debug = require("debug")("preview"); @@ -167,6 +169,7 @@ define(function(require, exports, module) { else serveFile(request); }).on("error", function(err) { + metrics.increment("preview.failed.error"); next(err); });