From 5fcf82f3e0302a62caba570edf4904a8ef13736d Mon Sep 17 00:00:00 2001
From: Lennart kats <lennart@c9.io>
Date: Thu, 30 Apr 2015 08:59:41 +0000
Subject: [PATCH 1/3] Add some more error metrics

---
 plugins/c9.ide.dialog.common/alert_internal.js      |  5 ++++-
 plugins/c9.ide.dialog.common/error.js               |  5 ++++-
 plugins/c9.ide.errorhandler/raygun_error_handler.js | 10 ++++++----
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/plugins/c9.ide.dialog.common/alert_internal.js b/plugins/c9.ide.dialog.common/alert_internal.js
index 2b527375..c76edc94 100644
--- a/plugins/c9.ide.dialog.common/alert_internal.js
+++ b/plugins/c9.ide.dialog.common/alert_internal.js
@@ -1,11 +1,12 @@
 define(function(require, module, exports) {
-    main.consumes = ["Dialog", "util", "dialog.alert"];
+    main.consumes = ["Dialog", "util", "dialog.alert", "metrics"];
     main.provides = ["dialog.alert_internal"];
     return main;
     
     function main(options, imports, register) {
         var Dialog = imports.Dialog;
         var util = imports.util;
+        var metrics = imports.metrics;
         var alertWrapper = imports["dialog.alert"];
         
         /***** Initialization *****/
@@ -25,6 +26,8 @@ define(function(require, module, exports) {
         /***** Methods *****/
         
         function show(title, header, msg, onhide, options) {
+            metrics.increment("dialog.error");
+            
             return plugin.queue(function(){
                 if (header === undefined) {
                     plugin.title = "Notice";
diff --git a/plugins/c9.ide.dialog.common/error.js b/plugins/c9.ide.dialog.common/error.js
index 7a6cfde5..4b4142e6 100644
--- a/plugins/c9.ide.dialog.common/error.js
+++ b/plugins/c9.ide.dialog.common/error.js
@@ -1,13 +1,14 @@
 define(function(require, exports, module) {
     "use strict";
 
-    main.consumes = ["Plugin", "ui"];
+    main.consumes = ["Plugin", "ui", "metrics"];
     main.provides = ["dialog.error"];
     return main;
 
     function main(options, imports, register) {
         var Plugin = imports.Plugin;
         var ui = imports.ui;
+        var metrics = imports.metrics;
         
         /***** Initialization *****/
         
@@ -84,6 +85,8 @@ define(function(require, exports, module) {
         }
 
         function show(message, timeout) {
+            metrics.increment("dialog.error");
+            
             // Error message container
             if (!error) {
                 error = document.body.appendChild(document.createElement("div"));
diff --git a/plugins/c9.ide.errorhandler/raygun_error_handler.js b/plugins/c9.ide.errorhandler/raygun_error_handler.js
index 3c3dcca8..82ddc557 100644
--- a/plugins/c9.ide.errorhandler/raygun_error_handler.js
+++ b/plugins/c9.ide.errorhandler/raygun_error_handler.js
@@ -8,7 +8,7 @@ define(function(require, exports, module) {
     "use strict";
 
     main.consumes = [
-        "Plugin", "info"
+        "Plugin", "info", "metrics"
     ];
     main.provides = ["error_handler"];
     return main;
@@ -16,6 +16,7 @@ define(function(require, exports, module) {
     function main(options, imports, register) {
         var Plugin = imports.Plugin;
         var info = imports.info;
+        var metrics = imports.metrics;
 
         /***** Initialization *****/
         
@@ -57,7 +58,8 @@ define(function(require, exports, module) {
             Raygun.setVersion(version + ".0");
         }
         
-        function reportError(exception, customData, tags) {
+        function log(exception, customData, tags) {
+            metrics.increment("errorhandler.log");
             if (typeof exception === "string")
                 exception = new Error(exception);
             if (!exception)
@@ -78,8 +80,8 @@ define(function(require, exports, module) {
         
         plugin.freezePublicAPI({
             /** @deprecated Use log() instead. */
-            reportError: reportError,
-            log: reportError
+            reportError: log,
+            log: log
         });
         
         register(null, { "error_handler" : plugin });

From 02ffdd4e499efab3a164fc5ff0cc592780c4e087 Mon Sep 17 00:00:00 2001
From: Lennart Kats <lclkats@gmail.com>
Date: Thu, 30 Apr 2015 11:25:41 +0200
Subject: [PATCH 2/3] Fix tests

---
 plugins/c9.vfs.standalone/www/test.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plugins/c9.vfs.standalone/www/test.js b/plugins/c9.vfs.standalone/www/test.js
index cce8b53b..20e36d56 100644
--- a/plugins/c9.vfs.standalone/www/test.js
+++ b/plugins/c9.vfs.standalone/www/test.js
@@ -414,6 +414,8 @@ require([
             "metrics": {
                 getLastPing: function() { throw Error("Not implemented"); },
                 getLastest: function() { throw Error("Not implemented"); },
+                log: function() {},
+                increment: function() {}
             },
             error_handler: {reportError: function(){}},
             proc: {

From b4e129dd42eeb53b1866e56beecaf52179e9cfb9 Mon Sep 17 00:00:00 2001
From: Lennart Kats <lclkats@gmail.com>
Date: Thu, 30 Apr 2015 11:42:55 +0200
Subject: [PATCH 3/3] Add mock error.logger

---
 plugins/c9.vfs.standalone/www/test.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/plugins/c9.vfs.standalone/www/test.js b/plugins/c9.vfs.standalone/www/test.js
index 20e36d56..fe20012b 100644
--- a/plugins/c9.vfs.standalone/www/test.js
+++ b/plugins/c9.vfs.standalone/www/test.js
@@ -417,6 +417,9 @@ require([
                 log: function() {},
                 increment: function() {}
             },
+            "error.logger": {
+                log: function() {},
+            },
             error_handler: {reportError: function(){}},
             proc: {
                 execFile: function() {},