LAB-linuxserver/core
1
0
Fork 0
mirror of https://github.com/linuxserver/core.git synced 2026-02-20 05:07:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request +9480 from c9/fix/dont-send-error-stacktraces

Browse Source 
[trivial] Don't send error stacktraces
This commit is contained in:
Tim Robinson 2015-09-18 15:57:54 +02:00
commit 240b0904ab
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/c9.error/error_handler.js
View File

@ -62,6 +62,8 @@ var statusCodes = {
510: "Not Extended",
511: "Network Authentication Required"
};
var NICE_USER_ERROR_MSG = "Something went wrong. Please retry in a few minutes and contact support if it continues to occur";
function plugin(options, imports, register) {
var connect = imports.connect;
@ -104,7 +106,7 @@ function plugin(options, imports, register) {
res.setHeader('Content-Type', 'text/html; charset=utf-8');
res.render(path, {
title: statusCodes[statusCode] || "Unspecified Error",
title: statusCodes[statusCode] || NICE_USER_ERROR_MSG,
scope: options.scope || "",
showStackTrace: showStackTrace,
stack: stack,
@ -120,6 +122,13 @@ function plugin(options, imports, register) {
};
for (var prop in err) error[prop] = err[prop];
try {
JSON.stringify(error);
} catch (e) {
console.error("Cannot send error as JSON: ", error);
error.message = NICE_USER_ERROR_MSG;
error.scope = null;
}
res.json({ error: error }, null, statusCode);
// plain text
} else {