From cb482da4658177b9e472bdcd32b6d7364ba3cd3e Mon Sep 17 00:00:00 2001
From: Alex Phillips <ahp118@gmail.com>
Date: Sat, 5 Mar 2022 07:57:46 -0500
Subject: [PATCH] default memo of transfer transactions to tracking accounts is
 the category, fixed db call from update to insert when updating a transaction
 and accounts change

---
 backend/src/subscribers/TransactionSubscriber.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/backend/src/subscribers/TransactionSubscriber.ts b/backend/src/subscribers/TransactionSubscriber.ts
index 3481165..12a9c42 100644
--- a/backend/src/subscribers/TransactionSubscriber.ts
+++ b/backend/src/subscribers/TransactionSubscriber.ts
@@ -169,6 +169,14 @@ export class TransactionSubscriber implements EntitySubscriberInterface<Transact
 
     const account = await manager.getRepository(Account).findOne(transaction.accountId)
     const payee = await manager.getRepository(Payee).findOne(transaction.payeeId)
+    const transferAccount = await manager.getRepository(Account).findOne(payee.transferAccountId)
+
+    // Set memo to either memo of the original transaction or name of the category it was in
+    let memo = transaction.memo
+    if (!memo && transaction.categoryId && transferAccount.type === AccountTypes.Tracking) {
+      const transactionCategory = await manager.getRepository(Category).findOne(transaction.categoryId)
+      memo = transactionCategory.name
+    }
 
     const transferTransaction = manager.create(Transaction, {
       budgetId: transaction.budgetId,
@@ -179,12 +187,11 @@ export class TransactionSubscriber implements EntitySubscriberInterface<Transact
       amount: transaction.amount * -1,
       date: transaction.date,
       status: TransactionStatus.Pending,
+      memo,
     })
 
     await manager.insert(Transaction, transferTransaction)
 
-    const transferAccount = await manager.getRepository(Account).findOne(transferTransaction.accountId)
-
     transaction.payeeId = transferAccount.transferPayeeId
     transaction.transferAccountId = transferAccount.id
     transaction.transferTransactionId = transferTransaction.id
@@ -323,7 +330,7 @@ export class TransactionSubscriber implements EntitySubscriberInterface<Transact
           date: transaction.date,
           status: TransactionStatus.Pending,
         })
-        await manager.update(Transaction, transferTransaction.id, transferTransaction.getUpdatePayload())
+        await manager.getRepository(Transaction).insert(transferTransaction.getUpdatePayload())
         transaction.transferTransactionId = transferTransaction.id
       }
     }