DEV/microsoft_vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 00:04:14 +08:00
Code Issues Packages Projects Releases Wiki Activity
60,678 Commits 3,582 Branches 356 Tags
Commit Graph

8429 Commits

Author SHA1 Message Date
Jackson Kearl
4e81d10222 Add result count line. Closes #89463. 
And fixup grammar to correctly highlight it
 2020-02-06 16:52:54 -08:00
Matt Bierner
4d35421462 Remove version gating on for now enableProjectDiagnostics 
None of the apis being users for this experimental setting require the latest TS version
 2020-02-06 16:33:05 -08:00
Rachel Macfarlane
cf96b11223 Auth providers - show dialog on token access, closes #89754 2020-02-06 15:30:53 -08:00
Matt Bierner
f0942786b4 Add experimental setting to use separate server to compute project level diagnostics 
For #13953

**Problem**
We'd like to show project wide diagnostics, however at the moment TS server is single threaded. This means that computing all these diagnostics would interrupt other user operations such as completions.

Right now, our advice is to use tasks to get around this limitation (since tasks always run as separate process) however few people actually use tasks.

**Change**
This change adds an experimental `tsserver.experimental.enableProjectDiagnostics` setting (default false) that makes VS Code spawn a separate TS Server that is only used for computing diagnostics. This should help keep the primary syntax server responsive while letting the diagnostics server churn away at project level diagnostics

**Why experimental?**

- We are comporting too many diagnostics. This is bad for larger projects. I don't think TS provides the right APIs to know which files we actually need to request diagnostics on when a file changes.

- This hasn't been fully extensively tested to make sure it plays nicely with feature such as automatic type acquisition or in complex workspace with multiple projects
 2020-02-06 15:15:33 -08:00
Matt Bierner
aca46ac4a5 Take server arguments object 
Makes it more difficult to mistaktenly reverse which server is which
 2020-02-06 15:15:33 -08:00
Matt Bierner
c8516dd7e8 Marking arrays as readonly 2020-02-06 15:15:33 -08:00
Matt Bierner
5d3c86ad99 Remove VS Code project file change watchers 
Updating projects should be handled by the `projectsUpdatedInBackground events` now
 2020-02-06 15:15:33 -08:00
Rachel Macfarlane
b0601cfd46 Add retries to token refresh for network errors of account extension 2020-02-06 14:26:35 -08:00
Rachel Macfarlane
4801814872 Properly reference the vscode.proposed.d.ts typings from the account extension 2020-02-06 10:01:36 -08:00
isidor
5835d42bdf debug intregration tests: use debug.startDebugging 2020-02-06 12:50:33 +01:00
isidor
fd66f569f6 debug: reanable integration tests 2020-02-06 12:47:31 +01:00
Eric Amodio
eaf632c42a Adds uncommitted changes to timeline 2020-02-06 00:04:54 -05:00
Eric Amodio
9cd22d0dc1 Updates list of readonly git commands 2020-02-06 00:02:00 -05:00
Matt Bierner
ae758e681d Fix spelling in test name 2020-02-05 18:12:26 -08:00
Matt Bierner
5347c21ecf Treat any non-whitespace character as jsdoc param names 
Fixes #90108
 2020-02-05 15:26:13 -08:00
Eric Amodio
4cc5b776dc Overhauls timeline display to stream in results 
Implements many API review changes
Fixes #89558
 2020-02-05 18:16:37 -05:00
isidor
a101d32ff6 temporarily disable start debuggin test since it is flaky 2020-02-05 18:15:33 +01:00
isidor
f84d9850e7 debug: fix integration tests 2020-02-05 16:52:07 +01:00
Joao Moreno
dde577b23e
activate git before smoke tests 2020-02-05 15:03:05 +01:00
isidor
c47f30e7c0 debug integration tests: remove flaky part of test that requires window focus 2020-02-05 11:46:01 +01:00
Joao Moreno
7ed9930136
💄 2020-02-05 11:42:33 +01:00
Joao Moreno
ba25c52127
more git smoke test fixes 2020-02-05 10:57:30 +01:00
isidor
1e057b7393 debug integration tests: make sure to focus editor before toggleBreakpoint 
fixes #90047
 2020-02-05 10:49:21 +01:00
Joao Moreno
06dbb1938f
make sure git is activated before integration tests run 2020-02-05 10:24:47 +01:00
Matt Bierner
87b6d03182 Add cursor position check to jsDocCompletionTest 2020-02-04 18:02:38 -08:00
Matt Bierner
2b7e6ab2fd 💄 2020-02-04 18:00:03 -08:00
Matt Bierner
e7451b12ce Adding assertEditorContents helper function and fixing jsdoc completion tests 2020-02-04 17:52:11 -08:00
Matt Bierner
a32cb805a2 Adding some basic tests for auto insert of await on completions 2020-02-04 17:34:12 -08:00
Matt Bierner
58fe34bb77 Don't require strict prefix matches for private field completions 
Fixxes #89556
 2020-02-04 17:17:00 -08:00
Matt Bierner
b4a835f5b9 Fixing backet completion items not shown for cases such as this.xy| 2020-02-04 16:15:58 -08:00
Matt Bierner
7b754d7d95 Adding more pinning tests for JS/TS completions 2020-02-04 16:15:58 -08:00
Matt Bierner
9887559f17 Add basic JS/TS replace/insert completions 
For #87091

Adds basic support for insert/replace mode for JS/TS completions. We're blocked on full support by https://github.com/microsoft/TypeScript/issues/35602. I'll be adding some skipped tests that document current limitations
 2020-02-04 16:15:58 -08:00
Matt Bierner
78465390bd Run many of the JS/TS completion tests in both insert and replace completion mode 2020-02-04 16:15:58 -08:00
Matt Bierner
6205cf0fed Add basic insert mode tests 2020-02-04 16:15:58 -08:00
Matt Bierner
6960e8c07b Fixing TS completion tests 
The current method of verifying when suggestions have been shown is not reliable so switch to use a delay instead :(
 2020-02-04 16:15:58 -08:00
Matt Bierner
5b284c140c Build TS extension against current vscode.d.ts directly 
Currently  extensions like TS have a dev dependency on the `"vscode"` package. This pulls in a copy of `vscode.d.ts` that we end up using instead of our local `vscode.d.ts`.

This change uses the `paths` `tsconig` option so that we use our local `vscode.d.ts` instead of the one from `node_modules`
 2020-02-04 16:15:58 -08:00
Matt Bierner
45999fdb8f Remove extra cast 
Not required with TS 3.8
 2020-02-04 16:15:58 -08:00
Matt Bierner
5623c36a40 Remove surveyor code 
Not currently being used
 2020-02-04 16:15:58 -08:00
Rachel Macfarlane
967aab8156 Add telemetry event for settings sync auth 2020-02-04 15:51:35 -08:00
Martin Aeschlimann
e95476a2c1 JSON validation debounced too much. Fixes #89524 2020-02-04 21:59:30 +01:00
Robo
01989df7c9
chore: update to electron 7 (#89260) 
* Revert "revert back to electron 6 (#89245)"

This reverts commit 5d498736f42841b46b53cda82f23178a3f05070c.

* chore: update electron@7.1.11
 2020-02-04 12:56:23 -08:00
Joao Moreno
d2f9126da3 git tests: windows is pain 2020-02-04 20:54:46 +01:00
Joao Moreno
5f239c7414 Merge branch 'master' of github.com:microsoft/vscode 2020-02-04 20:26:24 +01:00
Joao Moreno
54007fa545 fix git smoketests 2020-02-04 20:26:12 +01:00
Matt Bierner
b1c5e2f19b
Don't include dom typings in extensions (#89942) 
**Problem**
All of our extensions currently are built using the dom typings. This can lead to runtime errors if you mistakenly use `window` or similar

**Fix**
Exclude the dom typings from compile. Then explicitly import the node types for `URL` and `TextEncoder`
 2020-02-04 11:08:22 -08:00
Joao Moreno
16c7551f36
move git smoke tests to integration tests 2020-02-04 17:06:49 +01:00
isidor
491a17bd71 debug integrations tests: better testing of starting of debug 2020-02-04 16:39:26 +01:00
isidor
3900de53e0 debug: introduce intregration tests 2020-02-04 15:43:30 +01:00
Alex Ross
8066726b27 Allow both : an . as time separators in tsc problem pattern 
Fixes https://github.com/microsoft/vscode/issues/89273
 2020-02-04 15:01:09 +01:00
Joao Moreno
19de7a566c
add proper git dev dependencies 2020-02-04 13:04:44 +01:00