3469 Commits

Author SHA1 Message Date
Justin Chen
d05d280364
web reporter refactor and issueFormService (#212951)
* web version working

* change to mainWindow

* PROPER MOVEMENT

* working for web as well

* move issueFormService to workbench/contrib/issue

* cleaning up{

* more cleanup, added setting

* styling

* use mainwindow to open and closee

* css fixes

* fix css again

* fix CSS and wonky applyCSS rules

* change gulpfile

* add and update system info

* address some of the comments

* move files! small changes

* move JS and non window specific back to electron sandbox

* fix on issueReporter.js

* fix build file

* fix gulp file too....

* move everything into contrib

* fix workbench import

* move everything else into contrib, fix import

* change name to web

* applying more feedback fixes :D

* fix command and remove unused import:

* add back issueTroubleshoot

* fix gulpile outputs

* fix out exclusion:
2024-05-24 11:36:46 -07:00
Logan Ramos
cd93de1b0c
Rename vsDeviceId (#213261) 2024-05-22 23:13:13 +02:00
Logan Ramos
4ebc77f80a
Add VS device id (#213231) 2024-05-22 09:48:44 -07:00
Justin Chen
601ea43caf
issue reporter refactor cleanup (#212932)
* remove comments and fix new key usages

* cleanup
2024-05-16 14:56:28 -07:00
Justin Chen
60d035d19a
issue reporter refactor (web prep) (#212762)
* kinda beeeg refactor

* swap the extended issue reporteR

* update PR commentsgit add .!
2024-05-16 11:14:59 -07:00
Benjamin Pasero
6317965640
shared process - show notification toast on crash (fix #212103) (#212799) 2024-05-15 13:10:05 +02:00
Benjamin Pasero
18a5c4d21c
debt - register disposable fs server (#211830) 2024-05-02 09:38:22 +02:00
Justin Chen
bb6fe3b1eb
issue reporter wording/ui fixes (#211654)
first pass at some debt and ui changes
2024-04-29 19:25:22 +02:00
Justin Chen
cd5d6f41f3
fix: copilot external reporting (#209077)
* temp fix

* fix regex, scatter checks throughout

* remove unused check

* nove changes to otther function

* initial check, removing extra parse calls

* regex softening

* regex tightening
2024-04-22 08:11:25 -07:00
Benjamin Pasero
4ee85ac51e
Aux window - registration flawed when devtools is opened (fix #209073) (#209130) 2024-04-08 10:57:01 +02:00
Raymond Zhao
0da22a2260
fix: deprecate unity-launch flag (#209471) 2024-04-04 15:18:19 -07:00
Justin Chen
140f3b2694
removing issue reporter API (#209125)
* first snap

* sent the comments to the shadow realm

* one comment we forgot to remove :(
2024-04-04 04:23:23 -07:00
Connor Peet
7a523c238f
exthost: fix profiling not working (#209142)
* exthost: fix profiling not working

Fixes https://github.com/microsoft/vscode/issues/194678. Requires https://github.com/jrieken/v8-inspect-profiler/pull/3 to be merged and published in order to pass the 'host' down.

* bump package
2024-04-02 18:21:30 +02:00
Benjamin Pasero
1e38af3424
Opening recent from macOS dock creates a duplicate workspace (fix #208321) (#208372) 2024-03-22 08:42:50 +01:00
Justin Chen
adfa191fec
adds limit on issue reporter description (#208346) 2024-03-22 00:51:06 +01:00
Justin Chen
22b6f2fb6c
issue reporter styling fixes (#208340) 2024-03-21 15:15:50 -07:00
Benjamin Christopher Simmonds
ab78ff55f4
Implement Display Protocol Detection (#208212)
display protocol
2024-03-20 17:00:23 +01:00
Benjamin Pasero
1a2bc187d3
debt - reduce some leaking disposables (#207803) 2024-03-15 08:31:41 +01:00
Raphael Palma
c26343fec9
Fix grammatical error: 'But allow them if the are made from inside an…' (#207584)
Fix grammatical error: 'But allow them if the are made from inside an webview'
2024-03-13 17:12:25 +00:00
Justin Chen
d6fb91c889
show contributed issues in quick access (#206303)
* show contributed issues in quick accesss

* moved some files around

* cleanup unused import

* quick access overhaul: add all extensions, filter no duplicates, contributed at bottom, add button to open extension page, add experimental setting

* fix to turn on by default

* switch to info button icon instad

* added issue file on product and marketplace

* differentiate btween insiders and stable

* some fixes for now

* address comments

* review fixes
2024-03-07 14:27:22 -08:00
Benjamin Pasero
544094579b
shared process logging (for #206522) (#206844) 2024-03-04 22:46:40 +01:00
Benjamin Pasero
62b22bbe61
code --install-extension not working with roaming profiles (fix #205924) (#206834) 2024-03-04 12:59:51 -08:00
Justin Chen
313c78eead
fix: added repo name in issue reporter (#206638)
fix repo name in issue reporter
2024-03-01 20:26:12 +01:00
Justin Chen
31a6c35865
add label in issue reporter when custom URI added (#206577)
add label when there is custom uri
2024-03-01 02:05:48 +01:00
Justin Chen
5ca03d67ee
console error when issue reporter fails (#205920)
* throw some console errors here and there

* error checking
2024-02-22 01:18:30 +01:00
BeniBenj
8ec6cec39b
report client OS / DE 2024-02-19 13:52:10 +01:00
Justin Chen
3c1ceb6a1f
issue reporter selection handling, adds extensionId to ipc (#205507)
* fixed IPC handling

* IT ALL WORKS NOW

* fix quotes
2024-02-19 08:50:01 +01:00
Justin Chen
0cbc11c26c
use menu contributions in issue reporter (#205176)
* merge changes to branch

* groundwork for issue command

* removed all the extra random imports

* working flow and rerender/repopulate data

* cleaner working version;'

* cleanup

* ensures that IPC is replied to in both cases

* added data overwrite

* cleanedup

* more cleanup

* cleanup part 2

* comment and make sure to clear uri

* removed unused var

* ensures we don't send ipc early before open reporter call

* removed console logs

* addressing some of the comments

* move is running location

* nicely working version

* removed incorrect package.json location

* re-enables dropdown, switch to extensionidentifier

* removed tokey

* fixes what happens when extensions change mid-await

* use proposed contribIssueReporter

* finally working in all scenarios

* make sure we clear data well enough
2024-02-16 16:19:41 -08:00
Benjamin Pasero
10a596e4d0
voice - suspend keyword recognition when focus lost (#205336)
* speech - bind stop keyword detection to window focus

* .

* .

* .
2024-02-16 10:02:00 +01:00
Benjamin Pasero
4a318a5df9
Aux window: validate window bounds are on display bounds (fix #204346) (#204399) 2024-02-05 20:53:46 +01:00
Justin Chen
fc5c9bef7a
flattens openIssueReporterCommand and debt (#204024)
flatten command, cleanup
2024-02-01 21:32:59 +01:00
Matt Bierner
31fbc3dc94
Remove extra not null assertions (#202201)
* Remove extra not null assertions

With https://github.com/microsoft/TypeScript/pull/56908, TS should better preserve type refinements. To help test this out, I made a quick pass through our code to remove type assertions that are no longer needed

Most of these are not impacted by https://github.com/microsoft/TypeScript/pull/56908 but removing them helps TS test changes like this

Not adding an eslint rule for now as it requires whole program intellisense, which is too slow for commit hooks

* Fix merge
2024-01-30 15:43:09 -08:00
Justin Chen
c95fb565ba
changed issueReporterCommand types and bug fix (#203747)
changed uri from string, word wrap
2024-01-29 18:32:58 -08:00
Benjamin Pasero
7975a45543
No prompt after closing editor when piping command that doesn't terminate (fix #203166) (#203217) 2024-01-23 11:32:24 -08:00
Justin Chen
fc57e0e1d4
issue reporter command enhancements (#203080)
* groundwork for command, only strings for now

* more groundwork for uri

* added uri and clearing suport when switching extensions

* cleanup
2024-01-23 00:40:55 +01:00
Sandeep Somavarapu
4c92920ffe
fix #116191 (#202249) 2024-01-11 15:40:10 +01:00
Matt Bierner
284e949dac
Pick up latest TS for building VS Code (#202047) 2024-01-09 07:48:18 +01:00
samhanic
70dda3c792 Merge branch 'main' into cli-extension-update 2024-01-07 21:24:26 +01:00
Justin Chen
b2809a8d3e
allow issue reporter command to activate API (#201905)
* added groundwork

* removed extra button stuff

* removed commented out code
2024-01-05 12:20:16 -08:00
Benjamin Pasero
c29a6e10b9 aux window - allow a per-window zoom level (#185836) 2023-12-30 01:41:14 +01:00
Benjamin Pasero
8db82d0d32
cli - do not --wait when reading from stdin (#199035) (#200926) 2023-12-15 09:38:02 +01:00
João Moreno
91a4378f47
allow CORS from PRSS CDN (#200554)
fixes microsoft/vscode-remote-release#9246
2023-12-12 12:49:40 +01:00
Connor Peet
d3bedefd42
process-explorer: fix not updating pid/name mapping correctly (#200401)
The mapPidToName was getting reassigned rather than mutated which prevented the ProcessRenderer from seeing the correct names if they got updated.

Fixes #172120
2023-12-08 21:16:12 +01:00
Justin Chen
733d76ddd3
Adopting noDisposablesAreLeakedInTestsSuite for Issue Reporter tests (#200200)
added noDisposablesLeakedinTests
2023-12-06 15:31:01 -08:00
samhanic
74c419b5bd add cli update-extensions prototype 2023-12-03 14:25:40 +01:00
Benjamin Pasero
874468718c
Browsing product icons through command palette shows tofu characters (fix #198687) (#198731) 2023-11-21 06:40:36 +00:00
Ole
b3a649fe52
Remove cycle browserHostService.ts -> web.api.ts. (#198221)
* Remove cycle  browserHostService.ts -> web.api.ts.

Before this change, `IWorkbenchConstructionOptions` in web.api.ts
depended on `IWorkspaceProvider` in browserHostService.ts, which
depends on some types from web.api.ts.

While this apparently does not pose problems in VS Code's build, other
build system of downstream projects do not allow this, and it is also
overall harder to follow the code if "the API" depends on types defined
in ""the implementation".

* Fix one reference I missed
2023-11-15 07:17:50 +00:00
Justin Chen
477962a5b4
Activate extension on Issue Reporter opened (#197616)
* activate extension by ID when having activation event

i was craving chicken tendies.

* Update comments

* code cleanup and review fixes

* added better error logging and catching

* switched to logservice instead of console.error
2023-11-10 17:37:04 +01:00
Johannes Rieken
dff4173df4
Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle. (#197721)
* Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle.

Define window things inside dom.ts for more clarity and more correct layering.

Duplicate API definition for idle so that things compile standalone

fixes https://github.com/microsoft/vscode/issues/197661

* fix compile errors

* make treeshaker happy, use correct types
2023-11-08 15:20:40 +01:00
Benjamin Pasero
c90951b147
aux window - less global document usages (#197701)
* aux window - less global `document` usages

* aux window - less global `document` usages

* aux window - less global `document` usages
2023-11-08 08:39:04 +01:00