23160 Commits

Author SHA1 Message Date
Alex Dima
814be2fd75 Fixes #39266: Don't run diff for computing edits in case of model update 2018-02-26 23:45:26 +01:00
Rachel Macfarlane
efc74018f2 I18n issue in the issue reporter, fixes #44203 2018-02-26 14:22:31 -08:00
Daniel Imms
174b9ad957 Adopt log service in terminal
Fixes #44442
2018-02-26 13:48:22 -08:00
Alex Dima
74b681b08a Avoid view model inconsistency 2018-02-26 22:12:18 +01:00
Alex Dima
5133a79e40 Avoid NPE 2018-02-26 22:12:18 +01:00
Peng Lyu
20b5c3a9b5 Fix microsoft/monaco-editor#610. avoid bootstrap collision with custom-checkbox. 2018-02-26 12:56:54 -08:00
Matt Bierner
26cbbea694 Add webview.show method to show a webview in a given group
Fixes #44430
2018-02-26 12:56:23 -08:00
Matt Bierner
e6105ab277 Add a way to 'pin' a markdown preview
Fixes #44429
2018-02-26 12:56:22 -08:00
Alex Dima
20ed3d9632 Fixes #44424: Add proposed API - TextEditor.visibleRanges 2018-02-26 21:28:09 +01:00
Daniel Imms
842780dd3c Make terminal outer margins 20px
Fixes #44154
2018-02-26 11:35:20 -08:00
Matt Bierner
2038b8fc7f
Webview API prototype 3 (#44307)
* Webview API prototype 3

Part of #43713

Third try at refining the webview api. This pass reworks  #44165.  Major changes:

- Adds an `id` field to webviews. The id is provided by the extension and identifies the webview. It is used with the new event handling apis.

- Adds a new `onDidChangeActiveEditor` api. This is similar to `onDidChangeActiveTextEditor` but is also fired when you change webviews. It replaces the old `onFocus` and `onBlur` events on the webview itself

- Adds an `onDispose` event ot webviews. This is fired when a webview is closed by the user

- Perist webview state when the editor group changes. This is enabled for all webviews, not just those with keep alive.

* Throw error when trying to access disposed webview

* Improving webview documentation

* Clean up dispose management

* Throw if we receive a bad handle

* Move more event handling to input

* Simplify input updating

* Remove extra container property

* Fixing md security alert button

* Remove extra update container call

* Restore syncing of preview to active editor

* Fixing posting to webview

* Debounce preview updates

* Remove previewUri

* Enable direct window.postMessage instead of window.parent.postMessage

* Fixing scroll position not preserved when updating previews

* Revert parent.postMessage change.

Old behavior was correct

* Properly hide webview container on tab switch

* Make sure we only handle scroll events for the correct document

* Don't try setting negative scroll

* Revert vs code whitespace change
2018-02-26 10:06:50 -08:00
Benjamin Pasero
de87042d3c notifications 💄 2018-02-26 18:20:22 +01:00
Benjamin Pasero
442903cb39 notifications - more commands 2018-02-26 18:11:55 +01:00
Johannes Rieken
43fbb43773
Merge pull request #42914 from Connormiha/optimize-context-key-change-event
Remove needless check for array in ContextKeyChangeEvent
2018-02-26 17:27:25 +01:00
Johannes Rieken
4dd25bb31e fix #42991 2018-02-26 17:14:58 +01:00
isidor
8f9fdee654 better instanceof check
fixes #43877
2018-02-26 16:56:14 +01:00
Benjamin Pasero
1e36fa88c6 notifications - avoid column-reverse for toasts 2018-02-26 16:54:21 +01:00
isidor
70358c4098 terminal: open split terminal with alt/ctrl click
fixes #43877
2018-02-26 16:52:09 +01:00
Alex Dima
6aadb1ad40 Send text editor properties updates in a single event 2018-02-26 16:51:57 +01:00
Alex Dima
ad63cf5a12 TextEditor.document is readonly 2018-02-26 16:51:57 +01:00
Rachel Macfarlane
f7e083097c Issue reporter mark down polish, fixes #44405 2018-02-26 07:50:10 -08:00
Benjamin Pasero
ff8d9dc567 notifications - prevent layout on hidden toasts 2018-02-26 16:43:23 +01:00
Sandeep Somavarapu
e41f52b4b7 Fix #43346 2018-02-26 16:41:02 +01:00
Sandeep Somavarapu
34a73521da #43978 Generate read me from extension name and description 2018-02-26 16:26:41 +01:00
isidor
a90be3e1ab breakpoint icons (include function breakpoint icons)
fixes #43763
2018-02-26 16:11:44 +01:00
Sandeep Somavarapu
39265a74ff Fix #43521 2018-02-26 15:13:04 +01:00
Sandeep Somavarapu
7b99b15c26 💄 documentation 2018-02-26 15:07:08 +01:00
Benjamin Pasero
5c0716bfe2 notifications - fix broken height compute 2018-02-26 15:00:09 +01:00
Sandeep Somavarapu
e561db9c84 #43216 Set icon from theme when just theme icon is provided 2018-02-26 14:59:47 +01:00
isidor
872de2a131 debug launch: if there is only 1 folder take that one for resolving 2018-02-26 14:56:10 +01:00
Alex Dima
c0db838ed5 Fixes #44360: Only warn ctrl+alt+ for core keybindings (not for extensions) 2018-02-26 13:54:29 +01:00
Martin Aeschlimann
3a79bc5bdd Improve ThemeIcon documentation. For #43216 2018-02-26 13:11:49 +01:00
Benjamin Pasero
a23edada50 debt - avoid deprecated Buffer ctors 2018-02-26 13:09:54 +01:00
Alex Dima
0c1cb4571f Warn only if grammar paths are different 2018-02-26 13:08:56 +01:00
Alex Dima
f8cc441e21 Fixes #29033 2018-02-26 13:05:59 +01:00
isidor
a89383b3ad debug user launch: resolve variables against a folder if you are in a folder vscode 2018-02-26 12:39:52 +01:00
Christof Marti
6cacaef5a8 Open Welcome page as a preview editor (fixes #32416) 2018-02-26 12:36:13 +01:00
isidor
be9d877269 Breakpoint tooltip polish
fixes #44407
2018-02-26 12:24:26 +01:00
Isidor Nikolic
28f33734e8
Merge pull request #44362 from ntovas/feature/KeepExpandingStatus
Keep item expanded after rename
2018-02-26 11:57:12 +01:00
Sandeep Somavarapu
dffab45f20 #43216 Fix folder and file type computation 2018-02-26 11:50:17 +01:00
Christof Marti
3de4e2f515 Log use of file search (fixes #43605) 2018-02-26 11:49:50 +01:00
Sandeep Somavarapu
1fe73ac78c 💄 #43216 2018-02-26 11:36:32 +01:00
Sandeep Somavarapu
7605653d73 Improve documentation #43216 2018-02-26 11:09:14 +01:00
Matt Bierner
5122e83f63 Disallow drag splitting of non-splittable editors (#44308)
**Problem**
Editors use the `supportsSplitEditor` property to enable/disable splitting. Even if splitting is disabled, you can still split an editor by dragging it to create a new copy.

**Fix**
For non-splittable editors, make dragging always just move the editor to a new group
2018-02-26 11:01:40 +01:00
Benjamin Pasero
8015c58d78 follow up change from PR 44269 to preserve command IDs 2018-02-26 10:54:32 +01:00
Itamar
3f6df1e78d Renaming Close Unmodified to Close Unsaved (#44269)
* Renaming Close Unmodified to Close Unsaved
https://github.com/Microsoft/vscode/issues/44033

* Putting back action identifiers
2018-02-26 10:53:30 +01:00
Joao Moreno
d0ebe4ed8c fix bad ctor 2018-02-26 10:53:04 +01:00
Sandeep Somavarapu
d2470e2edf
Merge pull request #43261 from vbfox/file_as_folder_in_custom_tree
Allow extensions to specify custom tree view resoure type
2018-02-26 10:45:56 +01:00
Benjamin Pasero
739dac65c5 notifications - tweak some or convert to modal dialog 2018-02-26 07:51:06 +01:00
Benjamin Pasero
a45abaa933 fix #44301 2018-02-26 07:51:06 +01:00