12877 Commits

Author SHA1 Message Date
Johannes Rieken
c1b80f6402
Disable merge-conflict commands for 3wm-editor (#161304)
fixes https://github.com/microsoft/vscode/issues/159156
2022-09-20 13:50:21 +02:00
Rob Lourens
0e333cd799
Convert NotebookCellStatusBarItem test from integration test to unit test (#161274)
Fix #157828
2022-09-20 09:55:58 +02:00
Sandeep Somavarapu
35c7ee9d02
Support log output channels for extensions (#161249)
* introduce log api in extension context

* separate registering output vs log channel

* Separate extension log channels in show logs command

* add logging error to embedder logger

* show extension log in the extension editor

* configure log level per extension

* change the order of log entries

* introduce logger

* align with output chanel

* revert changes

* fixes
2022-09-19 09:03:41 -07:00
Matt Bierner
d03f015931
Clean up structure of markdown extension (#161148)
- Move things related to the client under `client`
- Remove extra abstractions that are no longer used
- Add MdLanguageClient type
2022-09-19 07:16:45 +02:00
Matt Bierner
f4bf1f30a2
Skip ul and ol when highlighting selected markdown element (#161139)
Fixes #155552

For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line

This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
Matt Bierner
a10bdfb49b
Allow underscores in rendered md headers (#161149)
Follow up from https://github.com/microsoft/vscode-markdown-languageservice/pull/49
2022-09-16 20:52:50 -04:00
Matt Bierner
4c9c3f628d
Pick up latest markdown language service (#161142) 2022-09-16 20:52:16 -04:00
Peng Lyu
6e8bc02be4
Cell attachment cleanup tool improvement in diff editor (#161132)
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Matt Bierner
7c3ea7ac06
Pick up TS 4.8.3 (#161126)
Picks up latest TS stable build
2022-09-16 10:22:13 -07:00
Martin Aeschlimann
724a088c68
update vscode-uri, fix links in untited (fixes #147788) (#161108) 2022-09-16 07:57:10 -07:00
Johannes Rieken
21a2eca3b7
The openMergeEditor command should check the active tab when it is called without an URI (#161072)
https://github.com/microsoft/vscode/issues/160924
2022-09-16 11:55:06 +02:00
Johannes Rieken
77309b33d4
add WorkspaceEditMetadata and use it for applyEdit, (#160996)
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
2022-09-16 09:44:19 +02:00
Benjamin Pasero
ec56dddd9f
tests - remove snippetWorkspaceEdit usage (#161043) 2022-09-16 00:34:30 -07:00
Matt Bierner
3c37a5a8d7
Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc01197555cb14a0d2d3463b331ce41de5733be.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Daniel Rosenwasser
9dfd49db63
Ensure ExperimentationService gets disposed. (#161004) 2022-09-15 11:06:53 -07:00
Peng Lyu
0f05c6dd4f
Fix #160729. Disable workspace md paste handler for notebook. (#160833)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-15 09:48:21 -07:00
Joyce Er
6835a98d4a
Fix branch checkout after git clone (#160922)
* Fix branch checkout after git clone

* Add progress notification while checking out ref

* Remove promise chain
2022-09-15 18:11:29 +02:00
Ladislau Szomoru
e1c7285ab5
Git - Add the ability to fetch a branch before it is checked out (#160181) 2022-09-15 16:04:37 +02:00
Ladislau Szomoru
fd2b0d888f
Git - Do not override SSH_ASKPASS for the terminal (#160935)
Do not override SSH_ASKPASS for the terminal
2022-09-15 13:48:05 +02:00
Matt Bierner
03ada8a3e8
Rework how markdown server works with documents (#160948)
* Rework how markdown server works with documents

This rewrites how the markdown server works with documents. The goal is to better handle switching between in-memory versions of a doc (from `TextDocument`) and versions of the same doc on disk. From the markdown service's POV, there is only one type of document

As part of this, I've also adopted the newest markdown language service version

* Bump package-lock versions
2022-09-15 09:27:02 +02:00
Benjamin Pasero
cfc0119755
Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab485cc7a16ca918728e600e41dbb29b.
2022-09-15 08:26:22 +02:00
Don Jayamanne
c6698eaced
Pass element to the JS preEvaluate renderer hook (#160851) 2022-09-14 17:21:48 -07:00
Tyler James Leonhardt
ccddb94f98
initial cut of vscode.l10n (#158328) 2022-09-14 16:48:25 -07:00
Rob Lourens
c717237d7c
Reenable a couple notebook smoketests (#159521)
* Remove vscode-notebook-tests in favor of an .ipynb in vscode-smoketest-express

* Update build folder

* Add build task to correct platform

* Build for smoke tests on other platforms

* Fix repo url and remove comment

* Just -media?

* Update darwin/win32 as well
2022-09-14 13:22:16 -07:00
Isidor Nikolic
65cbb9324b
change git.mergeEditor setting to be false (#160923) 2022-09-14 11:41:41 -07:00
Ladislau Szomoru
e97b478d06
Commit dropdown button uses text-overflow (#160834) 2022-09-14 20:40:06 +02:00
Tyler James Leonhardt
fc1ef74eb0
GHES oauth flow support (#160679)
* GHES oauth flow support

* update server number

* delete testing line
2022-09-14 11:26:02 -07:00
Joyce Er
51ab74bc88
Don't register git protocol handler till after git commands are registered (#160857) 2022-09-14 19:23:38 +02:00
Ladislau Szomoru
3dc9b8a26c
GitHub - Tweak working of the GitHub publishing welcome view (#160916)
Tweak working of the GitHub publishing welcome view
2022-09-14 10:02:43 -07:00
Daniel Rosenwasser
0cbcb1b1ab
JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
Rob Lourens
37f08d1195
Remove notebookEditorEdit proposal requirement (#160912) 2022-09-14 09:41:21 -07:00
Daniel Rosenwasser
00902daee1
Instantiate ExperimentationService in typescript-language-features. (#160877)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:34:04 -07:00
Matt Bierner
fa1fee3b21
Pick up latest Markdown language service (#160831) 2022-09-14 09:20:52 -07:00
Matt Bierner
2cf7468289
Fix markdown server deleting documents on close if they still exist on disk (#160859) 2022-09-14 09:16:39 -07:00
Daniel Imms
a4cce8f575
Merge pull request #160900 from babakks/add-change-shell-event
Add `onDidChangeShell` event to the API
2022-09-14 07:53:50 -07:00
Daniel Imms
c4611298a3
Add envShellEvent to vscode-api-tests 2022-09-14 07:32:41 -07:00
Ladislau Szomoru
60fa7bc579
Git - Improve git fetch command for repositories with multiple remotes (#159644)
* Improve git fetch command for repositories with multiple remotes

* Refactored and cleaned up the implementation

* Pull request feedback
2022-09-14 11:06:27 +02:00
Martin Aeschlimann
5431050e5f
Use Uri.Utils (#160780)
* Use Uri.Utils

* handle base as folder
2022-09-13 17:46:01 +02:00
Michael Chirico
77dd5f36d5
Better paired operators for R (#155882)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-09-13 09:37:21 +02:00
Don Jayamanne
4230c22a08
Compress notebook output streams before rendering (#160667)
* Compress notebook output streams before rendering

* OOps

* Combine the buffers manually

* Address code review

* oops

* Fixes

* We can have multiple stream mimes in an output

* oops
2022-09-13 08:56:32 +10:00
Matt Bierner
1d500fb4de
Add CodeActionKind.RefactorMove (#160730)
Fixes #160728
2022-09-12 15:14:06 -07:00
Matt Bierner
2514759850
Remove notebook content provider save and backup functionality (#160581)
For #147248

When stepping through the liveshare code, we figured out they do not appear to be using `save`, `saveAs`, or `backup` (they return empty results for these)

This PR removes this part of the proposal so we can track just the parts of the api that they are using
2022-09-12 14:08:25 -07:00
Matt Bierner
3729f509b5
Support creating image in workspace when pasting image data into markdown (#160554)
For #157043
2022-09-10 08:56:18 -07:00
Ladislau Szomoru
d2c241ffc0
Git - Disable git.init command, and a welcome view that uses the git.init command in codespaces (#160597)
Disable git.init command, and a welcome view that uses the git.init command in codespaces
2022-09-10 10:38:41 +02:00
Michael Lively
42238bdaab
notebook image cleaning automation (#159212)
* cache and cleaner complete, needs debounce

* minor renaming and reformatting

* bugfix for paste into new cell

* cleaning functionality complete

* refer to metadata as copy of current cell's

* check undef before reading from cache

* working state, pending cache restructure

* dots -> brackets

* pre-class refactor

* massive cleaner refactor

* cache typing, closed nb check, workspaceEdit only if metadata is changed

* undefined access fix

* proper debouncer

* get it up to work again

* no need to loop

* cell metadata uri parsing regression

* diagnostic

* Show diagnostics on document open

* transfer cache before file renames

* disable word wrap in notebook diff editor

* Avoid early notebook cell metadata deep clone

* No special case empty cell

* rename

* better naming

* Quick fix for invalid image attachment

* cleanup

* Add code action metadata

Co-authored-by: rebornix <penn.lv@gmail.com>
2022-09-09 11:32:10 -07:00
Ladislau Szomoru
df51f5af27
GitHub - Disable command & view in codespaces (#160546)
Disable command & view in codespaces
2022-09-09 11:22:39 -07:00
Benjamin Simmonds
8268e5d27d
Remove enabledApiProposals badge from test ext (#160526) 2022-09-09 15:36:53 +02:00
Ladislau Szomoru
52223728f8
Git - Add the ability to commit and not execute a post-commit command (#160527)
Add the ability to commit and not execute a post-commit command
2022-09-09 14:58:38 +02:00
Matt Bierner
ded9a310a4
Add webm/VP8 support to video viewer (#160459)
Add VP8 support to video viewer
2022-09-08 17:28:24 -07:00
Matt Bierner
d7d18aa0da
Clean up video styling (#160461) 2022-09-08 17:28:14 -07:00