mirror of
https://github.com/material-components/material-components-ios.git
synced 2026-02-20 08:27:32 +08:00
9d4c218a0a
[Chips] Ensure MDCChipField notifies delegate when clear button is tapped Previously, `MDCChipField` failed to notify its delegate when the clear button was tapped. This was because `-[MDCTextInputCommonFundament clearButtonDidTouch]` called `-setText:` directly on the text field to clear the text, but `MDCChipField` only notified its delegate of a text change when it received `UIControlEventEditingChanged` (which does not happen in this case). To fix this, I changed `MDCChipField` to listen to `UITextFieldTextDidChangeNotification` (posted when the text field is the first responder) as well as `MDCTextFieldTextDidSetTextNotification` (posted when the text field is not the first responder). Test Plan: New test added. Ran tests with: `./.kokoro --target //components/Chips/...`
133 lines
3.2 KiB
Python
133 lines
3.2 KiB
Python
# Copyright 2017-present The Material Components for iOS Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
load("//:material_components_ios.bzl",
|
|
"mdc_public_objc_library",
|
|
"mdc_objc_library",
|
|
"mdc_unit_test_suite")
|
|
load("@build_bazel_rules_apple//apple:swift.bzl", "swift_library")
|
|
|
|
licenses(["notice"]) # Apache 2.0
|
|
|
|
mdc_objc_library(
|
|
name = "private",
|
|
hdrs = native.glob(["src/private/*.h"]),
|
|
includes = ["src/private"],
|
|
visibility = [":test_targets"],
|
|
)
|
|
|
|
package_group(
|
|
name = "test_targets",
|
|
packages = [
|
|
"//components/Chips/...",
|
|
"//components/TextFields/...",
|
|
]
|
|
)
|
|
|
|
mdc_public_objc_library(
|
|
name = "TextFields",
|
|
sdk_frameworks = [
|
|
"QuartzCore",
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
"//components/AnimationTiming",
|
|
"//components/private/Math",
|
|
"//components/Palettes",
|
|
"//components/Typography"
|
|
],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "ColorThemer",
|
|
srcs = native.glob(["src/ColorThemer/*.m"]),
|
|
hdrs = native.glob(["src/ColorThemer/*.h"]),
|
|
includes = ["src/ColorThemer"],
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
":TextFields",
|
|
"//components/Themes",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "FontThemer",
|
|
srcs = native.glob(["src/FontThemer/*.m"]),
|
|
hdrs = native.glob(["src/FontThemer/*.h"]),
|
|
includes = ["src/FontThemer"],
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
":TextFields",
|
|
"//components/Themes",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "TypographyThemer",
|
|
srcs = native.glob(["src/TypographyThemer/*.m"]),
|
|
hdrs = native.glob(["src/TypographyThemer/*.h"]),
|
|
includes = ["src/TypographyThemer"],
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
":TextFields",
|
|
"//components/schemes/Typography",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "unit_test_sources",
|
|
testonly = 1,
|
|
srcs = glob(["tests/unit/*.m"]),
|
|
hdrs = glob(["tests/unit/*.h"]),
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
"XCTest",
|
|
],
|
|
deps = [
|
|
":TextFields",
|
|
":ColorThemer",
|
|
":FontThemer",
|
|
":TypographyThemer",
|
|
],
|
|
visibility = ["//visibility:private"],
|
|
)
|
|
|
|
swift_library(
|
|
name = "unit_test_swift_sources",
|
|
srcs = glob(["tests/unit/*.swift"]),
|
|
deps = [
|
|
":TextFields",
|
|
":ColorThemer",
|
|
"//components/private/Math",
|
|
"//components/Palettes",
|
|
],
|
|
visibility = ["//visibility:private"],
|
|
)
|
|
|
|
mdc_unit_test_suite(
|
|
deps = [
|
|
":unit_test_sources",
|
|
":unit_test_swift_sources",
|
|
],
|
|
)
|