mirror of
https://github.com/material-components/material-components-ios.git
synced 2026-02-20 08:27:32 +08:00
bc6dfc007f
Repro case:
Add the following code to a view controller with an App Bar:
```swift
class SomeObject {
@objc func someEvent() {
}
}
let object = SomeObject()
self.navigationItem.rightBarButtonItem =
UIBarButtonItem(title: "Right", style: .done, target: object, action: #selector(SomeObject.someEvent))
```
Tap the button.
Expected behavior: the someEvent method is invoked.
Actual behavior: crash due to unrecognized selector `methodSignatureForSelector:`.
After this change the behavior works as expected, with the caveat being that we are not able to pass the button instance along as a third argument to pure Swift classes. The implication of this is that pure Swift classes will not be able to present popovers from the provided item instance. Supporting this case will require turning the pure Swift class into an Objective-C compatible class.
Closes https://github.com/material-components/material-components-ios/issues/2981
111 lines
2.7 KiB
Python
111 lines
2.7 KiB
Python
# Copyright 2017-present The Material Components for iOS Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
load("//:material_components_ios.bzl",
|
|
"mdc_public_objc_library",
|
|
"mdc_objc_library",
|
|
"mdc_unit_test_suite")
|
|
load("@build_bazel_rules_apple//apple:swift.bzl", "swift_library")
|
|
|
|
licenses(["notice"]) # Apache 2.0
|
|
|
|
mdc_public_objc_library(
|
|
name = "ButtonBar",
|
|
sdk_frameworks = [
|
|
"QuartzCore",
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
"//components/Buttons",
|
|
"//components/private/Application",
|
|
"@material_internationalization_ios//:MDFInternationalization",
|
|
],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "ColorThemer",
|
|
srcs = native.glob(["src/ColorThemer/*.m"]),
|
|
hdrs = native.glob(["src/ColorThemer/*.h"]),
|
|
includes = ["src/ColorThemer"],
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
":ButtonBar",
|
|
"//components/Themes",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "TypographyThemer",
|
|
srcs = native.glob(["src/TypographyThemer/*.m"]),
|
|
hdrs = native.glob(["src/TypographyThemer/*.h"]),
|
|
includes = ["src/TypographyThemer"],
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
],
|
|
deps = [
|
|
":ButtonBar",
|
|
"//components/schemes/Typography",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "private",
|
|
hdrs = native.glob(["src/private/*.h"]),
|
|
includes = ["src/private"],
|
|
visibility = ["//visibility:private"],
|
|
)
|
|
|
|
mdc_objc_library(
|
|
name = "unit_test_sources",
|
|
testonly = 1,
|
|
srcs = native.glob([
|
|
"tests/unit/*.m",
|
|
"tests/unit/*.h",
|
|
]),
|
|
sdk_frameworks = [
|
|
"UIKit",
|
|
"XCTest",
|
|
],
|
|
deps = [
|
|
":ButtonBar",
|
|
":ColorThemer",
|
|
":private",
|
|
],
|
|
visibility = ["//visibility:private"],
|
|
)
|
|
|
|
swift_library(
|
|
name = "unit_test_swift_sources",
|
|
srcs = native.glob(["tests/unit/*.swift"]),
|
|
deps = [
|
|
":ButtonBar",
|
|
":ColorThemer",
|
|
":TypographyThemer",
|
|
":private",
|
|
],
|
|
visibility = ["//visibility:private"],
|
|
)
|
|
|
|
mdc_unit_test_suite(
|
|
deps = [
|
|
":unit_test_sources",
|
|
":unit_test_swift_sources",
|
|
],
|
|
)
|