2 Commits

Author SHA1 Message Date
Ian Gordon
fc4e0a4827 Fix commonInit method.
Summary:
A friendly reminder.

Assume you've created MDCFooSpinner which subclasses UIView.

- Implement initWithFrame: and initWithCoder:
-- Both should call a common method for shared init
--- To avoid collisions and problems subclassing, this method should be named commonMDCFooSpinnerInit.

Because consistency is the key to all success according to the following book,.... which I have not read, but was high in the Google search results.

https://www.amazon.com/Why-Consistency-Key-All-Success/dp/0943845807/ref=sr_1_2?ie=UTF8&qid=1470942356&sr=8-2&keywords=consistency+key+success

Test Plan: Works as expected on iPhone Sim 6 - iOS 9.

Reviewers: junius, ajsecord, O1 Material components iOS

Reviewed By: ajsecord, O1 Material components iOS

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1458
2016-08-11 18:05:04 -04:00
Adrian Secord
3451061ae4 [Docs] Added contributing/code-conventions.md.
Summary:
Moved appropriate sections of contributing/README.md into code-conventions.md.

Added link from README.md to code-conventions.md.

Reviewers: O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1405
2016-08-05 13:05:41 -07:00