* Fixed MDCPageControl crasher when resetting -numberOfPages to 0. This is supported by UIPageControl.
Crasher details:
Test Case '-[PageControlExampleTests testResetNumberOfPagesToZero]' started.
~/material-components-ios/components/PageControl/tests/unit/PageControlExampleTests.m:139: error: -[PageControlExampleTests testResetNumberOfPagesToZero] : failed: caught "NSRangeException", "*** -[__NSArrayM objectAtIndexedSubscript:]: index 0 beyond bounds for empty array"
(
0 CoreFoundation 0x000000010e3ed03b __exceptionPreprocess + 171
1 libobjc.A.dylib 0x000000010da81f41 objc_exception_throw + 48
2 CoreFoundation 0x000000010e42ce2c _CFThrowFormattedException + 194
3 CoreFoundation 0x000000010e41e714 -[__NSArrayM objectAtIndexedSubscript:] + 148
4 MaterialComponents 0x0000000128271441 -[MDCPageControl resetControl] + 2193
5 MaterialComponents 0x000000012826e489 -[MDCPageControl setNumberOfPages:] + 281
* Also fixed crasher when the client sets a value for -currentPage (e.g. zero) when -numberOfPages is zero.
* Improved the unit test to hit the 2nd crasher prior to the fix
* Cleaner unit test for the crashers per review feedback
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...
Summary:
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.
Changed copyright statement to include non-Google authors.
Command run:
find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Added non-source files.
Command run:
grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Reviewers: featherless, O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1415
Summary: If you set the content offset to larger than range of the page count the Page Control crashes because it tries to index out of bounds of an array.
Reviewers: cjcox, #mdc_ios_owners, featherless
Reviewed By: cjcox, #mdc_ios_owners, featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D671
Summary:
Similar to Catalog by convention, Testing by convention allows us to generate a fully-working unit test suite using CocoaPods wildcards.
The testing convention is to place unit test source files in a `tests/unit` folder within each component.
A complete "component by convention" now looks like so:
component/
examples/
SomeExample.m
src/
...
tests/
unit/
SomeTest.m
This convention makes it trivially easy to run all tests in our project & generate coverage information. Here are our coverage results:
{F439}
Resolves https://github.com/google/material-components-ios/issues/106.
Reviewers: cjcox, ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D158
