9 Commits

Author SHA1 Message Date
Will Larche
1f10ae3e3e
[TextFields] Making leading and trailing view layout customizeable (#4434)
Closes the layout part of b/74174981

***Breaks screenshot tests.

Before:
![simulator screen shot - iphone x - 2018-06-24 at 17 39 27](https://user-images.githubusercontent.com/1271525/41823956-2742affe-77d6-11e8-9082-2ccb10071750.png)

After:
![simulator screen shot - iphone x - 2018-06-24 at 17 35 45](https://user-images.githubusercontent.com/1271525/41823875-13f44152-77d5-11e8-8ae8-f23840efe6e1.png)

Also corrects the x of the floating placeholder on a filled text field.
![simulator screen shot - iphone x - 2018-06-24 at 17 45 43](https://user-images.githubusercontent.com/1271525/41823974-7e8c5346-77d6-11e8-88ce-38f4adb32323.png)
2018-06-25 07:59:33 -07:00
Mohammad Cazi
9e7db06c7e Getting rid of paddedLabel Class since it's not needed anymore. (#4196) 2018-05-21 11:07:49 -04:00
Mohammad Cazi
a0aa725567 [TextField] floating placeholder overlaps with border. (#3606)
* fixing textField Border Issue.

* radius math offset

* explicit type def.
2018-05-01 14:39:08 -04:00
Mohammad Cazi
91a376ffe1 [TextFields] Adding font themer (#3096)
* Extracting Accessibility out of FeatureHighlightViewController to a mutator.
Tests added.
Example updated.

* Revert "Extracting Accessibility out of FeatureHighlightViewController to a mutator."

This reverts commit 0b5433ebf86366087b240c4dc4992a0603fa73e0.

* Adding Font themer to TextFields.

* extra lf.

* dealing with warnings.

* Fixing unit tests.

* commenting out low priority set up for bounds

* commenting out tests to see if tests would fail.

* tests are back, scale could have been zero.

* temp fix in case the fonts are zero.

* check for default inside setter.

* fix compliing mistakes.

* add documentation for the change.

* Example of dynamic size with different fonts.

* added support for dynamic type with custom fonts.

* fixed the top overlapping issue

* Replied to comment and fixed the issues.

* Adding Text Input property to InputController
Changing the value of mdc_adjustsFontForContentSizeCategory should not effect the actual controller fonts that are set by user but only the properties of the actual textfield. In order to do that I moved the resizing of fonts away from the properties of InputController and into update layout.

* Fixing the comment. Changing font scheme to not accept nullable controllers.

* change documentation.
2018-03-23 15:03:13 -04:00
Will Larche
62d5a4fa85 [TextFields] Feature branch merge: Clarity, Safety, Docs, Comments, Formatting (#2634)
* [TextFields] Full width changes. (#2590)

* [TextFields] Propagating changes to themers. (#2585)

* [TextFields] Propagating changes to themers.

* [TextFields] Updates to themer examples.

* [TextFields] Base controller class files (#2582)

* [TextFields] New Base class files.

* [TextFields] Naming corrections.

* [TextFields] Formatting.

* [TextFields] Replacing -Default with -Underline (#2583)

* [TextFields] Adding underline controller.

* [TextFields] Changes to umbrella import file and removing default controllers.

* [TextFields] Renaming one file.

* [TextFields] Updated controller headers. (#2584)

* [TextFields] Updating examples. (#2586)

* [TextFields] Running clang-format on the elements. (#2587)

* [TextFields] Running format on the element itself.

* [TextFields] Minor formatting.

* [TextFields] Updating tests and formatting. (#2588)

* [TextFields] Filled controller changes. (#2589)

* [TextFields] Legacy controller comments, naming, and formatting. (#2591)

* [TextFields] Legacy controller comments, naming, and formatting.

* [TextFields] Adding safety to legacy default init.

* [TextFields] Adding safety to Legacy Default init.

* [TextFields] Formatting Legacy Default.

* [TextFields] Formatting Legacy Full Width.

* [TextFields] Text area comments, updated super, naming, formatting. (#2593)

* [TextFields] Text area updates.

* [TextFields] Clarifying comment.

* [TextFields] Outline changes and formatting. (#2592)

* [TextFields] Updates to styling doc. (#2594)

* [TextFields] Updates to styling doc.

* [TextFields] Updating doc.

* [TextFields] Full width comments, safety, formatting, and underline support. (#2633)

* [TextFields] Adding safety to full width.

* [TextFields] Formatting Full Width.

* [TextFields] PR feedback.

* [TextFields] Safety in init of Base (#2632)

* [TextFields] Adding safety to base init.

* [TextFields] Formatting Base.

* [TextFields] Updates to controller header. (#2636)

* [TextFields] Updates to controller header.

* [TextFields] Updating misleading comments.

* [TextFields] Supplemental file name changes. (#2635)
2017-12-12 11:07:48 -05:00
Yurii Samsoniuk
2a96682230 Replace unnecessary imports with forward declarations (#2429)
* [Themes] Remove unnecessary imports.

* [TextFields] Remove unnecessary imports.

* [Typography] Do not use an umbrella header inside of a component.

* [Snackbar] Do not use self umbrella header.

* [ActivityIndicator] Do not use self umbrella header.

* [AppBar] Use umbrella headers.

* [AppBar] Remove self import header.

* [ButtonBar] Removed self umbrella header imports.

* [Buttons] Removed self umbrella header imports.

* [Collections] Update imports.

* [Dialogs] Moved import into an m file.

* [Collections] Fixed imports.

* [FeatureHighlight] Removed self umbrealla imports.

* [HeaderStackView] Reordered imports.

* [Ink] Replaced imports with forward declarations.

* [Slider] Replaced self umbrella import use.

* [Snackbar] Removed self umbrella header import.

* [Tabs] Changed math import. Replaced self umbrella header import.

* [Icons] Removed unnecessary imports.

* [Overlay] Replaced umbrella header import.

* [ShapeLibrary] Replace Shapes imports with an umbrella header.

* [Shapes] Replaced imports with forward declarations.

* [AppBar] Replace import with a forward declaration.

* [Examples] Updated imports.

* Fixed conflicting imports

* Added space between different import categories
2017-11-16 18:25:06 -05:00
Will Larche
93cc72187f
[TextFields] Complete theming of controllers (#2416)
* [TextFields] Encapsulating some common API into a protocol.

* [TextFields] Refactoring to use new protocol for theming.

* [TextFields] Themer work.

* [TextFields] Removing unneeded import.

* [TextFields] Correcting documentation mistake.

* [TextField] Formatting.

* [TextFields] Documentation update.

* [TextFields] PR feedback.

* [TextFields] Silencing Xcode 8 only warnings.
2017-11-14 21:21:41 -05:00
Will Larche
17e962fb35 [TextFields] Corrects cheap floating placeholder layout (2nd PR) (#2210)
* [TextFields] Calculations are improved but still off.

* [TextFields] Compensating for internal behavior.

* [TextFields] Correcting placeholder compression resistence.

* [TextFields] Probably best working animation without translations.

* [TextFields] Adding text field did update constraints.

* [TextFields] Correcting autolayout value.

* [TextFields] Redoing placeholder calculations.

* [TextFields] Removing out of date comment.

* [TextFields] Some formatting.

* [TextFields] Undoing some formatting.

* [TextFields] Forgot to nil out property.

* [TextFields] Adding new calculations to the legacy default.

* [TextFields] PR feedback.

* [TextFields] Formatting.

* [TextFields] PR feedback.

* [TextFields] Formatting.

* [TextFields] Better comment.
2017-10-17 21:59:50 -04:00
Will Larche
cde864f235 [TextFields] Renaming classes to match the MD spec (#2061)
* [TextFields] Renaming classes to match the spec.

* [TextFields] Renaming examples.
2017-09-27 22:10:47 -04:00