6 Commits

Author SHA1 Message Date
Will Larche
8c5350de31 [All] Formatting. (#1269) 2017-03-22 12:18:15 -04:00
Gauthier Ambard
2d8dbeb6de [CollectionLayoutAttributes] Fix comparison (#1268)
* [CollectionLayoutAttributes] Fix comparison

Fix the comparison operator of MDCCollectionViewLayoutAttributes.
The MDCCollectionViewLayoutAttributes isEqual: method used a isEqual: on
objects that can be nil. This returns nil even if the two objects are nil.

closes #1264

* [Collections] - Moved is:EqualTo: class method into isEqual: instance method
2017-03-21 16:36:52 -04:00
randallli
ffd56e6d30 [FontDiskLoader, RobotoFontLoader, Typography] The results of some readability code reviews from some googlers.
Summary:
internal reference: cl/121301531
  - Renamed some of the FontDiskLoader's APIs to be more readable.
    - |registerFont| renamed to |load|
    - |unregisterFont| renamed to |unload|
    - |isRegistered| renamed to |loaded|
  - Made FondDiskLoader thread safe.
  - Made fontName and fontURL copy, readonly, nonnull properties.
  - More comments across the board and other miscellaneous Objective C Readability issues.
  - Readded to be deprecated setFontName and other APIs.

Internal implementation detail refactors:
  - Removed references to 'resource' as that was part of the old name of the FontDiskLoader class.
  - Using dispatch queue for |loaded| protection instead of @syncronized. Also using class method for |setLoaded|.
  - Fixed tests to make them not set the name of the font
  - Added more descriptive messages for tests

Reviewers: O1 Material components iOS, iangordon

Reviewed By: O1 Material components iOS, iangordon

Subscribers: iangordon

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1265
2016-09-07 12:44:47 -04:00
Adrian Secord
8c3af252be Adding AUTHORS and removing CONTRIBUTORS.txt.
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...

Summary:

We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.

Changed copyright statement to include non-Google authors.

Command run:

find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods  \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'

Added non-source files.

Command run:

grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'

Reviewers: featherless, O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1415
2016-08-08 08:16:37 -07:00
Adrian Secord
3aedace959 Re-enabled 100-character line limit.
Reviewers: randallli, O1 Material components iOS

Reviewed By: randallli, O1 Material components iOS

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D965
2016-06-13 13:34:57 -04:00
Adrian Secord
142bd2fb7e Added unit tests for MDCCollectionLayoutAttributes.
Reviewers: #mdc_ios_owners, cjcox

Reviewed By: #mdc_ios_owners, cjcox

Subscribers: cjcox

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D747
2016-04-22 17:02:36 -04:00