Summary:
The rendering mode is lost when an image is flipped with
-[UIImage imageWithCGImage:scale:orientation:].
When that would happen, actually render the image with it's orientation and
scale, port the template mode, and return that copy.
Closes https://github.com/google/material-components-ios/issues/592.
Test Plan:
Check that back arrow in Catalog is correctly flipped relative to the layout
direction.
Reviewers: randallli, O1 Material components iOS, iangordon
Reviewed By: randallli, O1 Material components iOS, iangordon
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1034
Summary:
MDCRectFlippedForRTL returns a CGRect prepared for layout
based on the layout direction.
Closes https://github.com/google/material-components-ios/issues/604.
Test Plan: Passes the unittests.
Reviewers: O1 Material components iOS, iangordon, brianjmoore
Reviewed By: O1 Material components iOS, iangordon, brianjmoore
Subscribers: ajsecord, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1041
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
- [ ] I did not `arc land` this change because I followed the [releasing guide](https://github.com/google/material-components-ios/blob/develop/contributing/contributor_guides/releasing.md) and did the following:
- [ ] Ran `scripts/release/merge`
- [ ] Push to master
- [ ] Push to develop
- [ ] Manually marked this diff closed in the web ui
Reviewers: O1 Material components iOS!
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D925
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D825
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D791
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D767
Summary: This is in preperation for renaming Private to privateWasCapital.
Reviewers: ajsecord, featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D249
Summary:
Similar to Catalog by convention, Testing by convention allows us to generate a fully-working unit test suite using CocoaPods wildcards.
The testing convention is to place unit test source files in a `tests/unit` folder within each component.
A complete "component by convention" now looks like so:
component/
examples/
SomeExample.m
src/
...
tests/
unit/
SomeTest.m
This convention makes it trivially easy to run all tests in our project & generate coverage information. Here are our coverage results:
{F439}
Resolves https://github.com/google/material-components-ios/issues/106.
Reviewers: cjcox, ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D158
