26 Commits

Author SHA1 Message Date
Justin Shephard
26819f760d Updates to API Diff Process (#848)
* release-candidate - Updated indentation for api_diff script

* API_Diff - Removed references to obj_diff, added source kitten install script

* API_Diff - Added material motion api_diff submodule

* API_Diff - Added conditional for Ink and Snackbar to be diff'd manually

* API_DIff - Updated api diff tool sha
2016-11-09 17:08:48 -05:00
Jeff Verkoeyen
0678c3360b Update arc-xcode-test-engine to v3.0.7.
Summary: Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.7

Reviewers: O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1326
2016-07-26 11:54:26 -04:00
Jeff Verkoeyen
7d10b7a56a Update arc-jazzy-linter to v1.1.0.
Summary: Release notes: https://github.com/google/arc-jazzy-linter/releases/tag/v1.1.0.

Reviewers: O1 Material components iOS, ajsecord

Reviewed By: O1 Material components iOS, ajsecord

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1261
2016-07-19 13:04:18 -04:00
Jeff Verkoeyen
3149989194 Update arc-xcode-test-engine to v3.0.6.
Summary: Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.6

Reviewers: O1 Material components iOS, ajsecord

Reviewed By: O1 Material components iOS, ajsecord

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1251
2016-07-18 13:55:10 -04:00
Jeff Verkoeyen
6aae667f13 Update arc-xcode-test-engine to v3.0.5.
Summary: Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.5

Reviewers: O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1165
2016-07-08 14:38:53 -04:00
Jeff Verkoeyen
ff214a8b62 Update jazzy-linter to v1.0.1.
Summary: Release notes: https://github.com/google/arc-jazzy-linter/releases/tag/v1.0.1

Reviewers: O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Subscribers: randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1137
2016-07-07 15:05:00 -04:00
Jeff Verkoeyen
53122b29e8 Update arc-xcode-test-engine to v3.0.4.
Summary: Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.4

Reviewers: O1 Material components iOS, ajsecord

Reviewed By: O1 Material components iOS, ajsecord

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1095
2016-07-01 13:47:11 -04:00
Jeff Verkoeyen
9674a8fe22 Update arc-proselint to v1.0.1.
Summary: See release notes: https://github.com/google/arc-proselint/releases/tag/v1.0.1

Reviewers: O1 Material components iOS, randallli

Reviewed By: O1 Material components iOS, randallli

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D996
2016-06-20 13:33:48 -04:00
Jeff Verkoeyen
4197f3311f Upgrade arc-xcode-test-engine to v3.0.3.
Summary:
Resolves issues with Xcode 7.3 and arc unit's coverage reporting.

See the v3.0.3 release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.3

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D821
2016-05-04 15:03:23 -04:00
Adrian Secord
aad2d08051 Release candidate.
Summary:
Checklist:

- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.

Reviewers: #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D791
2016-04-28 13:39:56 -04:00
Jeff Verkoeyen
b1e046a5a6 Update arc-xcode-test-engine to 3.0.2.
Summary:
Changelog for 3.0.1 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.1:

* If tests fail to build we no longer generate a  `Unhandled Exception ("PhutilTypeMissingParametersException")` exception on Phabricator. We were not previously providing a name to the ArcanistUnitTestResult instance.

Changelog for 3.0.2 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.2:

* Resolves crash caused by referencing the wrong stderr variable. The error was `Attempt to read from undeclared property XcodeUnitTestEngine::stderr`.

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D775
2016-04-27 11:48:31 -04:00
Jeff Verkoeyen
c2e268eda0 Update arc-xcode-test-engine to 3.0.0.
Summary:
This release allows `arc unit` to be run from sub-directories.

3.0.0 release notes (https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.0):

- Commands now always run from the root directory of the project rather than from the shell's current working directory. This may be a breaking change.

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D772
2016-04-27 10:57:03 -04:00
Jeff Verkoeyen
db7c9da1e9 Add regex-line-length-lint.
Summary: This linter is able to ignore lines that match certain regexes, lowering our rate of linter false-positives.

Reviewers: ajsecord, #mdc_ios_owners

Reviewed By: ajsecord, #mdc_ios_owners

Subscribers: iangordon

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D477
2016-04-12 09:55:55 -04:00
Jeff Verkoeyen
c4601975fb Add Jazzy linter v1.0.0.
Summary:
Example output:

```
>>> Lint for components/ShadowLayer/src/MDCShadowLayer.h:

   Warning  (JAZZY1) Missing documentation
    topShadowRadius is missing documentation.
    Please use `/** */` blocks to document APIs.

              23  spec.
              24  */
              25 @interface MDCShadowMetrics : NSObject
    >>>       26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;

   Warning  (JAZZY1) Missing documentation
    topShadowOffset is missing documentation.
    Please use `/** */` blocks to document APIs.

              24  */
              25 @interface MDCShadowMetrics : NSObject
              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
    >>>       27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;

   Warning  (JAZZY1) Missing documentation
    topShadowOpacity is missing documentation.
    Please use `/** */` blocks to document APIs.

              25 @interface MDCShadowMetrics : NSObject
              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
    >>>       28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;
              31 @property(nonatomic, readonly) float bottomShadowOpacity;

   Warning  (JAZZY1) Missing documentation
    bottomShadowRadius is missing documentation.
    Please use `/** */` blocks to document APIs.

              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
    >>>       29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;
              31 @property(nonatomic, readonly) float bottomShadowOpacity;
              32
```

Reviewers: #mdc_ios_owners, randallli

Reviewed By: #mdc_ios_owners, randallli

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D211
2016-04-11 17:38:09 -04:00
Jeff Verkoeyen
78f3f7f049 Update arc-xcode-test-engine to v2.1.1.
Summary:
Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.1

This release decreases arc unit duration by roughly half (~50s average to ~27s average on a Macbook Air 11" 1.7 GHz Intel Core i7)

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D530
2016-04-08 10:53:00 -04:00
Jeff Verkoeyen
6bb73753fb Add proselint linter.
Summary:
arc-proselint linter: https://github.com/google/arc-proselint
proselint the tool: http://proselint.com/

Proselint is a linter for written text, specifically English. This diff enables it for our markdown files.

How to install proselint:

    pip install proselint

Reviewers: ajsecord, #mdc_ios_owners

Reviewed By: ajsecord, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D491
2016-04-06 12:22:27 -04:00
Jeff Verkoeyen
ebad21ad64 Update arc-xcode-test-engine to v2.1.0 and add pre-build option to .arcconfig.
Summary:
v2.1.0 release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.0

Running `pod install` before `arc unit` runs its build phase ensures that the Testing by Convention app is always building against the tests on disk.

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Subscribers: ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D463
2016-04-04 14:16:37 -04:00
Jeff Verkoeyen
f91f84b1c4 Update arc-xcode-test-engine to v2.0.2.
Summary: Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.0.2.

Reviewers: #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D456
2016-04-01 15:12:14 -04:00
Jeff Verkoeyen
4d22229e5a Update arc-xcode-test-engine to v2.0.1.
Summary:
- Better handling of non-unit-test failures, such as CocoaPods getting out of sync.

Full release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.0.1

Reviewers: randallli, #mdc_ios_owners

Reviewed By: randallli, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D453
2016-04-01 14:20:22 -04:00
Junius Gunaratne
692287aee4 [Catalog] Change nav to use top AppBar instead of bottom CatalogBar
Summary:
Exploration of using AppBar as example VC wrapper
http://codereview.cc/M8

Reviewers: #mdc_ios_owners, featherless

Reviewed By: #mdc_ios_owners, featherless

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D443
2016-04-01 11:29:06 -04:00
Will Larche
958b94fcef Barebones Flexible Header: New styling and content
Summary: This is the 'typical use' example for flexible header. It's been changed to have less content and styling that matches the new catalog app. Universal and all rotations.

Reviewers: featherless, #mdc_ios_owners

Reviewed By: featherless, #mdc_ios_owners

Subscribers: featherless

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D430
2016-04-01 11:13:34 -04:00
Junius Gunaratne
36ba8b0197 [Button demos] Add disabled button states to demos, change storyboard bg color
Reviewers: ajsecord, featherless, #mdc_ios_owners

Reviewed By: featherless, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D428
2016-03-31 09:24:43 -04:00
Junius Gunaratne
5423fdd808 [Catalog] Make sure wrapper VC layout is correct on rotation
Reviewers: #mdc_ios_owners, featherless

Reviewed By: #mdc_ios_owners, featherless

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D418
2016-03-31 09:18:12 -04:00
Jeff Verkoeyen
8210233110 Update arc-xcode-test-engine to 2.0.0.
Summary: Enables coverage visualization in the web UI by default. arc unit will now properly fail if unit tests didn't run.

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Subscribers: ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D422
2016-03-30 14:52:35 -04:00
Jeff Verkoeyen
b6031761da Update arc-xcode-test-engine to latest stable release.
Summary: This release enables coverage by default when running arc diff.

Reviewers: #mdc_ios_owners, ajsecord

Reviewed By: #mdc_ios_owners, ajsecord

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D414
2016-03-30 10:55:25 -04:00
Adrian Secord
df8b4ddb50 Updated Arcanist config to use submodules.
Summary:
Added arc-xcode-test-engine and clang-format-linter as submodules.
Updated .arcconfig to point to submodules.

NOTE: Until scripts/install_arc.sh is landed, arc users will need to run
```
git submodule init
git submodule update
```
to pull in arc's extensions as submodules.

Reviewers: featherless, #mdc_ios_owners

Reviewed By: featherless, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D287
2016-03-17 12:33:28 -04:00