* Add directory blacklist to manage_pods.py.
`manage_pods.py` will now ignore Podfiles found in any path that has either "external" or "third_party" in their path.
Add `list` command to list Podfile directories.
* Improved blacklist handling to not recurse blacklisted directories.
* Add README.md to scripts/check.
* Generalized the check_components script.
* Renamed `missing_readme` to `readme`.
* Added documentation to the `scripts/check` directory.
* Disabled the `scripts/check/missing_example_language` script.
* Cleanup verbose echoing in check_components script.
* Added more verbosity options.
* Added check for accessible URLs.
* Added option parsing.
* Added left-nav checks.
* Added license stanza check.
* Added reporting of failed components to check_components script.
* Added a script to convert between naming conventions.
* Added script to check for videos.
* Added check for video still.
* Added script to check for site icon.
* Added DO NOT SUBMIT check.
* Properly quoted output file paths.
* Added check for examples.
* Updated checklist docs for new script setup.
* Added check for example languages in README.md files.
Deleted old PHP code.
* Added missing exit(-1) from example_languages.
* Added uniform error output to example_languages.
* Fixed verbosity of scripts/check_components.
* Add README.md to scripts/check.
* Generalized the check_components script.
* Renamed `missing_readme` to `readme`.
* Added documentation to the `scripts/check` directory.
* Disabled the `scripts/check/missing_example_language` script.
* Cleanup verbose echoing in check_components script.
* Added more verbosity options.
* Added check for accessible URLs.
* Added option parsing.
* Added left-nav checks.
* Added license stanza check.
* Added reporting of failed components to check_components script.
* Added a script to convert between naming conventions.
* Added script to check for videos.
* Added check for video still.
* Added script to check for site icon.
* Added DO NOT SUBMIT check.
* Properly quoted output file paths.
* Added check for examples.
* Updated checklist docs for new script setup.
* Added check for example languages in README.md files.
Deleted old PHP code.
* Added missing exit(-1) from example_languages.
* Added uniform error output to example_languages.
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...
Summary:
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.
Changed copyright statement to include non-Google authors.
Command run:
find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Added non-source files.
Command run:
grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Reviewers: featherless, O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1415
Summary:
The contributing readmes are nested in two folders. Moving them out of the inner folder.
Fixed references to releasing.md
We should land cl/128400669 after this lands.
Reviewers: O1 Material components iOS, ajsecord
Reviewed By: O1 Material components iOS, ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1329
Summary:
Removed space inside []
Clarified some of the steps.
Reviewers: ajsecord, O1 Material components iOS
Reviewed By: ajsecord, O1 Material components iOS
Subscribers: ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1311
Summary:
Many and various fixes—the scripts still need a lot of work.
- Fixed the brew install script
- Fixed the clang-format install script to update clang-format if an update exists.
- Fixed `if [ ! `some_command` ]; then` invocations, which doesn't do what the original authors seemed to have thought it does.
- Removed all `set -e` from bash scripts... there's no need to echo everything under the sun.
- Added `set -o errexit` for simple scripts so the script would just bail if any one command failed.
- Lowered general verbosity in some places.
Reviewers: O1 Material components iOS, junius, featherless
Reviewed By: O1 Material components iOS, junius
Subscribers: ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1035
Summary:
DO NOT LAND until after we have finalized our May 25 2016 release.
Cocoapods 1.0.0 was used to generate Pod* and xcode* files.
These changes are NOT compatible with 0.39.0.
These changes may NOT be compatible with version of Xcode 7.2 and earlier.
pod lib lint generates a list of issues that should be addressed.
--OLD INFO--
Cocoapods 0.39 was used to generate the Podfile.locks.
MaterialComponents - Build properly
MaterialUnitTests - Test properly
MaterialCatalog - Fails to Build
The errors (cut after the first 20) are similar to:
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "Headers/MaterialComponentsCatalog-umbrella.h"
^
/Users/iangordon/projects/material-components-ios/catalog/Pods/Target Support Files/MaterialComponentsCatalog/MaterialComponentsCatalog-umbrella.h:10:9: note: in file included from /Users/iangordon/projects/material-components-ios/catalog/Pods/Target Support Files/MaterialComponentsCatalog/MaterialComponentsCatalog-umbrella.h:10:
#import "CollectionCellsLayoutExample.h"
....
Reviewers: featherless, randallli, ajsecord, #material_components_ios
Reviewed By: featherless, randallli, ajsecord, #material_components_ios
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D873
Summary:
- api_diff now handles APIs that have moved to a new file.
- jverkoey/objc-diff correctly handles deprecated API changes.
Reviewers: O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Subscribers: randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D890
Summary:
Assets catalogs require to use imageNamed:. Since we want Icons to let clients
handle the caching, we only provide the path for the resource in our bundle.
Closes https://github.com/google/material-components-ios/issues/467.
Test Plan:
Build the catalog and verify that CollectionCells' accessory images are
displayed correctly for all resolutions and configurations.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D793
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D791
Summary:
`git rev-list -n 1 <ref>` returns the nearest commit's sha for a given ref.
`git rev-parse <ref>` returns the sha for the ref itself. E.g. tags have their own sha distinct from the commit to which they're associated.
GitHub doesn't reconcile shas for tags, so `git rev-list` ensures that our api_diff output will always be linkable on GitHub.
Reviewers: #mdc_ios_owners, iangordon
Reviewed By: #mdc_ios_owners, iangordon
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D787
Summary: This script is a general-purpose tool for creating a clone of the repo at a specific ref. It will be helpful for use in other API diffing tools.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D784
