Randall Li
ce0fc0ac60
[PageControl] Fixed NS_DESIGNATED_INITIALIZER usage in private classes. ( #932 )
2016-12-02 14:24:59 -05:00
Sean O'Shea
bee2af6211
Removing the last few remaining references to using id as a return type ( #671 )
...
for initializers.
2016-08-16 12:08:31 -04:00
Adrian Secord
8c3af252be
Adding AUTHORS and removing CONTRIBUTORS.txt.
...
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...
Summary:
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.
Changed copyright statement to include non-Google authors.
Command run:
find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Added non-source files.
Command run:
grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Reviewers: featherless, O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1415
2016-08-08 08:16:37 -07:00
Adrian Secord
a045b07bcc
Fix internal builds.
...
Summary:
- Adds missing dependencies to the podspec.
- Fixes private import paths.
- Adds dummy variable to "empty" static library targets to suppress build warnings.
- Suppresses string concatenation warnings in valid contexts.
- Lint changes.
Reviewers: iangordon, O1 Material components iOS
Reviewed By: iangordon, O1 Material components iOS
Subscribers: junius
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1074
2016-06-30 13:19:16 -04:00
randallli
c447675a5d
[PageControl] Made control compatible with animation blocks adjusting the scrollView.contentOffset.
...
Summary: scrollViewDidScroll: now detects if it the scrollView.contentOffset has an CAAnimation. If so then it will animate the indicator and track accordingly.
Reviewers: cjcox, O1 Material components iOS
Reviewed By: cjcox, O1 Material components iOS
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1043
2016-06-27 17:09:02 -04:00
Adrian Secord
da7177c74e
Applied the results of arc lint --everything. Again.
...
Reviewers: O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1039
2016-06-27 12:00:12 -04:00
Justin Shephard
34bad428ee
MDC_#492 - Audit for Objective-C Generics
...
Summary:
Implementation of generics throughout component header & implementation files.
- Where applicable, added generics to collection objects
Files Changed:
MDCActivityIndicator.m
MDCAppBar.m
MDCButtonBar.h
MDCButtonBar.m
MDCAppBarButtonBarBuilder.m
MDCButton.
MDCCollectionViewController.m
MDCCollectionViewFlowLayout.m
MDCCollectionViewStyling.h
MDCInkLayer.m
MDCNavigationBar.h
MDCNavigationBar.m
MDCPageControl.m
MDCPageControlTrackLayer.m
MDCPalettes.m
MDCSpritedAnimationView.m
---
Closes https://github.com/google/material-components-ios/pull/594
GitHub author: ShepJGoogle
!![[https://github.com/google/material-components-ios/pull/594 | This is a child of GitHub pull request #594 ]]!!.
Reviewers: O1 Material components iOS, #mdc_ios_owners, github-bot
Reviewed By: O1 Material components iOS, #mdc_ios_owners
Subscribers: ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1029
2016-06-23 15:43:37 -04:00
Adrian Secord
3aedace959
Re-enabled 100-character line limit.
...
Reviewers: randallli, O1 Material components iOS
Reviewed By: randallli, O1 Material components iOS
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D965
2016-06-13 13:34:57 -04:00
Jeff Verkoeyen
21d5cf1d04
Global find-and-replace of 'kMDC' with 'k'.
...
Summary: Closes https://github.com/google/material-components-ios/issues/435 .
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D759
2016-04-26 15:20:18 -04:00
Adrian Secord
43cd7fea32
Added MDCPageControl initWithCoder:.
...
Fixes #61 .
Summary: Fixes #61 .
Reviewers: #mdc_ios_owners, cjcox
Reviewed By: #mdc_ios_owners, cjcox
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D713
2016-04-21 17:14:14 -04:00
randallli
e1f584adad
[PageControl] Fix crash when scrollView offset is set out of bounds of the numberOfPages
...
Summary: If you set the content offset to larger than range of the page count the Page Control crashes because it tries to index out of bounds of an array.
Reviewers: cjcox, #mdc_ios_owners, featherless
Reviewed By: cjcox, #mdc_ios_owners, featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D671
2016-04-21 12:50:25 -04:00
randallli
e0d8050ef3
[PageControl] Publicized conformance to UIScrollViewDelegate.
...
Reviewers: cjcox, featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D703
2016-04-21 12:08:59 -04:00
randallli
b78ffc5b68
[PageControl] Fixed sizeForNumberOfPages: was not using passed in argument
...
Reviewers: cjcox, #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D583
2016-04-13 10:33:59 -04:00
Jeff Verkoeyen
8416f8e540
Ran arc lint --everything --apply-patches.
...
Summary: Ran with clang-format 3.9.0.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D534
2016-04-08 11:35:37 -04:00
Adrian Secord
3aad44b02c
[Other] Remove old @ingroup document annotations.
...
Summary: Closes #220 .
Reviewers: #mdc_ios_owners, featherless
Reviewed By: #mdc_ios_owners, featherless
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D365
2016-03-25 18:41:18 -04:00
Adrian Secord
83b85efb9a
[Other] Fixes block comments globally.
...
Summary: Fixes #215 .
Reviewers: #mdc_ios_owners, featherless
Reviewed By: #mdc_ios_owners, featherless
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D356
2016-03-25 16:51:32 -04:00
Ian Gordon
8429e096cd
[pagecontroller] Fix FP conversion warning
...
Reviewers: #mdc_ios_owners, randallli
Reviewed By: #mdc_ios_owners, randallli
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D243
2016-03-10 17:25:32 -05:00
Chris Cox
2c40024055
[PageControl] Prevents undesired scrolling during rotation.
...
Reviewers: ajsecord, #material_components_ios_owners, featherless
Reviewed By: #material_components_ios_owners, featherless
Subscribers: featherless
Projects: #material_components_ios_owners
Differential Revision: http://codereview.cc/D33
2015-12-17 13:41:51 -05:00
Brian Moore
63c6605bb6
Rename goo_ to mdc_ for consistency
2015-12-09 16:27:22 -05:00
Chris Cox
e0ca1e7fa9
Temporary rename private
...
Summary: [PageControl] Renames Private to private
Reviewers: ajsecord, #material_components_ios_owners
Reviewed By: ajsecord, #material_components_ios_owners
Projects: #material_components_ios_owners
Differential Revision: http://codereview.cc/D7
2015-12-03 16:32:14 -05:00
Chris Cox
e2bb0d2c5c
[PageControl] Uses private as lowercase. Also removed old repo now since moved to components folder.
...
Reviewers: ajsecord, #material_components_ios_owners
Reviewed By: ajsecord, #material_components_ios_owners
Projects: #material_components_ios_owners
Differential Revision: http://codereview.cc/D6
2015-12-03 16:11:32 -05:00
Chris Cox
728a1d0c7d
Copies PageControl and SpritedAnimationView components to components folder. Original to be removed after I move clients over.
...
Reviewers: ajsecord, featherless, #mux
Projects: #mux, #material_components_ios
Differential Revision: http://mux-oss-phabricator.appspot.com/D45
2015-12-01 10:57:43 -05:00