We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...
Summary:
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.
Changed copyright statement to include non-Google authors.
Command run:
find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Added non-source files.
Command run:
grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Reviewers: featherless, O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1415
Summary:
All changes are a result of warnings from swiftlint.
https://github.com/realm/swiftlint
This includes the following changes:
- Removing semicolons.
- Removing excess `(` and `)` on conditionals.
- Keeping `:` spacing consistent.
- Preferring modern Swift constructors, e.g. CGRect() over CGRectMake
- Avoiding forced type casting, preferring optional casting instead.
Reviewers: ajsecord, junius, #mdc_ios_owners
Reviewed By: ajsecord, junius, #mdc_ios_owners
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D478