We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has...
Summary:
We can credit any contributor who would like to be credited this way, by adding them on request to the AUTHORS file. The copyright statement changes are required for this to work. Note that this has no legal change, since the contributors always retained their copyright despite the copyright notice, but it's a nice acknowledgement.
Changed copyright statement to include non-Google authors.
Command run:
find * \( -name '*\.m' -or -name '*\.h' -or -name '*\.swift' \) -and -not \( -path 'scripts/external*' -name Pods \) -print0 | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Added non-source files.
Command run:
grep -Rl 'Copyright .* Google Inc' * --exclude-dir scripts/external --null | xargs -0 sed -i '' 's/Copyright \(.*\) Google Inc/Copyright \1 the Material Components for iOS authors/'
Reviewers: featherless, O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1415
Summary: "Material design" is not capitalized except when referring to the actual Material Design team at Google.
Reviewers: O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Subscribers: randallli, featherless
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1306
Summary: Closes https://github.com/google/material-components-ios/issues/574.
Test Plan:
1. Open Catalog on iPad Air 2 in Split View.
2. Open AppBar
> AppBar should not be cut.
3. Open Demo
> The RIGHT button should be on the right, and should stay there even when
> resizing the app, rotating the iPad, etc.
Reviewers: featherless, O1 Material components iOS
Reviewed By: featherless, O1 Material components iOS
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D975
Summary: The catalog now calls init on view controllers to initialize them. This does not chain to initWithNibName.
Reviewers: #mdc_ios_owners, junius
Reviewed By: #mdc_ios_owners, junius
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D689
Summary:
The argument justifying the protocol-oriented approach to App Bar was "convenience", but as is so often the case this convenience actually introduced a variety of costs. Notably:
- Properties defined in a protocol must be synthesized. This was annoying.
- We could not add new properties to the protocol without breaking all clients (they'd get "does not conform to protocol errors").
- We'd overcomplicated the view registration mechanisms. You now simply create an App Bar object and manage view controller parent/child relationships explicitly.
Before this change, clients using the App Bar had to:
1. Conform to a protocol.
2. Synthesize methods.
3. Call an initializer method.
4. Call a viewDidLoad method.
After this change, clients using the App Bar will:
1. Initialize an instance of MDCAppBar.
2. Register the App Bar's header view controller as a child view controller.
3. Call a viewDidLoad method.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D446
Summary: The App Bar component provides tools to create a 'typical' flexible header with navigation bar and material shadow.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D280
