DEV/material-components_material-components-ios
1
0
Fork 0
mirror of https://github.com/material-components/material-components-ios.git synced 2026-02-20 08:27:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
8,949 Commits 96 Branches 378 Tags
Commit Graph

3 Commits

Author SHA1 Message Date
Alyssa Weiss
bd6484925b Delete deprecated buttonFont for MDCAlert and make all appropriate changes following deletion 
PiperOrigin-RevId: 333566191
 2020-09-24 12:03:36 -07:00
Wenyu Zhang
313135ece2 [Dialogs] Add visibleAreaInsets support. 
PiperOrigin-RevId: 317137957
 2020-06-18 11:01:22 -07:00
Wenyu Zhang
8c407c22c4
[Dialogs] Layout MDC Dialogs correctly for tall fonts. (#7126) 
Closes https://github.com/material-components/material-components-ios/issues/7062

Reference: cl/241537224

Layout MDC Dialogs correctly for tall fonts

The MDC Dialog layout code had some hard coded assumptions about the amount of vertical space to allocate for action buttons that were violated when using taller fonts such as Urdu with large Dynamic Type sizes.
There was also a related bug where vertical vs. horizontal action button layout was calculated in two different places.

Snapshot test before change:
<img width="569" alt="snapshot_test_goldens_goldens_64_MDCAlertControllerLocalizationSnapshotTests_testPreferredContentSizeWithNotoNastaliqUrdu_11_2@2x_Before_01dd7fb1a36bc24b27e05c1079c6420994c9f904" src="https://user-images.githubusercontent.com/8836258/56166158-dc7c8700-5fa2-11e9-8fa1-ed4dbfdc947b.png">

Snapshot test result after change:
<img width="569" alt="snapshot_test_goldens_goldens_64_MDCAlertControllerLocalizationSnapshotTests_testPreferredContentSizeWithNotoNastaliqUrdu_11_2@2x_After_78d3fd9172a202641400c0536a9c2e3a33b0455b" src="https://user-images.githubusercontent.com/8836258/56166182-e7371c00-5fa2-11e9-976e-4f9c93efc98f.png">


Example screenshot before change:
![Simulator Screen Shot - iPhone 7 - 2019-04-15 at 17 42 09](https://user-images.githubusercontent.com/8836258/56167426-1dc26600-5fa6-11e9-9d5f-180f7960f458.png)


Example screenshot after change:
![Simulator Screen Shot - iPhone 7 - 2019-04-15 at 17 43 58](https://user-images.githubusercontent.com/8836258/56167432-2024c000-5fa6-11e9-8e44-5a88b48425f2.png)
 2019-04-15 19:26:55 -04:00