Summary:
- api_diff now handles APIs that have moved to a new file.
- jverkoey/objc-diff correctly handles deprecated API changes.
Reviewers: O1 Material components iOS, randallli
Reviewed By: O1 Material components iOS, randallli
Subscribers: randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D890
Summary:
Assets catalogs require to use imageNamed:. Since we want Icons to let clients
handle the caching, we only provide the path for the resource in our bundle.
Closes https://github.com/google/material-components-ios/issues/467.
Test Plan:
Build the catalog and verify that CollectionCells' accessory images are
displayed correctly for all resolutions and configurations.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D793
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D791
Summary:
`git rev-list -n 1 <ref>` returns the nearest commit's sha for a given ref.
`git rev-parse <ref>` returns the sha for the ref itself. E.g. tags have their own sha distinct from the commit to which they're associated.
GitHub doesn't reconcile shas for tags, so `git rev-list` ensures that our api_diff output will always be linkable on GitHub.
Reviewers: #mdc_ios_owners, iangordon
Reviewed By: #mdc_ios_owners, iangordon
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D787
Summary: This script is a general-purpose tool for creating a clone of the repo at a specific ref. It will be helpful for use in other API diffing tools.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D784
Summary:
This will allow us to more easily use objc-diff in other tools.
New script has two "modes":
- No arguments: clones and builds objc-diff
- -p: Echos path to the objc-diff binary and exits (produces no other output)
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D783
Summary:
Update script to properly set minor and patch levels to 0 if a
'higher' level has been incremented.
Reviewers: featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D785
Summary:
Changelog for 3.0.1 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.1:
* If tests fail to build we no longer generate a `Unhandled Exception ("PhutilTypeMissingParametersException")` exception on Phabricator. We were not previously providing a name to the ArcanistUnitTestResult instance.
Changelog for 3.0.2 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.2:
* Resolves crash caused by referencing the wrong stderr variable. The error was `Attempt to read from undeclared property XcodeUnitTestEngine::stderr`.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D775
Summary:
This release allows `arc unit` to be run from sub-directories.
3.0.0 release notes (https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.0):
- Commands now always run from the root directory of the project rather than from the shell's current working directory. This may be a breaking change.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D772
Summary:
The script is optimized for working with repositories where MDC is located in a sub-directory.
Example invocation:
~/workbench/material-components-ios/scripts/release/export-patch -p prefix/third_party/material_components_ios -c 757c0ec76413f0bd92b92ddc13692e803c6e0bff | git am
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D766
Summary: This allows the release scripts to be run from elsewhere in the file system. This will help write scripts that allow us to run release-candidate bisecting on the release branch.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D764
Designated GITHUB_REMOTE always to the main repository.
As a consequence, the community is able to update the content but not styling the site, unless they modify the script.
Summary:
- Add TODO in release/cut's CHANGELOG modification to ensure that the version number is provided.
- Add build_all_pod_projects.
Added to releasing.md:
- Section on "Send the release out for review"
- Building and running the pod projects.
- Broke out the version bumping scripts to minimize copy-pasting errors.
- Add list of clients that must confirm a release before it lands.
Closes https://github.com/google/material-components-ios/issues/353
Closes https://github.com/google/material-components-ios/issues/352
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D617
Summary: We now uninstall and reinstall in order to force pip to give us the latest version.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D575
Summary: This linter is able to ignore lines that match certain regexes, lowering our rate of linter false-positives.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: iangordon
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D477
Summary:
Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.1
This release decreases arc unit duration by roughly half (~50s average to ~27s average on a Macbook Air 11" 1.7 GHz Intel Core i7)
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D530
Summary:
- Removes the copy-pasted names and outputs the proper shas.
- Use the new url for deprecated APIs.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D500
Summary:
Includes the following tools:
- api_diff: Writes a CHANGELOG.md-ready API diff for the latest release to stdout.
- changed_files: Writes a list of modified component sources for the latest release to stdout.
- changed_public_headers: Writes a list of modified component public headers for the latest release to stdout.
- changes: Writes a CHANGELOG.md-ready list of changes in this release, organized by component, to stdout.
- cut: Creates a release-candidate branch, creates a release section in CHANGELOG.md, and outputs an email to be sent to the community to stdout.
- diff: Generates a diff from the last release to the current one.
- merge: Performs the final merge operations into master and develop for the current release.
- next: Returns a version number bumped from the latest release on origin/master.
These tools are all discussed in the new Releasing contributor guide also included in this diff.
Reviewers: randallli, iangordon, #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D509
Summary:
arc-proselint linter: https://github.com/google/arc-proselint
proselint the tool: http://proselint.com/
Proselint is a linter for written text, specifically English. This diff enables it for our markdown files.
How to install proselint:
pip install proselint
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D491
Summary:
v2.1.0 release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.0
Running `pod install` before `arc unit` runs its build phase ensures that the Testing by Convention app is always building against the tests on disk.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D463
Summary: This is the 'typical use' example for flexible header. It's been changed to have less content and styling that matches the new catalog app. Universal and all rotations.
Reviewers: featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D430
Summary: Enables coverage visualization in the web UI by default. arc unit will now properly fail if unit tests didn't run.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D422
Summary:
Part of https://github.com/google/material-components-ios/issues/257.
Output:
```
Each of the following components is missing readme:
FontDiskLoader
private/Color
private/Icons/icons/ic_arrow_back
private/ThumbTrack
RobotoFontLoader
```
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D417
