This will make it easier for us to keep all google-owned repositories running the same clang-format version in tandem.
Also moved from a submodule to a clone + version checkout so that our CI gracefully upgrades as we release new non-breaking release to clang-format-ci.
Relies on upstream changes in https://github.com/material-foundation/clang-format-ci/pull/4
## Context
Two libraries have graduated from the material-components-ios repo so that they can be used more generally across other open source projects: [clang-format-ci](https://github.com/material-foundation/clang-format-ci) and [github-comment](https://github.com/material-foundation/github-comment).
## What's going on here
Both of these libraries have been added as external submodule dependencies and the scripts have been updated to refer to the new external dependency paths.
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D791
Summary:
Changelog for 3.0.1 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.1:
* If tests fail to build we no longer generate a `Unhandled Exception ("PhutilTypeMissingParametersException")` exception on Phabricator. We were not previously providing a name to the ArcanistUnitTestResult instance.
Changelog for 3.0.2 at https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.2:
* Resolves crash caused by referencing the wrong stderr variable. The error was `Attempt to read from undeclared property XcodeUnitTestEngine::stderr`.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D775
Summary:
This release allows `arc unit` to be run from sub-directories.
3.0.0 release notes (https://github.com/google/arc-xcode-test-engine/releases/tag/v3.0.0):
- Commands now always run from the root directory of the project rather than from the shell's current working directory. This may be a breaking change.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D772
Summary: This linter is able to ignore lines that match certain regexes, lowering our rate of linter false-positives.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Subscribers: iangordon
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D477
Summary:
Release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.1
This release decreases arc unit duration by roughly half (~50s average to ~27s average on a Macbook Air 11" 1.7 GHz Intel Core i7)
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D530
Summary:
arc-proselint linter: https://github.com/google/arc-proselint
proselint the tool: http://proselint.com/
Proselint is a linter for written text, specifically English. This diff enables it for our markdown files.
How to install proselint:
pip install proselint
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D491
Summary:
v2.1.0 release notes: https://github.com/google/arc-xcode-test-engine/releases/tag/v2.1.0
Running `pod install` before `arc unit` runs its build phase ensures that the Testing by Convention app is always building against the tests on disk.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D463
Summary: This is the 'typical use' example for flexible header. It's been changed to have less content and styling that matches the new catalog app. Universal and all rotations.
Reviewers: featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Subscribers: featherless
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D430
Summary: Enables coverage visualization in the web UI by default. arc unit will now properly fail if unit tests didn't run.
Reviewers: #mdc_ios_owners, ajsecord
Reviewed By: #mdc_ios_owners, ajsecord
Subscribers: ajsecord
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D422
Summary:
Added arc-xcode-test-engine and clang-format-linter as submodules.
Updated .arcconfig to point to submodules.
NOTE: Until scripts/install_arc.sh is landed, arc users will need to run
```
git submodule init
git submodule update
```
to pull in arc's extensions as submodules.
Reviewers: featherless, #mdc_ios_owners
Reviewed By: featherless, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D287
