This avoids propagation of warnings to non-Material compilation units which may have deprecation warnings enabled as errors.
PiperOrigin-RevId: 460832988
* Fixes an issue where accessory view content could fall outside of the scroll view content frame.
* The content sizing calculation now matches layoutSubviews for accessory view height.
* I initially replaced the first call to `systemLayoutSizeFittingSize` in `calculateContentSizeThatFitsWidth` however that impacted the final view width. I suspect this was a result of `calculateContentSizeThatFitsWidth` being used in multiple places for different purposes (layout vs preferredContentSize).
BEGIN_PUBLIC
Update dialog accessory view content sizing to fix scroll view content height issues.
END_PUBLIC
PiperOrigin-RevId: 371901672
In iOS platform, text font are not strictly required to fit within the UIFont.lineHeight. Some Thai characters with diacritics are rendered outside the UILabel/UITextView's bounds.
One solution is to increase the top margin of the UILabel/UITextView so we leave extra padding between the parent view's top edge and the top edge of the UILabel/UITextView (Like the _titleLabel in MDCAlertControllerView).
closes#10161
PiperOrigin-RevId: 363491472
The API allows setting horizontal insets for the accessory view that are different from the message. This is most often used for dialogs that have both a message and an accessory view, as demonstrated in the attached example.
Additionally, this example demonstrates how to add an horizontal hairline as shown on the material.io spec for Confirmation Dialogs.
Note:
This new API is needed because clients do not always have control over the view that is being used as an accessory view, or that the view is used in multiple areas in the app, and cannot be customized.
Additionally, there's no way currently to set 0 insets for the accessory view, while still keeping the 24 value insets for the message, which is a relatively common scenario.
PiperOrigin-RevId: 334142026
There are still some iOS 13.4 betas floating around that had not yet introduced this API. This
change should prevent those users from crashing when attempting to get/set this value.
PiperOrigin-RevId: 326248791
The title icon image view size is updated after each orientation transition, causing the image to get smaller after each transition.
To fix this, we're using the original size of the titleIcon image, instead of the current size of the titleImageView to determine the actual size of the image.
PiperOrigin-RevId: 319127689
When actions are in vertical layout, the first trailing or leading action is incorrectly positioned on top of the second action, instead of above it.
This is fixed by moving the calculations of the y position of the second button after the first button is positioned.
PiperOrigin-RevId: 318979889
# Background
Email addresses in alert messages are highlighted when setting `dataDetectorTypes` to `UIDataDetectorTypeLink`. This is automatic in both attributed and non attributed messages.
# Fix
Removing assignment of `dataDetectorTypes` to links, which retain links without highlighting email addresses.
PiperOrigin-RevId: 315378755
The type of the message in Material Dialogs was switched from UILabel to UITextView, That is done in order to support links in attributed text. We're seeing some differences in the text rendering in dialog snapshots. In some cases, the width of the dialog may also change, which can result in some other elements moving to maintain required spacing from the edges. Based on our testing, we're not expecting any other changes, so please let us know if you find anything unusual.
This change set includes:
* `messageLabel` was renamed to `messageTextView`.
* The UITextView has its editable flag set to false, and all internal padding set to
zero, to ensure spacing remain the same as it was with UILabel.
* `scrollEnabled` was set to false to ensure text does't scroll when not needed (it
still enables scrolling when needed: when there's more text than the visible area.)
* `backgroundColor` was set to `clear`. It seems UITextView's default is white, which
breaks inverted/dark mode support.
Noticeable differences:
* `sizeThatFits` occasionally returns different width for some texts:
-- Some texts result in a wider layout (ie: dialogs-presented-with-emphasis-buttons.png)
-- Empty text views may have a non-zero height. Determining zero
size based on `hasText` before calling `sizeThatFits` resolved the issue.
* Text rendering is slightly different in almost all snapshots.
* Links in attributed texts are rendered differently then before (ie: color).
* In a couple of RTL snapshot tests, I needed to set the RTL test direction before
setting the message alignment for the test to work properly.
PiperOrigin-RevId: 313607718