196 Commits

Author SHA1 Message Date
Nobody
24a0ffbd03 Annotate various Delegate protocols as NS_SWIFT_UI_ACTOR
PiperOrigin-RevId: 708413470
2024-12-20 13:33:55 -08:00
Jeff Verkoeyen
6364df0db9 [ActivityIndicator] Delete flaky tests.
PiperOrigin-RevId: 609470670
2024-02-22 13:01:58 -08:00
Nobody
9e1c0c0a45 Internal change
PiperOrigin-RevId: 477458164
2022-09-28 08:26:32 -07:00
Jeff Verkoeyen
04424d224e [ActivityIndicator] Expose subclassing APIs.
PiperOrigin-RevId: 441338140
2022-04-12 17:49:00 -07:00
Jeff Verkoeyen
a57d3ccc3d [ActivityIndicator] Delete public documentation and tooling files.
Also moved the implementation source into the proper .h file.

PiperOrigin-RevId: 436990799
2022-03-24 07:38:25 -07:00
Nobody
108f768308 [ActivityIndicator] Change progress slider example to be a single Accessibility element
PiperOrigin-RevId: 411119437
2021-11-19 12:31:55 -08:00
Jeff Verkoeyen
d61cee6ea7 Enforce minimum OS on more targets.
PiperOrigin-RevId: 410752715
2021-11-18 03:03:55 -08:00
Jeff Verkoeyen
c34de39e30 Internal change.
PiperOrigin-RevId: 397316843
2021-09-17 07:45:01 -07:00
Randall Li
502bc5d910 Ran a Swift formatter
PiperOrigin-RevId: 395947664
2021-09-10 09:48:14 -07:00
Cody Weaver
272781fd85 [MDFInternationalziation] Remove mdf_semanticContentAttribute in favor of system API semanticContentAttribute.
PiperOrigin-RevId: 392680954
2021-08-24 09:29:08 -07:00
Nobody
5cb61f3efe Internal change.
PiperOrigin-RevId: 368230474
2021-04-13 09:29:08 -07:00
Cody Weaver
2416f191aa [ActivityIndicator] Add unit tests.
PiperOrigin-RevId: 358408235
2021-02-19 08:19:23 -08:00
Alyssa Weiss
f87b98f26b Update default stroke width to be 2.5
PiperOrigin-RevId: 333293466
2020-09-23 08:09:35 -07:00
Andrew Overton
07c46757cc Replace material.io API doc links with links to the relevant header f…
This PR replaces API links containing "/api-docs/" with links to suitable header files in GitHub because the site previously linked to is being taken down and replaced with something that won't handle API docs.

Closes https://github.com/material-components/material-components-ios/pull/10045

COPYBARA_INTEGRATE_REVIEW=https://github.com/material-components/material-components-ios/pull/10045 from andrewoverton:replace-mio-api-docs-with-github-links 0d6e56cc11d0c147366a4f6cde829d8b51567ecc
PiperOrigin-RevId: 323424362
2020-07-27 13:09:23 -07:00
Wenyu Zhang
a3381717f7
Fix the bazel BUILD files and snapshot that were restored unintentionally.(#9983) 2020-04-29 11:00:00 -04:00
Wenyu Zhang
61bf79c626 Internal change.
PiperOrigin-RevId: 308682786
2020-04-27 13:11:47 -07:00
Jeff Verkoeyen
25471afea0 Rename "flaky" to "skip_snapshots".
PiperOrigin-RevId: 308259307
2020-04-24 08:34:12 -07:00
Randall Li
0100cfe414 [MDC-iOS/BottomSheet] Fix dismissOnDraggingDownSheet behavior
The bottom sheet incorrectly allowed the sheet to be drag dismissed when `dismissOnDraggingDownSheet` was set to NO.

This change permits the gesture to dismiss to begin but prevents it from actually closing the sheet.

https://github.com/material-components/material-components-ios/issues/9723

Closes https://github.com/material-components/material-components-ios/pull/9885

PiperOrigin-RevId: 307802500
2020-04-22 06:21:26 -07:00
Jeff Verkoeyen
2040720492 [ActivityIndicator] Mark the swift example as flaky due to its use of animations and remove explicit titles.
This disables the example from being ran during snapshot tests. The titles are not used in the catalog; the breadcrumbs are used instead to populate the title.

PiperOrigin-RevId: 307729170
2020-04-21 19:38:33 -07:00
Dave MacLachlan
ebac2a8eb7 As of iOS 9/macOS 10.11 (circa 2015) removing objective C objects from the NSNotificationCenter in - (void)dealloc. is no longer required (the classic example is: [[NSNotificationCenter defaultCenter] removeObserver:self] but there are several variations).
In many cases this is the only thing being done in - (void)dealloc, so we can remove the whole thing.

PiperOrigin-RevId: 307663440
2020-04-21 13:00:30 -07:00
Jeff Verkoeyen
8abbb099a9 Delete all bazel support.
We no longer support bazel.

This PR deletes everything related to bazel support from our repo.

Closes https://github.com/material-components/material-components-ios/pull/9968

PiperOrigin-RevId: 306227127
2020-04-13 07:13:47 -07:00
Bryan Oltman
ebc52ec315 [ActivityIndicator] Move protocol definitions into separate header files
PiperOrigin-RevId: 301655949
2020-03-18 13:36:05 -07:00
Bryan Oltman
28a7fac63f
[Material][Availability] Migrates activity indicator to MDCAvailability. (#9735)
* [Material][Availability] Migrates activity indicator to MDCAvailability.

PiperOrigin-RevId: 293702405

* update build file

Co-authored-by: Eric Lee <eric.lee.edl@gmail.com>
2020-02-14 12:07:33 -05:00
featherless
162a063bda
[bazel] Remove all unused mdc_objc_library loads. (#9376)
Found by searching for all references to `\bmdc_objc_library` and removing load statements from files that only returned one result.

Clean up as part of https://github.com/material-components/material-components-ios/issues/9363
2020-01-02 14:34:36 -05:00
featherless
b7cf0de915
[bazel] Remove all unused swift_library load statements. (#9369)
Found by searching for all references to `\bswift_library` and removing load statements from files that only returned one result.

Clean up as part of https://github.com/material-components/material-components-ios/issues/5491
2020-01-02 11:01:31 -05:00
featherless
0a0bc4b47b
[automated] Ran buildifier on all BUILD files. (#9366)
```
find . -name BUILD | xargs buildifier
```

This is in preparation of https://github.com/material-components/material-components-ios/issues/9363
2020-01-02 10:05:07 -05:00
Yarden Eitan
c0a0d2b1de
[ActivityIndicator] Add a voiceover layout change notification… (#8909)
Adds a voiceover layout change notification and re-focus button after animation in ActivityIndicator Transition example.

Closes #8841
2019-11-15 10:56:48 -05:00
featherless
79fb766e01 [ActivityIndicator] Delete MDCActivityIndicatorColorThemer. (#8694)
It is deprecated and has no internal usage.

Part of #8429
2019-10-31 07:13:32 -07:00
Josh Converse
4d39b55d09 [ActivityIndicator] Removes 72dp radius limit on activity indicator (#8534)
This change removes the 72dp limit on an MDCActivityIndicator's radius.

closes #8533
2019-10-07 15:56:02 -04:00
Robert Moore
8cebc56185
[*] Suppress deprecation warnings. (#8481)
Suppresses deprecation warnings either for implementations of our own
deprecated APIs or for their use in tests and elsewhere.

Part of #7537
2019-09-23 12:48:42 -04:00
featherless
97bb87866b [ActivityIndicator] Deprecate ColorThemer. (#8430)
Part of https://github.com/material-components/material-components-ios/issues/8429

These targets have no internal usage.

Note: CocoaPods is unfortunately not able to annotate subspecs as deprecated. It generates the following when you try:

```
ERROR | [iOS] attributes: Can't set `deprecated` attribute for subspecs (in `MaterialComponents/ActivityIndicator+ColorThemer`).
```
2019-09-10 11:22:15 -04:00
Wenyu Zhang
97dfca8003
[ActivityIndicator] Rewrite tests in ObjC to prevent the failing unit tests on iOS 13. (#8248)
Closes https://github.com/material-components/material-components-ios/issues/8239.

There is not a good way to directly fix it since it maybe a Xcode 11 beta issue related to swift-ObjC calls.
2019-08-08 17:24:27 -04:00
Robert Moore
ed55e0f1b2 [ActivityIndicator] Update BUILD to use Skylark macros. (#8153)
Updates the BUILD file to use as many Skylark macros as possible to make weekly releases easier.

Part of #8150
2019-08-01 18:42:56 +00:00
Robert Moore
8dcf1e4a56
[*] Remove RTL snapshot method overrides. (#7996)
With #7986, most snapshot tests began overriding a method that had nearly the
same behavior.
2019-07-22 21:11:17 -07:00
Cody Weaver
a0ee1f0ff1
[ActivityIndicator] Support dynamic color (#7950)
This change adds support for dynamic color within the MDCActivityIndicator.

Closes #7885
2019-07-17 15:13:32 -07:00
Cody Weaver
8275bcb858
[ActivityIndicator] Add traitCollectionDidChange block (#7931)
The activity indicator needs an API so clients can hook-in to trait collection changes. This additionally passes the activity indicator as a parameter so clients can modify the activity indicator within the block.

Closes #7928
2019-07-16 07:19:15 -07:00
featherless
e5c5762c74
[ActivityIndicator] Annotate all themer APIs with the recommended new APIs. (#7211)
Part of https://github.com/material-components/material-components-ios/issues/7108
2019-04-22 18:38:20 +03:00
Andrew Overton
c56d5d76d3
Add @objc annotations to get examples to show up in Dragons (#7168)
This is a follow up PR for #7166 adds @objc annotations to Swift catalogMetadata() methods, because the Swift 4 compiler no longer attempts to infer what methods should be visible to Objective-C. As a result of this change in the compiler, no Swift examples were showing up in Dragons after #7166. See this article: https://useyourloaf.com/blog/objc-warnings-upgrading-to-swift-4/ for additional context.
2019-04-17 21:35:43 -04:00
Andrew Overton
b38372192f
Update to Swift 4.2 (#7166)
This PR updates the Swift version to 4.2.

Partially resolves #6874.
2019-04-17 16:59:02 -04:00
Robert Moore
63f0da31e5
[ActivityIndicator] Deflake snapshot tests. (#6934)
Speeding up animations to try and stabilize the snapshot tests.

Closes #6924
2019-03-20 12:46:56 -04:00
Robert Moore
2e5df058e3
[ActivityIndicator] Add basic Snapshot tests (#6826)
Adding snapshot tests for determine progress in LTR and RTL. No visible
difference for RTL, which is probably expected.

Closes #6820
2019-03-11 21:36:58 -04:00
Yarden Eitan
c4d24627ee
updated jazzy yaml files to include framework root (#6750)
We have had errors when generating the docs using jazzy specifically around components giving a fatal error around not finding imports when depending on other components. This is because each component for jazzy is isolated and on its own unless we provide the framework root. This caused our website generator to crash each time and fail to generate a new website.

This should resolve this problem.

QA=
Before the fix when running the website generator we got these errors:
```
/material-components-ios/components/BottomAppBar/src/MDCBottomAppBarView.h:17:9: fatal error: 'MaterialButtons.h' file not found
building site
building search index
^C/Library/Ruby/Gems/2.3.0/gems/rouge-3.1.1/lib/rouge/lexer.rb:458:in `load': Interrupt
	from /Library/Ruby/Gems/2.3.0/gems/rouge-3.1.1/lib/rouge/lexer.rb:458:in `load_lexer'
	from /Library/Ruby/Gems/2.3.0/gems/rouge-3.1.1/lib/rouge.rb:50:in `block in <top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/rouge-3.1.1/lib/rouge.rb:49:in `each'
	from /Library/Ruby/Gems/2.3.0/gems/rouge-3.1.1/lib/rouge.rb:49:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/jazzy_markdown.rb:2:in `require'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/jazzy_markdown.rb:2:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/doc.rb:7:in `require'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/doc.rb:7:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/config.rb:5:in `require'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy/config.rb:5:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy.rb:1:in `require'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/lib/jazzy.rb:1:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/bin/jazzy:13:in `require'
	from /Library/Ruby/Gems/2.3.0/gems/jazzy-0.9.3/bin/jazzy:13:in `<top (required)>'
	from /usr/local/bin/jazzy:22:in `load'
	from /usr/local/bin/jazzy:22:in `<top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:74:in `load'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:74:in `kernel_load'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:28:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli.rb:463:in `exec'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli.rb:27:in `dispatch'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/cli.rb:18:in `start'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/exe/bundle:30:in `block in <top (required)>'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
	from /Library/Ruby/Gems/2.3.0/gems/bundler-2.0.1/exe/bundle:22:in `<top (required)>'
	from /usr/local/bin/bundle:22:in `load'
	from /usr/local/bin/bundle:22:in `<main>'
/material-components-site-generator/scripts/lib/reporter.js:36
      throw e;
      ^

Error: Command failed: bundle exec jazzy         --output "/material-components-site-generator/.stage/ios/catalog/bottomnavigation/api-docs/"         --theme "/material-components-site-generator/ios-api-docs-src/theme"         --head '/components'         --use-safe-filenames
    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at JazzyApiGenerator.build (/material-components-site-generator/scripts/lib/jazzy-api-generator.js:34:5)
    at PlatformSite.generateApiDocs (/material-components-site-generator/scripts/lib/platform-site.js:212:17)
    at platformSites.forEach (/material-components-site-generator/scripts/build:86:14)
    at Array.forEach (<anonymous>)
    at reporter.step (/material-components-site-generator/scripts/build:85:21)
    at Reporter.step (/material-components-site-generator/scripts/lib/reporter.js:32:22)
    at Object.<anonymous> (/material-components-site-generator/scripts/build:84:14)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3
```
Now we no longer get fatal errors or crash when running the script.
2019-03-01 16:52:02 -05:00
Yarden Eitan
71512ff72e reverting 2019-02-26 11:50:30 -05:00
Robert Moore
f1b5318d5e
[ColorScheme] Add test schemes. (#6690)
Adding test schemes useful for unit/snapshot tests where the baseline
scheme is insufficient (for example to verify bindings).
2019-02-22 09:43:42 -05:00
Robert Moore
800188a649
{clang-format} Format the components. (#6347)
This is a follow-up to https://github.com/material-components/material-components-ios/pull/6027

```
find components \( -name "*.h" -or -name "*.m" \) | xargs clang-format -i
```
2019-01-23 11:08:43 -05:00
Robert Moore
0f47c78819
[ActivityIndicator] Add Swift examples to bazel. (#6421) 2019-01-22 08:40:02 -05:00
Andrew Overton
bb4cde39a4
Add ActivityIndicator examples to BUILD file (#6318)
This PR adds ActivityIndicator examples to BUILD file.
Closes #6227.
2019-01-14 15:45:25 -05:00
Yarden Eitan
2803125b2c
ran clang-format (#6027) 2019-01-11 13:23:51 -05:00
Robert Moore
5b1943dd78
[bazel] Use mdc_extension_objc_library in BUILD (#6089)
Changing all component extension targets to use the new macro
`mdc_extension_objc_library` to reduce boilerplate in the target
definitions.
2018-12-20 17:14:19 -05:00
rami-a
c06e819835
[ActivityIndicator] Stop activity indicator animating when hidden (#6063)
### The problem
When a client hides an activity indicator, the animation would continue despite not being necessary

### The solution
Override `setHidden` and stop the animation when hidden is true.

### Bugs
Closes #5955
2018-12-20 14:46:11 -05:00