https://github.com/material-components/material-components-ios/pull/9711 causes the library to fail pod lib lint validations because there are currently no source files in the test spec. This will of course change very soon but in case there's a release before it does we should land this PR.
Related to #9407.
[BottomNavigation] Fix bug in delegate method call
The MDCBottomNavigationBarController checks the wrong delegate method before calling `-bottomNavigationBarController:shouldSelectViewController:`. This can lead to crashes in clients that do not implement this method, but implement `-bottomNavigationBarController:didSelectViewController:`.
Fixes#9483
## UPDATED PR DESCRIPTION:
**NOTE: [cl/290296411](http://cl/290296411) must be patched into whatever release includes this PR.**
There were requests to break it up further. With the latest changes, it will look like this in the future:
//components/TextControls:Shared # shared public types
//components/TextControls:BaseTextFields
//components/TextControls:FilledTextFields
//components/TextControls:FilledTextFieldsTheming
//components/TextControls:OutlinedTextFields
//components/TextControls:OutlinedTextFieldsTheming
//components/TextControls:BaseTextAreas
//components/TextControls:FilledTextAreas
//components/TextControls:FilledTextAreasTheming
//components/TextControls:OutlinedTextAreas
//components/TextControls:OutlinedTextAreasTheming
//components/TextControls:FilledInputChipView
//components/TextControls:FilledInputChipViewTheming
//components/TextControls:OutlinedInputChipView
//components/TextControls:OutlinedInputChipViewTheming
//components/private/TextControlsPrivate: Shared # shared private types
//components/private/TextControlsPrivate:OutlinedStyle
//components/private/TextControlsPrivate:FilledStyle
This would make it easier to sunset/retire a specific style of a specific text control type, for example.
## ORIGINAL PR DESCRIPTION:
This PR is an attempt to satisfy the recent requests to break up the Cocoapods subspecs and Bazel targets for TextControls.
~**NOTE: [cl/289710430](http://cl/289710430) must be patched into whatever release includes this PR.**~
**ANOTHER NOTE: This PR will break any third party people who depend on TextControls via Cocoapods and have not pinned to a specific version of our library.**
This PR takes the following Cocoapods subspecs:
TextControls
TextControls+Theming
And breaks them up into these ones:
TextControls
TextControls+TextFields
TextControls+TextFieldsTheming
private/TextControlsPrivate
Similarly, it takes the following bazel targets:
//components/TextControls
//components/TextControls:Theming
And breaks them up into these ones:
//components/TextControls
//components/TextControls:TextFields
//components/TextControls:TextFieldsTheming
//components/private/TextControlsPrivate
Where before a third party client would have had the following in their Podfile:
`pod 'MaterialComponents/TextControls'`
They would now have:
`pod 'MaterialComponents/TextControls+TextFields'`
When I started this work I originally planned to have there be top level components for each of the TextControls that all depended on a shared private component. However, I quickly remembered that all the text controls shared some public types too. At some point I decided it make make sense to make use of extensions.
In order to satisfy pod lib lint I had to add some dummy source files and dummy test files. The dummy test files could potentially have some stuff in there if we want to validate the enums they refer to somehow...
Closes#9405.