Test Plan:
Local client builds as expected.
Internal text clients build as expected.
Reviewers: O1 Material components iOS, ajsecord
Reviewed By: O1 Material components iOS, ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1487
Summary:
Include MaterialRTL as a dependency.
Explicitly note that the view is spatial and shouldn't be mirrored.
Test Plan:
Ran catalog in LTR mode, noted correct orientation.
Ran catalog in RTL mode, noted correct orientation.
Reviewers: junius, O1 Material components iOS, ajsecord
Reviewed By: O1 Material components iOS, ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1461
Test Plan:
./scripts/release/manage_pods.py update
Worked as expected.
Reviewers: randallli, O1 Material components iOS
Reviewed By: randallli, O1 Material components iOS
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1285
Summary:
Initial import of our modal presentation controller and transition controller.
The interfaces have been previously reviewed in our API Review process.
This will land on the branch feature-dialog.
Test Plan: Example added to catalog.
Reviewers: randallli, cjcox, ajsecord, O1 Material components iOS
Reviewed By: ajsecord, O1 Material components iOS
Subscribers: samnm, randallli
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1066
Summary:
Adds a ProgressView component. It displays determinate progress linearly.
Note: the README.md and API has previously been reviewed. Feel free to leave comments, but you can also skip for this review and focus on the implementation.
Test Plan: - Open Catalog > Progress View and verify looks.
Reviewers: randallli, junius, iangordon, O1 Material components iOS, ajsecord
Reviewed By: O1 Material components iOS, ajsecord
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1103
Summary:
Adds Snackbar and related Overlay Window component as well as demos for MDCCatalog. The Overlay component, of which Snackbar depends, is private for the time being.
- Removed dependencies on internal core.
- Removed i18n string translation, TODO added to replace.
- Removed RTL, waiting on https://github.com/google/material-components-ios/issues/579
- Animation curve constants moved inline.
- Fixed styling to be the material standard instead of configurable.
Reviewers: ajsecord, O1 Material components iOS
Reviewed By: ajsecord, O1 Material components iOS
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1036
Summary:
Cells are now laid out accordingly to their layoutDirection property.
The default value matches the common support across SDKs and OS at runtime.
Closes https://github.com/google/material-components-ios/issues/567
Test Plan:
Set the device or simulator to use an RTL language.
On iOS 9, the UI must be flipped.
On prior OS, the UI is not flipped.
Reviewers: cjcox, iangordon, O1 Material components iOS
Reviewed By: cjcox, iangordon, O1 Material components iOS
Subscribers: brianjmoore
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D962
Summary:
The rendering mode is lost when an image is flipped with
-[UIImage imageWithCGImage:scale:orientation:].
When that would happen, actually render the image with it's orientation and
scale, port the template mode, and return that copy.
Closes https://github.com/google/material-components-ios/issues/592.
Test Plan:
Check that back arrow in Catalog is correctly flipped relative to the layout
direction.
Reviewers: randallli, O1 Material components iOS, iangordon
Reviewed By: randallli, O1 Material components iOS, iangordon
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D1034
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
- [ ] I did not `arc land` this change because I followed the [releasing guide](https://github.com/google/material-components-ios/blob/develop/contributing/contributor_guides/releasing.md) and did the following:
- [ ] Ran `scripts/release/merge`
- [ ] Push to master
- [ ] Push to develop
- [ ] Manually marked this diff closed in the web ui
Reviewers: O1 Material components iOS!
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D925
Summary:
DO NOT LAND until after we have finalized our May 25 2016 release.
Cocoapods 1.0.0 was used to generate Pod* and xcode* files.
These changes are NOT compatible with 0.39.0.
These changes may NOT be compatible with version of Xcode 7.2 and earlier.
pod lib lint generates a list of issues that should be addressed.
--OLD INFO--
Cocoapods 0.39 was used to generate the Podfile.locks.
MaterialComponents - Build properly
MaterialUnitTests - Test properly
MaterialCatalog - Fails to Build
The errors (cut after the first 20) are similar to:
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "Headers/MaterialComponentsCatalog-umbrella.h"
^
/Users/iangordon/projects/material-components-ios/catalog/Pods/Target Support Files/MaterialComponentsCatalog/MaterialComponentsCatalog-umbrella.h:10:9: note: in file included from /Users/iangordon/projects/material-components-ios/catalog/Pods/Target Support Files/MaterialComponentsCatalog/MaterialComponentsCatalog-umbrella.h:10:
#import "CollectionCellsLayoutExample.h"
....
Reviewers: featherless, randallli, ajsecord, #material_components_ios
Reviewed By: featherless, randallli, ajsecord, #material_components_ios
Tags: #material_components_ios
Differential Revision: http://codereview.cc/D873
Summary:
Checklist:
- [ ] Ran `arc unit --everything`.
- [ ] Ran `scripts/build_all_pod_projects`.
- [ ] Ran `scripts/release/api_diff` and pasted the results into CHANGELOG.md.
- [ ] Ran `scripts/release/changes` and pasted the results into CHANGELOG.md.
- [ ] Visually inspected the API diff to ensure it accurately reflects the release's changes.
- [ ] Ran `scripts/release/diff components/*/src/` and visually inspected the changes.
- [ ] Ran `scripts/release/bump` with the new version number.
- [ ] Updated CHANGELOG.md's latest section header to match the release's version number.
Reviewers: ajsecord, #mdc_ios_owners
Reviewed By: ajsecord, #mdc_ios_owners
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D860
Summary:
Merging feature-palettes into develop. This is the combination of the following reviews with no further changes:
http://codereview.cc/D818http://codereview.cc/D827http://codereview.cc/D842
Reviewers: #mdc_ios_owners, featherless
Reviewed By: #mdc_ios_owners, featherless
Subscribers: larche, lpromero, cjcox, featherless, mrefaat, jsachse
Projects: #material_components_ios
Differential Revision: http://codereview.cc/D852
