14 Commits

Author SHA1 Message Date
featherless
d7e126772d
[kokoro] Extract more of the clang-format logic out to clang-format-ci. (#5722)
This will make it easier for us to keep all google-owned repositories running the same clang-format version in tandem.

Also moved from a submodule to a clone + version checkout so that our CI gracefully upgrades as we release new non-breaking release to clang-format-ci.

Relies on upstream changes in https://github.com/material-foundation/clang-format-ci/pull/4
2018-11-19 22:09:50 -05:00
featherless
d26fce134b
[kokoro] Migrate github-comment and clang-format-ci to the material-foundation repos. (#5707)
## Context

Two libraries have graduated from the material-components-ios repo so that they can be used more generally across other open source projects: [clang-format-ci](https://github.com/material-foundation/clang-format-ci) and [github-comment](https://github.com/material-foundation/github-comment).

## What's going on here

Both of these libraries have been added as external submodule dependencies and the scripts have been updated to refer to the new external dependency paths.
2018-11-09 07:15:46 -05:00
featherless
e27de3143b
[Catalog] Remove EarlGrey tests. (#4378)
We have not increased our investment in EarlGrey. We will instead likely start investing in standard UI tests once UI testing (with hosted apps) is more stable on kokoro.
2018-06-07 11:38:50 -04:00
Adrian Secord
4216607d49 Updated submodule paths from SSH to HTTPS. 2016-12-15 14:22:15 -05:00
Adrian Secord
ab02de5a07 Removing unused submodules from .gitignore. 2016-12-15 14:18:09 -05:00
Louis Romero
c822d3c2e0 Remove the dependency on the earlgrey gem. (#952)
* Remove the dependency on the earlgrey gem.

This commit adds EarlGrey as a submodule. It brings the script traditionally
used via the gem. It also init-updates the submodules prior to using the
script in the post_install hook.

This concerns
https://github.com/material-components/material-components-ios/issues/867

* Remove EarlGrey

* Add it again

* Update script path

* Fix issue where the Podfile was valid only from the root of the repo.

* Only update the EarlGrey submodule
2016-12-09 07:47:45 -05:00
Justin Shephard
26819f760d Updates to API Diff Process (#848)
* release-candidate - Updated indentation for api_diff script

* API_Diff - Removed references to obj_diff, added source kitten install script

* API_Diff - Added material motion api_diff submodule

* API_Diff - Added conditional for Ink and Snackbar to be diff'd manually

* API_DIff - Updated api diff tool sha
2016-11-09 17:08:48 -05:00
Jeff Verkoeyen
9daf41777c Revert "Use https urls for git repos rather than ssh."
This reverts commit a2f34b35d411dc03862f799e328d1f4026714739.
2016-06-10 00:09:48 -04:00
Jeff Verkoeyen
a2f34b35d4 Use https urls for git repos rather than ssh.
Summary: Allows contributors to check out submodules without having ssh keys set up in GitHub.

Reviewers: O1 Material components iOS, ajsecord

Reviewed By: O1 Material components iOS, ajsecord

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D928
2016-06-10 00:08:55 -04:00
Jeff Verkoeyen
db7c9da1e9 Add regex-line-length-lint.
Summary: This linter is able to ignore lines that match certain regexes, lowering our rate of linter false-positives.

Reviewers: ajsecord, #mdc_ios_owners

Reviewed By: ajsecord, #mdc_ios_owners

Subscribers: iangordon

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D477
2016-04-12 09:55:55 -04:00
Jeff Verkoeyen
c4601975fb Add Jazzy linter v1.0.0.
Summary:
Example output:

```
>>> Lint for components/ShadowLayer/src/MDCShadowLayer.h:

   Warning  (JAZZY1) Missing documentation
    topShadowRadius is missing documentation.
    Please use `/** */` blocks to document APIs.

              23  spec.
              24  */
              25 @interface MDCShadowMetrics : NSObject
    >>>       26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;

   Warning  (JAZZY1) Missing documentation
    topShadowOffset is missing documentation.
    Please use `/** */` blocks to document APIs.

              24  */
              25 @interface MDCShadowMetrics : NSObject
              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
    >>>       27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;

   Warning  (JAZZY1) Missing documentation
    topShadowOpacity is missing documentation.
    Please use `/** */` blocks to document APIs.

              25 @interface MDCShadowMetrics : NSObject
              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
    >>>       28 @property(nonatomic, readonly) float topShadowOpacity;
              29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;
              31 @property(nonatomic, readonly) float bottomShadowOpacity;

   Warning  (JAZZY1) Missing documentation
    bottomShadowRadius is missing documentation.
    Please use `/** */` blocks to document APIs.

              26 @property(nonatomic, readonly) CGFloat topShadowRadius;
              27 @property(nonatomic, readonly) CGSize topShadowOffset;
              28 @property(nonatomic, readonly) float topShadowOpacity;
    >>>       29 @property(nonatomic, readonly) CGFloat bottomShadowRadius;
              30 @property(nonatomic, readonly) CGSize bottomShadowOffset;
              31 @property(nonatomic, readonly) float bottomShadowOpacity;
              32
```

Reviewers: #mdc_ios_owners, randallli

Reviewed By: #mdc_ios_owners, randallli

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D211
2016-04-11 17:38:09 -04:00
Jeff Verkoeyen
ad904b8748 Use the correct proselint url.
Reviewers: #mdc_ios_owners, iangordon

Reviewed By: #mdc_ios_owners, iangordon

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D495
2016-04-06 12:31:19 -04:00
Jeff Verkoeyen
6bb73753fb Add proselint linter.
Summary:
arc-proselint linter: https://github.com/google/arc-proselint
proselint the tool: http://proselint.com/

Proselint is a linter for written text, specifically English. This diff enables it for our markdown files.

How to install proselint:

    pip install proselint

Reviewers: ajsecord, #mdc_ios_owners

Reviewed By: ajsecord, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D491
2016-04-06 12:22:27 -04:00
Adrian Secord
df8b4ddb50 Updated Arcanist config to use submodules.
Summary:
Added arc-xcode-test-engine and clang-format-linter as submodules.
Updated .arcconfig to point to submodules.

NOTE: Until scripts/install_arc.sh is landed, arc users will need to run
```
git submodule init
git submodule update
```
to pull in arc's extensions as submodules.

Reviewers: featherless, #mdc_ios_owners

Reviewed By: featherless, #mdc_ios_owners

Projects: #material_components_ios

Differential Revision: http://codereview.cc/D287
2016-03-17 12:33:28 -04:00