conradchen 413a047957 [ChipGroup] Fix ChipGroup.getCheckedChipIds() returns wrong state
In the Chip implementation, onCheckedChangeListener was called before onCheckedChangeListenerInternal. This causes an issue that in onCheckedChangeListener's callback, the checkable group's checked state is not updated yet, therefore ChipGroup.getCheckedChipIds() will return the outdated checked state.

Fixes this by overriding Chip.setOnCheckedChangeListener to get full control of the execution order between onCheckedChangeListener and onCheckedChangeListenerInternal.

Resolves https://github.com/material-components/material-components-android/issues/2691

PiperOrigin-RevId: 449100861
2022-05-17 11:04:03 -04:00

54 lines
1.7 KiB
Java

/*
* Copyright (C) 2015 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.android.material.internal;
import com.google.android.material.R;
import android.os.Bundle;
import android.os.Parcel;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.internal.DoNotInstrument;
/** test for {@link ParcelableSparseArray} */
@RunWith(RobolectricTestRunner.class)
@DoNotInstrument
public class ParcelableSparseArrayTest {
private static final String TEST_KEY = "TEST_KEY";
private static final char TEST_CHAR = 'C';
@Test
public void testArray() {
ParcelableSparseArray array = new ParcelableSparseArray();
Bundle bundle = new Bundle();
bundle.putChar(TEST_KEY, TEST_CHAR);
array.append(0, bundle);
Parcel parcel = Parcel.obtain();
array.writeToParcel(parcel, array.describeContents());
parcel.setDataPosition(0);
ParcelableSparseArray createdFromParcel =
ParcelableSparseArray.CREATOR.createFromParcel(parcel);
Bundle first = (Bundle) createdFromParcel.get(0);
Assert.assertEquals(TEST_CHAR, first.getChar(TEST_KEY));
}
}