flutter_flutter/engine/core/dom/RenderTreeBuilder.h
Elliott Sprehn 059ceb6e3f Remove the remaining parts of ignorePendingStylesheets and placeholder styles.
This patch is largely just a rename since updateLayoutIgnorePendingStylesheets()
didn't really do anything except call updateLayout() now as nothing was reading
the ignorePendingStyleSheets state, and no callers used the synchronous post
layout task option which was meant for plugins (which Sky doesn't have).

Placeholder styles were related and just add confusion since things pretend to
be display: none while <import>'s are loading. We should expose a real API for
avoiding FOUC instead of pumping frames with display: none elements when
imports are loading.

I had to skip the layout/continuations.sky test since it always crashes now
with an ASSERT failure about a bad cast (filed as bug 446739). The bug already
existed, this patch just makes that one test hit it.

BUG=446739
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/834693007
2015-01-07 10:54:41 -08:00

74 lines
2.4 KiB
C++

/*
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
* (C) 1999 Antti Koivisto (koivisto@kde.org)
* (C) 2001 Dirk Mueller (mueller@kde.org)
* Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
* Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
* Copyright (C) 2011 Google Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public License
* along with this library; see the file COPYING.LIB. If not, write to
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*
*/
#ifndef SKY_ENGINE_CORE_DOM_RENDERTREEBUILDER_H_
#define SKY_ENGINE_CORE_DOM_RENDERTREEBUILDER_H_
#include "sky/engine/core/dom/Document.h"
#include "sky/engine/core/dom/Node.h"
#include "sky/engine/core/dom/NodeRenderingTraversal.h"
#include "sky/engine/wtf/RefPtr.h"
namespace blink {
class ContainerNode;
class RenderObject;
class RenderStyle;
class RenderTreeBuilder {
STACK_ALLOCATED();
public:
RenderTreeBuilder(Node* node, RenderStyle* style)
: m_node(node)
, m_renderingParent(nullptr)
, m_style(style)
{
ASSERT(!node->renderer());
ASSERT(node->needsAttach());
ASSERT(node->document().inStyleRecalc());
ASSERT(node->inActiveDocument());
m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetails);
}
void createRendererForTextIfNeeded();
void createRendererForElementIfNeeded();
private:
RenderObject* parentRenderer() const;
RenderObject* nextRenderer() const;
bool shouldCreateRenderer() const;
RenderStyle& style() const;
RawPtr<Node> m_node;
RawPtr<ContainerNode> m_renderingParent;
NodeRenderingTraversal::ParentDetails m_parentDetails;
mutable RefPtr<RenderStyle> m_style;
};
} // namespace blink
#endif // SKY_ENGINE_CORE_DOM_RENDERTREEBUILDER_H_