DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/engine
History
flutteractionsbot fec1efd104
[CP-stable][Impeller] Terminate the fence waiter but do not reset it during ContextVK shutdown (#174647) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/171691

### Changelog Description:

Fixes a race that can cause crashes in the Impeller Vulkan back end.

### Impact Description:

Crashes in apps running on Impeller/Vulkan.

### Workaround:

Disable Impeller

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:

The crash does not happen consistently.  One way that I have been able to reproduce it is:
* run Gallery with Impeller/Vulkan on a slow phone
* scroll through the Shrine screen and start a lot of image decodes
* quickly exit the app before the decodes have completed

Without the fix, the app will often crash if an image decode tries to access the Vulkan context after it was partially shut down while exiting the app.
2025-08-28 17:41:54 +00:00
..
scripts
…
src
[CP-stable][Impeller] Terminate the fence waiter but do not reset it during ContextVK shutdown (#174647)
2025-08-28 17:41:54 +00:00
README.md
…

README.md

Flutter Engine

Setting up the Engine development environment

See here

gclient bootstrap

Flutter engine uses gclient to manage dependencies.

If you've already cloned the flutter repository:

  1. Copy one of the engine/scripts/*.gclient to the root folder as .gclient:
    1. Googlers: copy rbe.gclient to enable faster builds with RBE
    2. Everyone else: copy standard.gclient
  2. run gclient sync from the root folder