DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/packages/flutter/lib/src/material
History
Bruno Leroux 0b3ba809cc
Revert "Fix NavigationBar indicator overlay color (#164484)" (#169497) 
## Description

This PR reverts the change from [Fix NavigationBar indicator overlay
color](https://github.com/flutter/flutter/pull/164484) as it leads to
several regressions.

The change was very small: replacing a Container (which obscured the
overlay) with an Ink. Unfortunately this leads to some rendering issues
which seem related to the Ink painting not being fully in sync with the
animation logic implemented by `NavigationIndicator`.
I investigated this but did not find an obvious solution. So I would
prefer to revert https://github.com/flutter/flutter/pull/164484 as the
issue it fixed has less impact than the regression.
cc @justinmc for review and also in case you have some clue about why an
Ink would cause such problems compared to a Container.

## Related Issue

Fixes [[Flutter 3.32.0] Active NavigationBar item not selected when
switching items
programmatically](https://github.com/flutter/flutter/issues/169249)
Fixes [NavigationDrawer active indicator offset with
SvgPicture](https://github.com/flutter/flutter/issues/169436)
Fixes
https://github.com/flutter/flutter/pull/164484#issuecomment-2910505630

Reopens https://github.com/flutter/flutter/issues/163871
2025-06-02 08:00:46 +00:00
..
animated_icons
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
shaders
…
about.dart
Replace MediaQuery.sizeOf with heightOf and widthOf. (#168479)
2025-05-07 18:12:26 +00:00
action_buttons.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
action_chip.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
action_icons_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
adaptive_text_selection_toolbar.dart
Context menu button callback docs clarification (#161451)
2025-01-13 19:27:17 +00:00
animated_icons.dart
…
app_bar_theme.dart
fix: appbar leading width is not square for custom toolbar height (#161880)
2025-01-29 05:32:53 +00:00
app_bar.dart
Feat: Add full screen dialog support for dialog routes (#167794)
2025-05-21 18:28:23 +00:00
app.dart
[Widget Inspector] Fix missing cupertino icon in on-device inspector (#168847)
2025-05-15 19:55:21 +00:00
arc.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
autocomplete.dart
Autocomplete keyboard navigation (#159455)
2025-01-23 18:48:41 +00:00
back_button.dart
…
badge_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
badge.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
banner_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
banner.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
bottom_app_bar_theme.dart
Normalize BottomAppBarTheme (#168586)
2025-05-14 17:38:18 +00:00
bottom_app_bar.dart
Normalize BottomAppBarTheme (#168586)
2025-05-14 17:38:18 +00:00
bottom_navigation_bar_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
bottom_navigation_bar.dart
Replace SizedBox spacing with spacing parameter in Row usages (#168688)
2025-05-16 14:31:20 +00:00
bottom_sheet_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
bottom_sheet.dart
showDialogs adds a requestFocus parameter. (#162928)
2025-02-20 03:01:07 +00:00
button_bar_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
button_bar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
button_style_button.dart
fix: outline appearing over child (#167615)
2025-04-30 23:46:11 +00:00
button_style.dart
Update ButtonStyle documentation (#168062)
2025-05-22 09:32:20 +00:00
button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
button.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
calendar_date_picker.dart
modify toggle mode style with DatePickerTheme (#164102)
2025-04-11 19:38:16 +00:00
card_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
card.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
carousel_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
carousel.dart
Fix CarouselView.weighted crashes when initlal viewportDimension is 0.0 (#167628)
2025-04-28 09:22:40 +00:00
checkbox_list_tile.dart
Add titleAlignment to CheckboxListTile and RadioListTile (#168666)
2025-05-14 02:07:34 +00:00
checkbox_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
checkbox.dart
Fix Checkbox default visual density to meet Material 3 guidelines (#159081)
2025-01-30 20:03:56 +00:00
chip_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
chip.dart
Fix Chip delete button semantic bounds (#168310)
2025-05-16 22:39:54 +00:00
choice_chip.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
circle_avatar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
color_scheme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
colors.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
constants.dart
…
curves.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
data_table_source.dart
…
data_table_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
data_table.dart
[a11y] add SemanticsValidationResult (#165935)
2025-04-02 22:00:19 +00:00
date_picker_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
date_picker.dart
Respect calendarDelegate in showDateRangePicker (#168290)
2025-05-21 21:28:29 +00:00
date.dart
Added calendar delegate to support custom calendar systems (#161874)
2025-03-08 02:41:17 +00:00
debug.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
desktop_text_selection_toolbar_button.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
desktop_text_selection_toolbar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
desktop_text_selection.dart
Replace MediaQuery.sizeOf with heightOf and widthOf. (#168479)
2025-05-07 18:12:26 +00:00
dialog_theme.dart
Tab bar theme and dialog theme documentation cleanup (#168724)
2025-05-13 12:28:27 +00:00
dialog.dart
Feat: Add full screen dialog support for dialog routes (#167794)
2025-05-21 18:28:23 +00:00
divider_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
divider.dart
Add styling parameters in PopupMenuDivider (#164790)
2025-04-03 00:33:58 +00:00
drawer_header.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
drawer_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
drawer.dart
Make the barrier panel on the Material Drawer non-dismissible (#164810)
2025-05-12 23:37:28 +00:00
dropdown_menu_form_field.dart
Add DropdownMenuFormField (#163721)
2025-05-02 19:41:10 +00:00
dropdown_menu_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
dropdown_menu.dart
Fix the issue where DropdownMenu disposes of the controller. (#168541)
2025-05-22 04:26:06 +00:00
dropdown.dart
Fix DropdownButtonFormField icon not vertically centered (#163205)
2025-05-12 21:30:47 +00:00
elevated_button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
elevated_button.dart
Replace SizedBox spacing with spacing parameter in Row usages (#168688)
2025-05-16 14:31:20 +00:00
elevation_overlay.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
expand_icon.dart
Migrate to Theme.brightnessOf method (#163950)
2025-04-03 00:34:53 +00:00
expansion_panel.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
expansion_tile_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
expansion_tile.dart
Implement CupertinoCollapsible/CupertinoExpansionTile (#165606)
2025-05-01 21:47:22 +00:00
filled_button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
filled_button.dart
Replace SizedBox spacing with spacing parameter in Row usages (#168688)
2025-05-16 14:31:20 +00:00
filter_chip.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
flexible_space_bar.dart
apply dart_style 3.0.1 (#160875)
2024-12-27 00:06:41 +00:00
floating_action_button_location.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
floating_action_button_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
floating_action_button.dart
[Widget Inspector] Clean-up changes in PR #167677 (#168488)
2025-05-08 22:54:18 +00:00
grid_tile_bar.dart
…
grid_tile.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
icon_button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
icon_button.dart
Migrate to Theme.brightnessOf method (#163950)
2025-04-03 00:34:53 +00:00
icons.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
ink_decoration.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
ink_highlight.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
ink_ripple.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
ink_sparkle.dart
[web] Remove HTML renderer from framework tests (#162038)
2025-01-24 21:33:27 +00:00
ink_splash.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
ink_well.dart
Add documentation for the secondary button (#164555)
2025-03-18 08:11:20 +00:00
input_border.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
input_chip.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
input_date_picker_form_field.dart
Added calendar delegate to support custom calendar systems (#161874)
2025-03-08 02:41:17 +00:00
input_decorator.dart
Reverts "Use live region in error text input decorator for Android (#165531)" (#168848)
2025-05-14 17:47:38 +00:00
list_tile_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
list_tile.dart
Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (#168480)
2025-05-09 17:23:34 +00:00
magnifier.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
material_button.dart
Api docs: Add FilledButton to list of recommended material buttons (#167096)
2025-04-23 21:50:54 +00:00
material_localizations.dart
Removed not working hyperlinks to ScriptCategory values (#165395)
2025-03-27 18:47:48 +00:00
material_state_mixin.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
material_state.dart
docs: Fixed broken links in WidgetStateProperty documentations (#168191)
2025-05-07 18:36:08 +00:00
material.dart
Feat: Animate fill for material app bar (#163913)
2025-05-07 16:52:38 +00:00
menu_anchor.dart
Revert "Wire up MenuAnchor, MenuBar, MenuItem-related widgets to aria roles (#165596)" (#168339)
2025-05-05 23:57:33 +00:00
menu_bar_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
menu_button_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
menu_style.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
menu_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
mergeable_material.dart
Clean up leak tracker instrumentation tech debt. (#164070)
2025-02-25 23:18:53 +00:00
motion.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
navigation_bar_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
navigation_bar.dart
Revert "Fix NavigationBar indicator overlay color (#164484)" (#169497)
2025-06-02 08:00:46 +00:00
navigation_drawer_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
navigation_drawer.dart
Add header and footer support to NavigationDrawer (#168005)
2025-05-29 20:33:26 +00:00
navigation_rail_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
navigation_rail.dart
Fix NavigationRail examples overflow alignment (#159937)
2025-01-31 15:29:25 +00:00
no_splash.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
outlined_button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
outlined_button.dart
Replace SizedBox spacing with spacing parameter in Row usages (#168688)
2025-05-16 14:31:20 +00:00
page_transitions_theme.dart
Shared element transition for predictive back (#154718)
2025-05-19 22:06:58 +00:00
page.dart
Wire up the system text scaler from PlatformDispatcher (#159999)
2025-05-13 23:52:05 +00:00
paginated_data_table.dart
Fix arrowHeadColor breaks differentiation between states (#165178)
2025-03-17 17:00:05 +00:00
popup_menu_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
popup_menu.dart
[Widget Inspector] Clean-up changes in PR #167677 (#168488)
2025-05-08 22:54:18 +00:00
predictive_back_page_transitions_builder.dart
Shared element transition for predictive back (#154718)
2025-05-19 22:06:58 +00:00
progress_indicator_theme.dart
Update year2023 flag deprecation message (#162607)
2025-02-04 19:21:06 +00:00
progress_indicator.dart
fix(CircularProgressIndicator.adaptive): strokeWidth default value (#165370)
2025-04-17 03:56:17 +00:00
radio_list_tile.dart
Add titleAlignment to CheckboxListTile and RadioListTile (#168666)
2025-05-14 02:07:34 +00:00
radio_theme.dart
Refactor more logic from radio and cupertino radio (#167764)
2025-04-30 23:51:53 +00:00
radio.dart
Refactor more logic from radio and cupertino radio (#167764)
2025-04-30 23:51:53 +00:00
range_slider_parts.dart
Removes unnecessary parentheses (#169015)
2025-05-23 00:02:01 +00:00
range_slider.dart
Update the RangeSlider widget to the 2024 Material Design appearance (#163736)
2025-05-19 17:10:12 +00:00
refresh_indicator.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
reorderable_list.dart
feat: Change default value of keyboardDismissBehavior (#158580)
2025-01-15 21:17:29 +00:00
scaffold.dart
Add bottomSheetScrimBuilder to Scaffold (#167335)
2025-05-22 04:26:06 +00:00
scrollbar_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
scrollbar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
search_anchor.dart
[Widget Inspector] Clean-up changes in PR #167677 (#168488)
2025-05-08 22:54:18 +00:00
search_bar_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
search_view_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
search.dart
Relands "backfill custom painter semantics properties (#166375)" (#168113)
2025-05-01 18:15:49 +00:00
segmented_button_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
segmented_button.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
selectable_text.dart
Don't show SystemContextMenu for SelectableText (#169238)
2025-05-30 00:13:53 +00:00
selection_area.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
shadows.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
slider_parts.dart
Refactor: Move Slider and RangeSlider components to slider_parts.dart and range_slider_parts.dart (#165361)
2025-04-29 20:35:13 +00:00
slider_theme.dart
Update the RangeSlider widget to the 2024 Material Design appearance (#163736)
2025-05-19 17:10:12 +00:00
slider_value_indicator_shape.dart
Refactor: Move Slider and RangeSlider components to slider_parts.dart and range_slider_parts.dart (#165361)
2025-04-29 20:35:13 +00:00
slider.dart
docs: Update deprecation message for Slider.year2023 (#169053)
2025-05-19 07:06:07 +00:00
snack_bar_theme.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
snack_bar.dart
Replace MediaQuery.sizeOf with heightOf and widthOf. (#168479)
2025-05-07 18:12:26 +00:00
spell_check_suggestions_toolbar_layout_delegate.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
spell_check_suggestions_toolbar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
stepper.dart
Migrate to Theme.brightnessOf method (#163950)
2025-04-03 00:34:53 +00:00
switch_list_tile.dart
feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (#166820)
2025-05-06 05:25:32 +00:00
switch_theme.dart
[Widget Inspector] Clean-up changes in PR #167677 (#168488)
2025-05-08 22:54:18 +00:00
switch.dart
feat(Switch): Add activeThumbColor and deprecate activeColor. (#166382)
2025-04-30 18:43:49 +00:00
tab_bar_theme.dart
Tab bar theme and dialog theme documentation cleanup (#168724)
2025-05-13 12:28:27 +00:00
tab_controller.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
tab_indicator.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
tabs.dart
Fixes tab semantics gets dropped if the child produce a semantics node (#169233)
2025-05-22 21:06:03 +00:00
text_button_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
text_button.dart
Replace SizedBox spacing with spacing parameter in Row usages (#168688)
2025-05-16 14:31:20 +00:00
text_field.dart
Fix selection handles showing when using a mouse (#168751)
2025-05-15 22:13:16 +00:00
text_form_field.dart
Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (#163491)
2025-05-09 23:09:06 +00:00
text_selection_theme.dart
fix(ios): correctly inherits the handle color from the theme (#166507)
2025-05-01 20:03:39 +00:00
text_selection_toolbar_text_button.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
text_selection_toolbar.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
text_selection.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
text_theme.dart
Adds support for applying delta/factor transformations for TextTheme height, letter and word spacing (#158103)
2025-02-21 18:40:05 +00:00
theme_data.dart
Normalize BottomAppBarTheme (continue) (#168966)
2025-05-21 22:14:16 +00:00
theme.dart
Wire up the system text scaler from PlatformDispatcher (#159999)
2025-05-13 23:52:05 +00:00
time_picker_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
time_picker.dart
[Widget Inspector] Clean-up changes in PR #167677 (#168488)
2025-05-08 22:54:18 +00:00
time.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
toggle_buttons_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
toggle_buttons.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
tooltip_theme.dart
Homogenize themes documentation (#168808)
2025-05-15 21:57:52 +00:00
tooltip_visibility.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00
tooltip.dart
Fix the issue with Tooltip (#168546)
2025-05-20 20:23:07 +00:00
typography.dart
Removed not working hyperlinks to ScriptCategory values (#165395)
2025-03-27 18:47:48 +00:00
user_accounts_drawer_header.dart
Auto-format Framework (#160545)
2024-12-19 20:06:21 +00:00