mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
4119c700ac
## Description This PR fixes a crash in the macOS text input plugin that occurs when `NSAttributedString` is passed to the `insertText:replacementRange:` method instead of `NSString`. ### Root Cause The `insertText:replacementRange:` method of `NSTextInputClient` protocol can receive either `NSString` or `NSAttributedString`. The previous implementation directly called `UTF8String` on the input parameter without type checking. Since `NSAttributedString` doesn't respond to the `UTF8String` selector, this caused a crash with the error: -[NSConcreteMutableAttributedString UTF8String]: unrecognized selector sent to instance ### Changes Made - Added type checking to determine if the input is `NSAttributedString` - Extract the underlying `NSString` using `[string string]` before calling `UTF8String` - This follows the same pattern already implemented in the `setMarkedText:selectedRange:replacementRange:` method in the same file ### Crash Stack Trace Thread 0 Crashed: 0 CoreFoundation __exceptionPreprocess 1 libobjc.A.dylib objc_exception_throw 2 CoreFoundation -[NSObject(NSObject) doesNotRecognizeSelector:] 3 FlutterMacOS -[FlutterTextInputPlugin insertText:replacementRange:] (FlutterTextInputPlugin.mm:784) 4 AppKit -[NSTextInputContext(NSInputContext_WithCompletion) insertText:replacementRange:completionHandler:] ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Kim Ki Cheol <kim.kicheol@sk.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>