mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
This is actually a backport of the following Blink change https://src.chromium.org/viewvc/blink?view=rev&revision=185426. New scope types introduced by ES6 features are not yes supported by DevTools and should just be ignored by the debugger. ScriptScope that caused troubles in this particular case was supported in V8 debugger quite recently (https://codereview.chromium.org/726643002). This fixes following crash on pause in Sky: #0 0x00007f8a39cffe1b in blink::TypeBuilder::Debugger::Scope::Type::assertCorrectValue (value=0xd98ce760450) at gen/sky/core/InspectorTypeBuilder.cpp:596 #1 0x00007f8a39d00072 in blink::TypeBuilder::Debugger::Scope::assertCorrectValue (value=0xd98ce658898) at gen/sky/core/InspectorTypeBuilder.cpp:610 #2 0x00007f8a39d033c5 in blink::TypeBuilder::StructItemTraits::assertCorrectValue<blink::TypeBuilder::Debugger::Scope> (value=0xd98ce658898) at gen/sky/core/InspectorTypeBuilder.h:160 #3 0x00007f8a39d02f71 in blink::TypeBuilder::Array<blink::TypeBuilder::Debugger::Scope>::assertCorrectValue (value=0xd98ce60af00) at gen/sky/core/InspectorTypeBuilder.h:139 #4 0x00007f8a39cffaaf in blink::TypeBuilder::Debugger::CallFrame::assertCorrectValue (value=0xd98ce658420) at gen/sky/core/InspectorTypeBuilder.cpp:569 #5 0x00007f8a3a753435 in blink::TypeBuilder::StructItemTraits::assertCorrectValue<blink::TypeBuilder::Debugger::CallFrame> (value=0xd98ce658420) at gen/sky/core/InspectorTypeBuilder.h:160 #6 0x00007f8a3a753371 in blink::TypeBuilder::Array<blink::TypeBuilder::Debugger::CallFrame>::assertCorrectValue (value=0xd98ce60af50) at gen/sky/core/InspectorTypeBuilder.h:139 #7 0x00007f8a3a752fa6 in blink::TypeBuilder::Array<blink::TypeBuilder::Debugger::CallFrame>::runtimeCast (value=...) at gen/sky/core/InspectorTypeBuilder.h:121 #8 0x00007f8a3a751e8c in blink::InjectedScript::wrapCallFrames (this=0x7f8a5560d988, callFrames=..., asyncOrdinal=0) at ../../sky/engine/core/inspector/InjectedScript.cpp:261 #9 0x00007f8a3a765350 in blink::InspectorDebuggerAgent::currentCallFrames (this=0xd98ce689410) at ../../sky/engine/core/inspector/InspectorDebuggerAgent.cpp:1149 #10 0x00007f8a3a76ae84 in blink::InspectorDebuggerAgent::didPause (this=0xd98ce689410, scriptState=0xd98ce670170, callFrames=..., exception=..., hitBreakpoints=...) at ../../sky/engine/core/inspector/InspectorDebuggerAgent.cpp:1354 #11 0x00007f8a3a76b0b7 in non-virtual thunk to blink::InspectorDebuggerAgent::didPause(blink::ScriptState*, blink::ScriptValue const&, blink::ScriptValue const&, WTF::Vector<WTF::String, 0ul, WTF::DefaultAllocator> const&) () at ../../sky/engine/core/inspector/InspectorDebuggerAgent.cpp:1368 #12 0x00007f8a399dae78 in blink::ScriptDebugServer::handleProgramBreak (this=0x7f8a441c5070, pausedScriptState=0xd98ce670170, executionState=..., exception=..., hitBreakpointNumbers=...) at ../../sky/engine/bindings/core/v8/ScriptDebugServer.cpp:449 #13 0x00007f8a399dbaa8 in blink::ScriptDebugServer::handleV8DebugEvent (this=0x7f8a441c5070, eventDetails=...) at ../../sky/engine/bindings/core/v8/ScriptDebugServer.cpp:519 #14 0x00007f8a399db064 in blink::ScriptDebugServer::v8DebugEventCallback (eventDetails=...) at ../../sky/engine/bindings/core/v8/ScriptDebugServer.cpp:470 #15 0x00007f8a3937bc93 in v8::internal::Debug::CallEventCallback (this=0x7f8a44015510, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2826 #16 0x00007f8a3937a5af in v8::internal::Debug::ProcessDebugEvent (this=0x7f8a44015510, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2793 #17 0x00007f8a39375589 in v8::internal::Debug::OnDebugBreak (this=0x7f8a44015510, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2657 #18 0x00007f8a39374132 in v8::internal::Debug::Break (this=0x7f8a44015510, args=..., frame=0x7f8a5560e958) at ../../v8/src/debug.cc:939 #19 0x00007f8a393756d0 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7f8a44007380) at ../../v8/src/debug.cc:982 #20 0x00007f8a3937562e in v8::internal::Debug_Break (args_length=0, args_object=0x7f8a5560eb80, isolate=0x7f8a44007380) at ../../v8/src/debug.cc:979 BUG=None R=eseidel@chromium.org Review URL: https://codereview.chromium.org/743673002
212 lines
9.1 KiB
C++
212 lines
9.1 KiB
C++
/*
|
|
* Copyright (c) 2010, Google Inc. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following disclaimer
|
|
* in the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Google Inc. nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "config.h"
|
|
#include "core/inspector/JavaScriptCallFrame.h"
|
|
|
|
#include "bindings/core/v8/ScriptValue.h"
|
|
#include "bindings/core/v8/V8Binding.h"
|
|
#include "v8/include/v8-debug.h"
|
|
|
|
namespace blink {
|
|
|
|
JavaScriptCallFrame::JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8::Object> callFrame)
|
|
: m_isolate(v8::Isolate::GetCurrent())
|
|
, m_debuggerContext(m_isolate, debuggerContext)
|
|
, m_callFrame(m_isolate, callFrame)
|
|
{
|
|
}
|
|
|
|
JavaScriptCallFrame::~JavaScriptCallFrame()
|
|
{
|
|
}
|
|
|
|
JavaScriptCallFrame* JavaScriptCallFrame::caller()
|
|
{
|
|
if (!m_caller) {
|
|
v8::HandleScope handleScope(m_isolate);
|
|
v8::Handle<v8::Context> debuggerContext = m_debuggerContext.newLocal(m_isolate);
|
|
v8::Context::Scope contextScope(debuggerContext);
|
|
v8::Handle<v8::Value> callerFrame = m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "caller"));
|
|
if (callerFrame.IsEmpty() || !callerFrame->IsObject())
|
|
return 0;
|
|
m_caller = JavaScriptCallFrame::create(debuggerContext, v8::Handle<v8::Object>::Cast(callerFrame));
|
|
}
|
|
return m_caller.get();
|
|
}
|
|
|
|
int JavaScriptCallFrame::callV8FunctionReturnInt(const char* name) const
|
|
{
|
|
v8::HandleScope handleScope(m_isolate);
|
|
v8::Context::Scope contextScope(m_debuggerContext.newLocal(m_isolate));
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, name)));
|
|
v8::Handle<v8::Value> result = func->Call(callFrame, 0, 0);
|
|
if (result.IsEmpty() || !result->IsInt32())
|
|
return 0;
|
|
return result->Int32Value();
|
|
}
|
|
|
|
String JavaScriptCallFrame::callV8FunctionReturnString(const char* name) const
|
|
{
|
|
v8::HandleScope handleScope(m_isolate);
|
|
v8::Context::Scope contextScope(m_debuggerContext.newLocal(m_isolate));
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, name)));
|
|
v8::Handle<v8::Value> result = func->Call(callFrame, 0, 0);
|
|
return toCoreStringWithUndefinedOrNullCheck(result);
|
|
}
|
|
|
|
int JavaScriptCallFrame::sourceID() const
|
|
{
|
|
return callV8FunctionReturnInt("sourceID");
|
|
}
|
|
|
|
int JavaScriptCallFrame::line() const
|
|
{
|
|
return callV8FunctionReturnInt("line");
|
|
}
|
|
|
|
int JavaScriptCallFrame::column() const
|
|
{
|
|
return callV8FunctionReturnInt("column");
|
|
}
|
|
|
|
String JavaScriptCallFrame::scriptName() const
|
|
{
|
|
return callV8FunctionReturnString("scriptName");
|
|
}
|
|
|
|
String JavaScriptCallFrame::functionName() const
|
|
{
|
|
return callV8FunctionReturnString("functionName");
|
|
}
|
|
|
|
v8::Handle<v8::Value> JavaScriptCallFrame::scopeChain() const
|
|
{
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "scopeChain")));
|
|
v8::Handle<v8::Array> scopeChain = v8::Handle<v8::Array>::Cast(func->Call(callFrame, 0, 0));
|
|
v8::Handle<v8::Array> result = v8::Array::New(m_isolate, scopeChain->Length());
|
|
for (uint32_t i = 0; i < scopeChain->Length(); i++)
|
|
result->Set(i, scopeChain->Get(i));
|
|
return result;
|
|
}
|
|
|
|
int JavaScriptCallFrame::scopeType(int scopeIndex) const
|
|
{
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "scopeType")));
|
|
v8::Handle<v8::Array> scopeType = v8::Handle<v8::Array>::Cast(func->Call(callFrame, 0, 0));
|
|
return scopeType->Get(scopeIndex)->Int32Value();
|
|
}
|
|
|
|
v8::Handle<v8::Value> JavaScriptCallFrame::thisObject() const
|
|
{
|
|
return m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "thisObject"));
|
|
}
|
|
|
|
String JavaScriptCallFrame::stepInPositions() const
|
|
{
|
|
return callV8FunctionReturnString("stepInPositions");
|
|
}
|
|
|
|
bool JavaScriptCallFrame::isAtReturn() const
|
|
{
|
|
v8::HandleScope handleScope(m_isolate);
|
|
v8::Context::Scope contextScope(m_debuggerContext.newLocal(m_isolate));
|
|
v8::Handle<v8::Value> result = m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "isAtReturn"));
|
|
if (result.IsEmpty() || !result->IsBoolean())
|
|
return false;
|
|
return result->BooleanValue();
|
|
}
|
|
|
|
v8::Handle<v8::Value> JavaScriptCallFrame::returnValue() const
|
|
{
|
|
return m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "returnValue"));
|
|
}
|
|
|
|
v8::Handle<v8::Value> JavaScriptCallFrame::evaluateWithExceptionDetails(const String& expression)
|
|
{
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> evalFunction = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "evaluate")));
|
|
v8::Handle<v8::Value> argv[] = { v8String(m_debuggerContext.newLocal(m_isolate)->GetIsolate(), expression) };
|
|
v8::TryCatch tryCatch;
|
|
v8::Handle<v8::Value> result = evalFunction->Call(callFrame, WTF_ARRAY_LENGTH(argv), argv);
|
|
|
|
v8::Handle<v8::Object> wrappedResult = v8::Object::New(m_isolate);
|
|
if (tryCatch.HasCaught()) {
|
|
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "result"), tryCatch.Exception());
|
|
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "exceptionDetails"), createExceptionDetails(tryCatch.Message(), m_isolate));
|
|
} else {
|
|
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "result"), result);
|
|
wrappedResult->Set(v8::String::NewFromUtf8(m_isolate, "exceptionDetails"), v8::Undefined(m_isolate));
|
|
}
|
|
return wrappedResult;
|
|
}
|
|
|
|
v8::Handle<v8::Value> JavaScriptCallFrame::restart()
|
|
{
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> restartFunction = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "restart")));
|
|
v8::Debug::SetLiveEditEnabled(m_isolate, true);
|
|
v8::Handle<v8::Value> result = restartFunction->Call(callFrame, 0, 0);
|
|
v8::Debug::SetLiveEditEnabled(m_isolate, false);
|
|
return result;
|
|
}
|
|
|
|
ScriptValue JavaScriptCallFrame::setVariableValue(ScriptState* scriptState, int scopeNumber, const String& variableName, const ScriptValue& newValue)
|
|
{
|
|
ScriptState::Scope scriptScope(scriptState);
|
|
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
|
|
v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "setVariableValue")));
|
|
v8::Handle<v8::Value> argv[] = {
|
|
v8::Handle<v8::Value>(v8::Integer::New(m_isolate, scopeNumber)),
|
|
v8String(m_isolate, variableName),
|
|
newValue.v8Value()
|
|
};
|
|
return ScriptValue(scriptState, setVariableValueFunction->Call(callFrame, WTF_ARRAY_LENGTH(argv), argv));
|
|
}
|
|
|
|
v8::Handle<v8::Object> JavaScriptCallFrame::createExceptionDetails(v8::Handle<v8::Message> message, v8::Isolate* isolate)
|
|
{
|
|
v8::Handle<v8::Object> exceptionDetails = v8::Object::New(isolate);
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "text"), message->Get());
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "url"), message->GetScriptOrigin().ResourceName());
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "line"), v8::Integer::New(isolate, message->GetLineNumber()));
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "column"), v8::Integer::New(isolate, message->GetStartColumn()));
|
|
if (!message->GetStackTrace().IsEmpty())
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), message->GetStackTrace()->AsArray());
|
|
else
|
|
exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), v8::Undefined(isolate));
|
|
return exceptionDetails;
|
|
}
|
|
|
|
} // namespace blink
|