DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/packages/flutter/test/material
History
Bruno Leroux b1677f6c0f
Reland fix TextField helper top padding on M3 (#146754) 
This is a reland of https://github.com/flutter/flutter/pull/145087 which was reverted in https://github.com/flutter/flutter/pull/145168.

https://github.com/flutter/flutter/pull/146637 was merged and might help here.

## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.
2024-05-16 05:40:30 +00:00
..
about_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
action_chip_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
action_icons_theme_test.dart
…
adaptive_text_selection_toolbar_test.dart
…
animated_icons_test.dart
…
app_bar_sliver_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
app_bar_test.dart
Split out AppBar/SliverAppBar material tests (#142560)
2024-01-31 16:13:17 +00:00
app_bar_theme_test.dart
…
app_bar_utils.dart
Split out AppBar/SliverAppBar material tests (#142560)
2024-01-31 16:13:17 +00:00
app_builder_test.dart
…
app_test.dart
Leak clean up. (#144803)
2024-03-24 18:01:17 +00:00
arc_test.dart
…
autocomplete_test.dart
Fixes #138773, port autocomplete to OverlayPortal (#140285)
2024-01-24 16:49:18 +00:00
back_button_test.dart
…
badge_test.dart
Makes badge to auto size with content (#146853)
2024-04-25 10:32:45 -07:00
badge_theme_test.dart
Makes badge to auto size with content (#146853)
2024-04-25 10:32:45 -07:00
banner_test.dart
Fix memory leaks in SnackBar (#147212)
2024-05-14 15:26:10 -07:00
banner_theme_test.dart
Fix memory leaks in MaterialBanner (#146963)
2024-04-18 07:21:18 -07:00
bottom_app_bar_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
bottom_app_bar_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
bottom_navigation_bar_test.dart
Fix memory leaks in BottomNavigationBar (#147213)
2024-04-24 10:11:56 -07:00
bottom_navigation_bar_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
bottom_sheet_test.dart
Fix memory leak in BottomNavigationBar (#146748)
2024-04-16 07:53:27 -07:00
bottom_sheet_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
button_bar_test.dart
…
button_bar_theme_test.dart
…
button_style_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
button_theme_test.dart
…
calendar_date_picker_test.dart
Fix CalendarDatePicker day selection shape and overlay (#144317)
2024-03-01 12:44:29 +00:00
card_test.dart
Getting rid of containers (#147432)
2024-05-09 16:31:54 -06:00
card_theme_test.dart
Getting rid of containers (#147432)
2024-05-09 16:31:54 -06:00
checkbox_list_tile_test.dart
Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (#143213)
2024-02-12 10:07:51 -08:00
checkbox_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
checkbox_theme_test.dart
Fix MaterialStateBorderSide lerp in the Checkbox and chips (#148124)
2024-05-10 23:37:05 +00:00
chip_test.dart
Implement computeDryBaseline for RenderChip (#146224)
2024-05-08 00:27:59 +00:00
chip_theme_test.dart
Fix MaterialStateBorderSide lerp in the Checkbox and chips (#148124)
2024-05-10 23:37:05 +00:00
choice_chip_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
circle_avatar_test.dart
Leak clean up. (#144803)
2024-03-24 18:01:17 +00:00
color_scheme_test.dart
Enhance ColorScheme.fromSeed with a new variant parameter (#144805)
2024-04-03 15:54:34 +00:00
colors_test.dart
…
data_table_test_utils.dart
…
data_table_test.dart
Add DataColumn.headingRowAlignment for DataTable (#144006)
2024-04-01 09:42:51 +00:00
data_table_theme_test.dart
Fix memory leak in data table (#146892)
2024-04-18 07:16:32 -07:00
date_picker_test.dart
Fix wide DatePicker input mode button padding for Material 3 (#147236)
2024-04-29 22:14:01 +00:00
date_picker_theme_test.dart
Fix DateRangePickerDialog does not use rangePickerHeaderBackgroundColor from DatePickerTheme in M2 (#147370)
2024-04-26 04:18:24 +00:00
date_range_picker_test.dart
[Fix]: showDateRangePicker with "large" helpText cutoffs the save button (#146049)
2024-04-29 18:18:06 +00:00
debug_test.dart
…
desktop_text_selection_toolbar_button_test.dart
…
desktop_text_selection_toolbar_test.dart
…
dialog_test.dart
Fix insetPadding parameter nullability for dialogs (#143305)
2024-02-13 00:12:02 +00:00
dialog_theme_test.dart
Add clipBehavior to DialogTheme (#147635)
2024-05-10 22:08:59 +00:00
divider_test.dart
…
divider_theme_test.dart
…
drawer_button_test.dart
…
drawer_test.dart
Getting rid of containers (#147432)
2024-05-09 16:31:54 -06:00
drawer_theme_test.dart
Add clipBehavior to DrawerThemeData (#148061)
2024-05-15 18:37:07 +00:00
dropdown_form_field_test.dart
Fix DropdownButtonFormField throws when onChange is null (#146342)
2024-04-08 20:47:13 +00:00
dropdown_menu_test.dart
Fix DropdownMenu keyboard navigation (#147294)
2024-05-10 21:55:49 +00:00
dropdown_menu_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
dropdown_test.dart
Fix M3 text field height + initial step for input decorator M3 test migration (#142981)
2024-02-07 13:57:21 +00:00
elevated_button_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
elevated_button_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
elevation_overlay_test.dart
…
expand_icon_test.dart
…
expansion_panel_test.dart
Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true (#147097) (#147098)
2024-05-09 15:35:07 +00:00
expansion_tile_test.dart
Fix memory leak in ExpansionTile. (#147596)
2024-05-04 18:19:29 -07:00
expansion_tile_theme_test.dart
Fix shape and collapsedShape isn't applied to ExpansionTile's splash ink (#141777)
2024-01-22 11:13:31 +00:00
feedback_test.dart
…
feedback_tester.dart
…
filled_button_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
filled_button_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
filter_chip_test.dart
Fixed few typos (#147087)
2024-04-22 16:49:19 +00:00
flexible_space_bar_collapse_mode_test.dart
…
flexible_space_bar_stretch_mode_test.dart
…
flexible_space_bar_test.dart
Revert "[web] - Fix broken TextField in semantics mode when it's a sibling of Navigator" (#142129)
2024-01-24 16:13:26 +00:00
floating_action_button_location_test.dart
…
floating_action_button_test.dart
Revert "[web] - Fix broken TextField in semantics mode when it's a sibling of Navigator" (#142129)
2024-01-24 16:13:26 +00:00
floating_action_button_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
flutter_logo_test.dart
…
grid_title_test.dart
…
icon_button_test.dart
Add missing overlayColor property in styleFrom methods (#146685)
2024-04-24 11:56:32 +00:00
icon_button_theme_test.dart
Add missing overlayColor property in styleFrom methods (#146685)
2024-04-24 11:56:32 +00:00
icons_test.dart
…
inherited_theme_test.dart
Fix memory leaks in PopupMenu (#147174)
2024-04-22 20:40:33 -07:00
ink_paint_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
ink_sparkle_test.dart
Reverts "Activate InkSparkle on CanvasKit" (#143036)
2024-02-07 02:44:21 +00:00
ink_splash_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
ink_well_test.dart
…
input_chip_test.dart
Fixed few typos (#147087)
2024-04-22 16:49:19 +00:00
input_date_picker_form_field_test.dart
Reland [a11y] Add isEnabled semantics flag to text field (#143601)
2024-02-27 22:49:13 +00:00
input_decorator_test.dart
Reland fix TextField helper top padding on M3 (#146754)
2024-05-16 05:40:30 +00:00
list_tile_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
list_tile_theme_test.dart
Add a minTileHeight to ListTile widget so its height can be customized to less than the default height. (#145244)
2024-03-19 17:58:16 +00:00
localizations_test.dart
CalendarDatePicker doesn't announce selected date on desktop (#143583)
2024-02-21 08:59:24 +00:00
magnifier_test.dart
Magnifier cleanup (#143558)
2024-04-03 15:49:38 -07:00
material_button_test.dart
…
material_state_mixin_test.dart
…
material_state_property_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
material_states_controller_test.dart
…
material_test.dart
…
menu_anchor_test.dart
fix MenuItemButton if child is null (#147485)
2024-05-07 02:39:09 +00:00
menu_bar_theme_test.dart
…
menu_button_theme_test.dart
…
menu_style_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
menu_theme_test.dart
…
mergeable_material_test.dart
Refactoring if chains into switch statements (#144905)
2024-03-11 23:04:57 +00:00
navigation_bar_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
navigation_bar_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
navigation_drawer_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
navigation_drawer_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
navigation_rail_test.dart
🐛 : FIX : Long labels overflowing in extended navigation rail. (#145474)
2024-05-08 11:05:24 +00:00
navigation_rail_theme_test.dart
Fix memory leaks in navigation rail (#146988)
2024-04-18 08:03:19 -07:00
outlined_button_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
outlined_button_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
page_selector_test.dart
Reland fix memory leaks for tab selector (#147689)
2024-05-04 18:23:39 -07:00
page_test.dart
[Impeller] remove unstable debug checked banner for zoom test. (#145097)
2024-03-13 18:07:59 +00:00
page_transitions_theme_test.dart
Fix memory leaks in open upwards page transition (#148046)
2024-05-14 15:25:58 -07:00
paginated_data_table_test.dart
Fix memory leak in paginated tables (#146755)
2024-04-17 11:03:48 -07:00
persistent_bottom_sheet_test.dart
…
popup_menu_test.dart
Fix memory leaks in _PopupMenuRoute (#148373)
2024-05-15 13:50:03 -07:00
popup_menu_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
predictive_back_page_transitions_builder_test.dart
[WIP] Predictive back support for routes (#141373)
2024-03-27 16:43:10 -07:00
progress_indicator_test.dart
Update tokens to v2.3.5 (#145356)
2024-03-28 22:22:20 +00:00
progress_indicator_theme_test.dart
…
radio_list_tile_test.dart
Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (#143213)
2024-02-12 10:07:51 -08:00
radio_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
radio_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
range_slider_test.dart
_RenderValueIndicator leak fix used on RangeSlider (#147581)
2024-05-08 19:04:17 +00:00
raw_material_button_test.dart
…
refresh_indicator_test.dart
…
reorderable_list_test.dart
Fix memory leak in switch painter (#147228)
2024-04-23 11:14:19 -07:00
scaffold_test.dart
Add ability to disable FloatingActionButton scale and rotation animations using FloatingActionButtonAnimator.noAnimation (#146126)
2024-04-29 08:26:19 +00:00
scrollbar_paint_test.dart
…
scrollbar_test.dart
Remove showTrackOnHover from Scrollbar and ScrollbarTheme (#144180)
2024-03-13 16:31:50 +00:00
scrollbar_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
search_anchor_test.dart
fixes SearchAnchor leak (#147652)
2024-05-03 09:34:11 -07:00
search_bar_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
search_test.dart
Reland [a11y] Add isEnabled semantics flag to text field (#143601)
2024-02-27 22:49:13 +00:00
search_view_theme_test.dart
…
segmented_button_test.dart
Add missing overlayColor property in styleFrom methods (#146685)
2024-04-24 11:56:32 +00:00
segmented_button_theme_test.dart
Add missing overlayColor property in styleFrom methods (#146685)
2024-04-24 11:56:32 +00:00
selection_area_test.dart
Disable leak tracking for selection text area (#147273)
2024-04-24 09:06:17 -07:00
slider_test.dart
Fix _RenderValueIndicator leak (#147451)
2024-04-27 17:30:58 -07:00
slider_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
snack_bar_test.dart
Fix floating SnackBar is not centered when RTL and Material 2 (#147861)
2024-05-08 07:34:05 +00:00
snack_bar_theme_test.dart
…
spell_check_suggestions_toolbar_layout_delegate_test.dart
…
spell_check_suggestions_toolbar_test.dart
Implementing control flow collections (#146601)
2024-04-15 16:06:07 +00:00
stepper_test.dart
Remove deprecated TextTheme members (#139255)
2024-03-28 01:20:55 +00:00
switch_list_tile_test.dart
Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (#143213)
2024-02-12 10:07:51 -08:00
switch_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
switch_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
tab_bar_theme_test.dart
Introduce TabBar.textScaler for tab label upper text scale limit (#147232)
2024-05-07 20:54:09 +00:00
tab_controller_test.dart
…
tabbed_scrollview_warp_test.dart
…
tabs_test.dart
Introduce TabBar.textScaler for tab label upper text scale limit (#147232)
2024-05-07 20:54:09 +00:00
tabs_utils.dart
Fix Tab indicator image configuration doesn't inherit device pixel ratio (#146812)
2024-04-17 07:59:07 +00:00
text_button_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
text_button_theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
text_field_focus_test.dart
…
text_field_helper_text_test.dart
…
text_field_restoration_test.dart
…
text_field_splash_test.dart
…
text_field_test.dart
Fixes semantics ordering when there are multiple TextFields with pref… (#148267)
2024-05-14 22:22:51 +00:00
text_form_field_restoration_test.dart
…
text_form_field_test.dart
…
text_selection_test.dart
…
text_selection_theme_test.dart
…
text_selection_toolbar_test.dart
Horizontally expand text selection toolbar buttons in overflow menu (#144391)
2024-03-01 06:40:47 +00:00
text_selection_toolbar_text_button_test.dart
…
text_theme_test.dart
…
theme_data_test.dart
Remove deprecated errorColor from ThemeData (#144078)
2024-03-06 20:41:04 +00:00
theme_defaults_test.dart
…
theme_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
time_picker_test.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
time_picker_theme_test.dart
Widget state properties (#142151)
2024-03-19 17:58:13 +00:00
time_test.dart
…
toggle_buttons_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
toggle_buttons_theme_test.dart
…
tooltip_test.dart
Fix skwasm tests (#145570)
2024-04-09 19:35:07 +00:00
tooltip_theme_test.dart
Implementing null-aware operators throughout the repository (#143804)
2024-02-23 19:02:22 +00:00
tooltip_visibility_test.dart
…
typography_test.dart
Remove deprecated TextTheme members (#139255)
2024-03-28 01:20:55 +00:00
user_accounts_drawer_header_test.dart
Fix leak memory in Tooltip and account detail (#146833)
2024-04-16 12:15:37 -07:00
value_indicating_slider_test.dart
Disable debug banner to stabilize impeller goldens. (#143794)
2024-02-21 00:34:11 +00:00
will_pop_test.dart
…