flutter_flutter

mirror of https://github.com/flutter/flutter.git synced 2026-02-11 05:17:36 +08:00

History

Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664 )

* Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

The TODO comment suggested this mixin would no longer be needed once
a Dart issue on inherited constructors was fixed:
  https://github.com/dart-lang/sdk/issues/31543
That issue is now long since fixed, so I went to go carry out the TODO.

But in doing so, I realized that the mixin's documentation was more
right than the TODO comment: even with that issue fixed, there is a
legitimate use case for this mixin, namely to reuse the implementation
of RenderProxyBox in a class that also inherits from some other base
class.  Moreover, searching GitHub I found an example of a library
that makes real use of that capability.

So I think the right resolution is to accept that this separation
is useful and delete the TODO.

Then, add a test with an extremely simplified sketch of that
real-world example.  In case someone in the future attempts to
simplify this mixin away, the test will point us at the use case
that would be broken by such a change.

Also remove the only in-tree use of the mixin, which was redundant;
and expand the mixin's documentation to advise about that case.

* Tweak formatting

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

* Cut comments

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

2023-02-08 01:17:23 +00:00

animation

Remove unnecessary null checks in flutter/{animation,semantics,scheduler} (#118922 )

2023-01-21 02:20:24 +00:00

cupertino

Fix iOS context menu position when flipped below (#119565 )

2023-02-03 18:14:59 +00:00

foundation

Remove superfluous words from comments (#119055 )

2023-01-25 20:23:24 +00:00

gestures

Remove deprecated kind in GestureRecognizer et al (#119572 )